+1

- run `mvn clean verify` locally with success
- run a couple of end-to-end tests locally with success

Found one minor thing: the class loading e2e test failed on my machine (we had a similar bug a while ago), it might be related to a bug in the script. It runs in every pre-commit test, so I assume this is not a big issue. I will investigate it further tomorrow.

Thanks,
Timo

Am 29.11.18 um 14:12 schrieb Till Rohrmann:
As a small addendum here is the link to the PR for the release announcement
[1].

[1] https://github.com/apache/flink-web/pull/137

Cheers,
Till

On Thu, Nov 29, 2018 at 2:12 PM Chesnay Schepler <ches...@apache.org> wrote:

+1

- source release contains no binaries
- checked signatures
- binary release contains correct LICENSE/NOTICE file
- all required artifacts are available in the maven repository
- scala versions are set correctly in the deployed poms

On 29.11.2018 01:01, Till Rohrmann wrote:
Hi everyone,
Please review and vote on the release candidate #3 for the version 1.7.0,
as follows:
[ ] +1, Approve the release
[ ] -1, Do not approve the release (please provide specific comments)

The complete staging area is available for your review, which includes:
* JIRA release notes [1],
* the official Apache source release and binary convenience releases to
be
deployed to dist.apache.org [2], which are signed with the key with
fingerprint 1F302569A96CFFD5 [3],
* all artifacts to be deployed to the Maven Central Repository [4],
* source code tag "release-1.7.0-rc3" [5],

Please use this document for coordinating testing efforts: [6]

Since the new RC only contains minor bug fixes and LICENSE updates, the
vote will end on Thursday the 29th of November at 6 pm CET. It is adopted
by majority approval, with at least 3 PMC affirmative votes.

Thanks,
Till

[1]

https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12343585
[2] https://dist.apache.org/repos/dist/dev/flink/flink-1.7.0-rc3/
[3] https://dist.apache.org/repos/dist/release/flink/KEYS
[4]
https://repository.apache.org/content/repositories/orgapacheflink-1196
[5] https://github.com/apache/flink/tree/release-1.7.0-rc3
[6]

https://docs.google.com/document/d/1KEfJO5iE-0f1GQMoue93l-bjf531FG0EXQuzNbzyQuw/edit?usp=sharing
Pro-tip: you can create a settings.xml file with these contents:

<settings>
<activeProfiles>
    <activeProfile>flink-1.7.0</activeProfile>
</activeProfiles>
<profiles>
    <profile>
      <id>flink-1.7.0</id>
      <repositories>
        <repository>
          <id>flink-1.7.0</id>
          <url>

https://repository.apache.org/content/repositories/orgapacheflink-1196/
          </url>
        </repository>
        <repository>
          <id>archetype</id>
          <url>

https://repository.apache.org/content/repositories/orgapacheflink-1196/
          </url>
        </repository>
      </repositories>
    </profile>
</profiles>
</settings>

And reference that in you maven commands via --settings
path/to/settings.xml. This is useful for creating a quickstart based on
the
staged release and for building against the staged jars.



Reply via email to