Hi,

-1

I've checked:
+ compiling sources works
+ verified signatures - OK

- the release notes are missing two issues: FLINK-10259, FLINK-10247,
and are including an issue that was actually not merged for this branch:
FLINK-4052
- I get the same test failures as Fabian did:

Java HotSpot(TM) 64-Bit Server VM warning: ignoring option
MaxPermSize=128m; support was removed in 8.0
Running org.apache.flink.addons.hbase.HBaseConnectorITCase
Tests run: 2, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 0.557
sec <<< FAILURE! - in org.apache.flink.addons.hbase.HBaseConnectorITCase
org.apache.flink.addons.hbase.HBaseConnectorITCase  Time elapsed: 0.556
sec  <<< ERROR!
java.lang.ClassCastException:
org.apache.commons.logging.impl.SLF4JLocationAwareLog cannot be cast to
org.apache.commons.logging.impl.Log4JLogger

org.apache.flink.addons.hbase.HBaseConnectorITCase  Time elapsed: 0.557
sec  <<< ERROR!
java.lang.NullPointerException


Results :

Tests in error:
org.apache.flink.addons.hbase.HBaseConnectorITCase.org.apache.flink.addons.hbase.HBaseConnectorITCase
  Run 1: HBaseConnectorITCase>HBaseTestingClusterAutostarter.setUp:152 »
ClassCast org....

  Run 2:
HBaseConnectorITCase>HBaseTestingClusterAutostarter.tearDown:243 »
NullPointer


On 18/10/2018 23:55, Fabian Hueske wrote:
> Hi,
>
> I checked the following things:
>
> * no dependencies added or changed since Flink 1.5.4
> * compiling the source distribution without tests succeeds
> * compiling the source distribution with tests fails (see exception
> appended below). When I restart the compilation, it goes past flink-hbase
> but fails later in another module.
>
> The compilation failure might be related to my environment as the
> compilation of the Flink 1.6.2 RC1 also failed due to some issue related to
> logging classes.
> We should check if others can compile the sources with tests.
>
> Until we don't know what causes the issue, I vote
>
> -1 to release this RC.
>
> Best, Fabian
>
> ----
>
> OpenJDK 64-Bit Server VM warning: ignoring option MaxPermSize=128m; support
> was removed in 8.0
> Running org.apache.flink.addons.hbase.HBaseConnectorITCase
> Tests run: 2, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 0.482 sec
> <<< FAILURE! - in org.apache.flink.addons.hbase.HBaseConnectorITCase
> org.apache.flink.addons.hbase.HBaseConnectorITCase  Time elapsed: 0.481
> sec  <<< ERROR!
> java.lang.ClassCastException:
> org.apache.commons.logging.impl.SLF4JLocationAwareLog cannot be cast to
> org.apache.commons.logging.impl.Log4JLogger
>
> org.apache.flink.addons.hbase.HBaseConnectorITCase  Time elapsed: 0.482
> sec  <<< ERROR!
> java.lang.NullPointerException
>
>
> Results :
>
> Tests in error:
> org.apache.flink.addons.hbase.HBaseConnectorITCase.org.apache.flink.addons.hbase.HBaseConnectorITCase
>   Run 1: HBaseConnectorITCase>HBaseTestingClusterAutostarter.setUp:152 »
> ClassCast org....
>   Run 2: HBaseConnectorITCase>HBaseTestingClusterAutostarter.tearDown:243 »
> NullPointer
>
>
>
> Am Do., 18. Okt. 2018 um 13:17 Uhr schrieb Chesnay Schepler <
> ches...@apache.org>:
>
>> Hi everyone,
>> Please review and vote on the release candidate #1 for the version
>> 1.5.5, as follows:
>> [ ] +1, Approve the release
>> [ ] -1, Do not approve the release (please provide specific comments)
>>
>>
>> The complete staging area is available for your review, which includes:
>> * JIRA release notes [1],
>> * the official Apache source release and binary convenience releases to
>> be deployed to dist.apache.org [2], which are signed with the key with
>> fingerprint 11D464BA [3],
>> * all artifacts to be deployed to the Maven Central Repository [4],
>> * source code tag "release-1.5.5-rc1" [5],
>> * website pull request listing the new release and adding announcement
>> blog post [6].
>>
>> The vote will be open for at least 72 hours. It is adopted by majority
>> approval, with at least 3 PMC affirmative votes.
>>
>> Thanks,
>> Release Manager
>>
>> [1]
>>
>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12344112
>> [2] https://dist.apache.org/repos/dist/dev/flink/flink-1.5.5/
>> [3] https://dist.apache.org/repos/dist/release/flink/KEYS
>> [4] https://repository.apache.org/content/repositories/orgapacheflink-1185
>> [5]
>>
>> https://gitbox.apache.org/repos/asf?p=flink.git;a=tag;h=refs/tags/release-1.5.5-rc1
>> [6] https://github.com/apache/flink-web/pull/127
>>
>>

Attachment: signature.asc
Description: OpenPGP digital signature

Reply via email to