Hi, I opened a PR to extend the PR description template [1].
@jincheng sun <sunjincheng...@gmail.com>, I'd suggest to start a separate discussion about a template for Jira ticket. Let's try to keep this thread focused on the tooling to support the review process. Thanks, Fabian [1] https://github.com/apache/flink/pull/6873 Am Do., 18. Okt. 2018 um 07:34 Uhr schrieb jincheng sun < sunjincheng...@gmail.com>: > I like @Fabian Hueske <fhue...@gmail.com> 's proposal, currently design > the > template is pretty good idea. Because the template is convenient for > contributors to follow the norms to community contributions. About > templates, I think we also need an JIRA description template, > In particular, in the case of current JIRA break previous users’ programs > and setups, the contributions must describe them in detail in JIRA > description. And we should make a discussion, get at least one Committed > consensus in the JIRA discussion before dive into code. > > Best， > Jincheng > > Stephan Ewen <se...@apache.org> 于2018年9月21日周五 上午3:56写道： > > > Hi all! > > > > This thread is dedicated to discuss the tooling we want to use for the > > reviews. > > It is spun out of the proposal *"A more structured approach to reviews > and > > contributions".* > > > > > > *Suggestions brought up so far* > > > > > > *Use comments / template with checklist* > > > > - Easy to do > > - Manual, a bit of reviewer overhead, reviewers needs to know the > process > > > > *Use a bot * > > > > - Automatically add the review questions to each new PR > > - Further details? > > > > *Use GitHub labels* > > > > - Searchable > > - possibly not obvious to new contributors > > - Any restrictions? Do members need to apply at ASF infra to have > > permissions to edit github labels? > > >
