Hi Tison, at the moment there is formal way to verify performance improvements. What you can do is to provide your measurements by adding the graphs to the PR thread and specify the setup. Then others could try to verify these numbers by running their own benchmark.
Cheers, Till On Wed, Jul 18, 2018 at 1:34 AM 陈梓立 <wander4...@gmail.com> wrote: > Hi all, > > Recently I pull 3 PRs about performance improvements[1][2][3]. Unit tests > will verify their correctness, and in the real scenario, we have benchmark > report to confirm that they do help for performance. > > I wonder what is the formal way to verify a performance improvement. Is it > to give out a benchmark report, or run a standard benchmark, or add > performance test(I don't know how to do it), or anything else. > > Looking forward for your reply. > > Best, > tison. > > [1] https://github.com/apache/flink/pull/6339 > [2] https://github.com/apache/flink/pull/6345 > [3] https://github.com/apache/flink/pull/6353 >
