+1. you can also run `mvn clean verify` locally before a PR, or `mvn verify -o` against the module you modified (this will speed up the build)
On Tue, May 29, 2018 at 5:34 AM, Chesnay Schepler <ches...@apache.org> wrote: > There are some tests that are unstable. Committers will evaluate whether > the failure is related to the PR. > Please do not push commits for the sake of getting that perfect green > build. > > In your particular case you've added files that do not have an apache > license header: > > 17:43:48.333 [ERROR] Failed to execute goal > org.apache.rat:apache-rat-plugin:0.12:check > (default) on project flink-parent: Too many files with unapproved license: > 1 See RAT report in: /home/travis/build/Jicaar/flink/target/rat.txt -> > [Help 1] > > You can run mvn validate locally which will look for missing license > headers. > > > On 29.05.2018 14:18, jpcarter...@gmail.com wrote: > >> I am new to committing code to a git repo, so I apologize if I ask >> anything really obvious. >> >> So I have submitted a pull request for Flink and the TravisIO tests all >> pass except ones where TEST=“misc”. Looking through the output of the tests >> I can’t figure out what is wrong. There were tests that failed before >> because of improper formatting and the like, but I fixed those and the >> relevant tests passed. So I am at a bit of a loss with what I am missing >> now. >> >> Here is the TravisIO link: https://travis-ci.org/Jicaar/f >> link/builds/374488723 . >> >> Thanks for any help in advance! >> >> >
