+1 - Verified signatures and hashes - Built from source with Hadoop 2.8.1 and Scala 2.11.7, tests pass locally - No binaries in source archives; no missing artifacts - To cover the extra Kafka connector bug fixes that were added in between RCs (FLINK-9349 and FLINK-9295), I executed Kafka end-to-end test non-stop for over 3 hours. All executions passed. - Did one pass over the run-nightly-tests.sh and pre-commit-tests.sh, no failures
Cheers, Gordon On 25 May 2018 at 10:41:00 PM, Timo Walther (twal...@apache.org) wrote: +1 - I build the release locally with the minor issues mentioned in the last thread - I executed a couple of table programs on a local cluster - Ran some end-to-end tests locally @Piotr: Given the amount of changes that went into this release it is natural to find a lot of bugs. We have also increased our testing efforts (e.g. by having more automated tests) this time. Timo Am 25.05.18 um 14:12 schrieb Aljoscha Krettek: > +1 > > - verified signature and hashes > - ran an example on a kerberized Hadoop 2.8.3 cluster, both with kinit and by > using keytab > >> On 25. May 2018, at 11:56, Piotr Nowojski <pi...@data-artisans.com> wrote: >> >> Mild +1 from me. I’m concerned about the rate of bugs that we are >> discovering for each RC, which suggests that there are still some release >> blockers out there (but I’m not aware of any right now). >> >> Piotrek >> >>> On 25 May 2018, at 11:25, Till Rohrmann <trohrm...@apache.org> wrote: >>> >>> +1 >>> >>> - Checked checksums and GPG files >>> - Verified that source archives do not contain any binaries >>> - Built Flink with Hadoop 2.8.1 and Scala 2.11.7 from source release >>> - Verified LICENSE and NOTICE file: The LICENSE file contains unnecessary >>> entries for jline-reader and jline-terminal >>> - Checked licenses of newly added dependencies >>> - Checked pom files >>> - Read README.md >>> - Run manual tests in flink-tests: CheckForbiddenMethodsUsage fails >>> because org.apache.flink.queryablestate.messages.KvStateRequest.serialize() >>> >>> uses getBytes without charset. This is non-blocking because it was >>> introduced with 1.4 or before >>> - Checked builds with SBT and the SBT quickstarts >>> - Executed the run-nightly-tests.sh for 10 hours without failures >>> - Executed Jepsen tests without failures >>> >>> There is a known problem when enabling SSL encryption which can lead to >>> failures [1]. Since there is a workaround for this problem, I would propose >>> >>> to not block the release on it and fix it with Flink 1.5.1. >>> >>> [1] https://issues.apache.org/jira/browse/FLINK-9437 >>> >>> Cheers, >>> Till >>> >>> >>> On Thu, May 24, 2018 at 6:51 PM, Till Rohrmann <trohrm...@apache.org> >>> wrote: >>> >>>> Hi everyone, >>>> >>>> Please review and vote on the release candidate #6 for the version 1.5.0, >>>> as follows: >>>> [ ] +1, Approve the release >>>> [ ] -1, Do not approve the release (please provide specific comments) >>>> >>>> >>>> The complete staging area is available for your review, which includes: >>>> * JIRA release notes [1], >>>> * the official Apache source release and binary convenience releases to be >>>> >>>> deployed to dist.apache.org [2], which are signed with the key with >>>> fingerprint 1F302569A96CFFD5 [3], >>>> * all artifacts to be deployed to the Maven Central Repository [4], >>>> * source code tag "release-1.5.0-rc6" [5], >>>> * PR to update the community web site [6] >>>> >>>> Please use this document for coordinating testing efforts: [7] >>>> >>>> The voting periods ends tomorrow at 5pm CET. It is adopted by majority >>>> approval, with at least 3 PMC affirmative votes. >>>> >>>> Thanks, >>>> Your friendly Release Manager >>>> >>>> [1] https://issues.apache.org/jira/secure/ReleaseNote.jspa? >>>> projectId=12315522&version=12341764 >>>> [2] http://people.apache.org/~trohrmann/flink-1.5.0-rc6/ >>>> [3] https://dist.apache.org/repos/dist/release/flink/KEYS >>>> [4] https://repository.apache.org/content/repositories/ >>>> orgapacheflink-1161/ >>>> [5] https://git-wip-us.apache.org/repos/asf?p=flink.git;a=commit;h= >>>> c61b108b8eaa22eac3dc492b3c95c22b4177003f >>>> [6] https://github.com/apache/flink-web/pull/106 >>>> [7] https://docs.google.com/document/d/10KDBLzt25Z44pdZBSm8MTeKldc4UT >>>> UAbAynfuVQWOt0/edit?usp=sharing >>>> >>>> Pro-tip: you can create a settings.xml file with these contents: >>>> >>>> <settings> >>>> <activeProfiles> >>>> <activeProfile>flink-1.5.0</activeProfile> >>>> </activeProfiles> >>>> <profiles> >>>> <profile> >>>> <id>flink-1.5.0</id> >>>> <repositories> >>>> <repository> >>>> <id>flink-1.5.0</id> >>>> <url> >>>> https://repository.apache.org/content/repositories/ >>>> orgapacheflink-1161/ >>>> </url> >>>> </repository> >>>> <repository> >>>> <id>archetype</id> >>>> <url> >>>> https://repository.apache.org/content/repositories/ >>>> orgapacheflink-1161/ >>>> </url> >>>> </repository> >>>> </repositories> >>>> </profile> >>>> </profiles> >>>> </settings> >>>> >>>> And reference that in you maven commands via --settings >>>> path/to/settings.xml. This is useful for creating a quickstart based on >>>> the >>>> staged release and for building against the staged jars. >>>> >>>>
