+1 I also went through the list of changes and checked for suspicious code. Looks good from my side.
Found one minor thing: We should also update our sbt/gitter templates for the improved quickstart. > Am 07.03.2018 um 16:24 schrieb Aljoscha Krettek <aljos...@apache.org>: > > +1 > > - checked hashes and signatures > - ran some Flink release testing programs against the binary distribution > - built the source code > - wen't through the list of changes manually and I think they're good > >> On 1. Mar 2018, at 05:30, Tzu-Li (Gordon) Tai <tzuli...@apache.org> wrote: >> >> Hi everyone, >> >> Please review and vote on release candidate #2 for Flink 1.4.2, as follows: >> [ ] +1, Approve the release >> [ ] -1, Do not approve the release (please provide specific comments) >> >> The complete staging area is available for your review, which includes: >> * JIRA release notes [1], >> * the official Apache source release and binary convenience releases to be >> deployed to dist.apache.org [2], which are signed with the key with >> fingerprint 1C1E2394D3194E1944613488F320986D35C33D6A [3], >> * all artifacts to be deployed to the Maven Central Repository [4], >> * source code tag “release-1.4.2-rc2” [5], >> * website pull request listing the new release [6]. >> * A complete list of all new commits in release-1.4.2-rc2, since >> release-1.4.1 [7] >> >> The vote will be open for at least 72 hours. >> Please test the release and vote for the release candidate before Monday >> (March 5th), 7pm CET. >> It is adopted by majority approval, with at least 3 PMC affirmative votes. >> >> Thanks, >> Gordon >> >> [1] >> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12342745 >> >> [2] http://people.apache.org/~tzulitai/flink-1.4.2-rc2/ >> [3] https://dist.apache.org/repos/dist/release/flink/KEYS >> [4] https://repository.apache.org/content/repositories/orgapacheflink-1149 >> [5] >> https://git-wip-us.apache.org/repos/asf?p=flink.git;a=tag;h=0f4978eb62d9e93efafc56d6524cf65d5e5a3a69 >> [6] https://github.com/apache/flink-web/pull/102 >> [7] >> * 93f823fff7 - [FLINK-8451] [serializers] Make Scala tuple serializer >> deserialization more failure tolerant (16 hours ago) >> * 51231c471b - [FLINK-8791] [docs] Fix documentation about configuring >> dependencies (18 hours ago) >> * 0c848aa98b - [FLINK-8764] [docs] Adjust quickstart documentation (18 hours >> ago) >> * 4eb0a0fb9f - [FLINK-8767] [quickstarts] Set the maven.compiler.source and >> .target properties for Java Quickstart (18 hours ago) >> * 23c37cf43c - [FLINK-8766] [quickstarts] Pin scala runtime version for Java >> Quickstart (18 hours ago) >> * 11e19a56bf - [FLINK-8765] [quickstarts] Simplify quickstart properties (18 >> hours ago) >> * fa306385fe - [FLINK-8764] [quickstarts] Make quickstarts work out of the >> box for IDE and JAR packaging (18 hours ago) >> * 6bd35a3c53 - [hotfix] [quickstarts] Fix block comments in program stubs. >> (18 hours ago) >> * 4a60fcb0f4 - [hotfix] [quickstarts] Fix header and package declaration >> order. (18 hours ago) >> * 179cfdd4c6 - [FLINK-8762] [quickstarts] Make ‘StreamingJob’ the default >> main class and remove WordCount example from the quickstart. (18 hours ago) >> * 392cfaaed9 - [FLINK-8798] [core] Force ‘commons-logging’ to be >> parent-first loaded. (2 days ago) >> * b74c705157 - [FLINK-8543] Don’t call super.close() in >> AvroKeyValueSinkWriter (2 days ago) >> * a0193f10af - [FLINK-8772] [kafka] Fix missing log parameter (3 days ago) >> * 0396fc8c03 - [hotfix] [test] Also trap INT signal in Kafka end-to-end test >> (3 days ago) >> * 59169d0eeb - [hotfix] [test] Make test-streaming-kafka010.sh more flexible >> for local execution (3 days ago) >> * cb6a8a68c4 - [FLINK-8741] [kafka] Fix incorrect user code classloader in >> FlinkKafkaConsumer (3 days ago) >> * 0d89a1c9f1 - [hotfix] Update docs version to Flink 1.4.1 (6 days ago) >> * f06ec38f22 - [FLINK-8735] Add new StatefulJobSavepointMigrationITCase (7 >> days ago) >> * 82e6f8d5b8 - [FLINK-8735] Rename StatefulJobSavepointMigrationITCase (7 >> days ago) >> * a7df42485a - [FLINK-8574][travis] Add timestamp to logging messages (9 >> days ago) >> * 527faf63e2 - [hotfix][prometheus][tests] Add utility for generating port >> ranges (9 days ago) >> * d88f43bb06 - [hotfix][prometheus] Document internal usage of >> CollectorRegistry.defaultRegistry (9 days ago) >> * 45efe4702a - [FLINK-8621][prometheus][tests] Remove >> endpointIsUnavailableAfterReporterIsClosed() (9 days ago) >> * 528317c8f2 - [FLINK-8692][docs] Remove extra parenthesis in scala code >> samples (10 days ago) >> * cc76c323f0 - [FLINK-8303] [docs] Allow to overwrite ruby/gem binary (13 >> days ago) >> * d4435e1596 - [FLINK-8303] Add hawkins back to Gemfile (13 days ago) >> * 50b648473f - [FLINK-8308] Remove explicit yajl-ruby dependency, update >> Jekyll to 3+ (13 days ago) >> * 054af99746 - [FLINK-8520][cassandra] Fix race condition (13 days ago) >> * 1b70f50d93 - [FLINK-8576][QS] Reduce verbosity when classes can’t be found >> (13 days ago) >> * f2b5635bc8 - [hotfix] Remove more checkState() calls from SharedBuffer >> serialization (2 weeks ago) >> * 59f9ded8fd - [FLINK-8652] [QS] Reduce log level in getKvState to DEBUG. (2 >> weeks ago) >> * a044d9d6ca - [hotfix] Remove costly logging statements from CEP >> SharedBuffer (2 weeks ago) >> * bafb91eeb5 - [FLINK-8423] OperatorChain#pushToOperator catch block may >> fail with NPE (2 weeks ago) >>
