Nico Kruber created FLINK-7992:
----------------------------------

             Summary: extend PR template with S3 question
                 Key: FLINK-7992
                 URL: https://issues.apache.org/jira/browse/FLINK-7992
             Project: Flink
          Issue Type: Improvement
          Components: Documentation
            Reporter: Nico Kruber
            Assignee: Nico Kruber


S3 file system tests are only run if AWS credentials are specified, i.e. 
{{ARTIFACTS_AWS_BUCKET}}, {{ARTIFACTS_AWS_ACCESS_KEY}}, and 
{{ARTIFACTS_AWS_SECRET_KEY}}. Since these must remain secret, they are only set 
in Apache Flink's Travis CI configuration and not available in the Travis runs 
on pull requests (PR) to not leak them in any way. This however means that if a 
contributor changes something S3-related, the PR's test results will not 
reflect the actual changes and if something breaks there, we will only see it 
once merged.

Therefore, I propose to add one more question to the PR template so that the 
committer is aware of this fact and the need to run the tests in his own Travis 
CI configuration first with proper AWS credentials set up.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to