+1 - Checked files in staging repository - version 2.0 set correctly in the poms - jackson jar looks good - flink shaded netty contains the netty router license (including the copyright statement) - Checked the files in the RC directory - md5 sum is correct - src archive doesn't contain any binaries
On Wed, Oct 25, 2017 at 4:08 PM, Chesnay Schepler <ches...@apache.org> wrote: > +1 > > - built shaded source jars using the -Dshade-sources switch > - checked contents of jackson jar > - no unshaded classes > - shading pattern is correct (i.e. it starts with > org.apache.flink.shaded.jackson2) > - I've used the shaded-jackson dependency in a WIP branch integrating it > into flink > > On 25.10.2017 14:52, Aljoscha Krettek wrote: > >> +1 >> >> - I went through ALL new commits since the 1.0 release and verified them >> - verified signature and hashes >> >> Out of curiosity, we don't have source jars in maven for these, right? >> >> On 25. Oct 2017, at 09:15, Chesnay Schepler <ches...@apache.org> wrote: >>> >>> Dear Flink community, >>> >>> Please vote on releasing the following candidate as Apache Flink-shaded >>> version 2.0. >>> >>> The commit to be voted in: >>> https://gitbox.apache.org/repos/asf/flink-shaded/commit/4c32 >>> 4d398172a861fde16825b8262ed0b16c61ec >>> >>> Branch: >>> release-2.0-rc1 >>> >>> The release artifacts to be voted on can be found at: >>> http://home.apache.org/~chesnay/flink-shaded-2.0-rc1/ < >>> http://home.apache.org/%7Echesnay/flink-shaded-2.0-rc1/> >>> >>> The release artifacts are signed with the key with fingerprint >>> 19F2195E1B4816D765A2C324C2EED7B111D464BA: >>> http://www.apache.org/dist/flink/KEYS >>> >>> The staging repository for this release can be found at: >>> https://repository.apache.org/content/repositories/orgapacheflink-1137 >>> >>> ------------------------------------------------------------- >>> >>> >>> The vote ends on Monday(10am CEST), October 30th, 2017. >>> >>> [ ] +1 Release this package as Apache Flink-shaded 2.0 >>> [ ] -1 Do not release this package, because ... >>> >>> ------------------------------------------------------------- >>> >>> This release adds jackson:2.7.9 to the list of shaded dependencies. In >>> this dependency we bundle jackson-core, jackson-annotation and >>> jackson-databind. In addition, a build profile was added that allows the >>> creation of a shaded source-jar, making flink-shaded dependencies easier to >>> work with. >>> >>> ------------------------------------------------------------- >>> >>> The flink-shaded project contains a number of shaded dependencies for >>> Apache Flink. >>> >>> The purpose of these dependencies is to provide a single instance of a >>> shaded dependency in the Apache Flink distribution, instead of each >>> individual module shading the dependency. >>> >>> For more information, see >>> https://issues.apache.org/jira/browse/FLINK-6529. >>> >> >> >
