+1 - Built source with Scala 2.10 / Scala 2.11, tests pass - Re-run serializer tests performed in RC1, tests pass - Tested FLINK-6921, FLINK-6948 (upgraded enum by appending new constants, restore successful)
Best, Gordon On 22 June 2017 at 1:17:12 AM, Ted Yu (yuzhih...@gmail.com) wrote: +1 Ran unit test suite which passed. On Wed, Jun 21, 2017 at 8:27 AM, Robert Metzger <rmetz...@apache.org> wrote: > +1 (binding) > > - Checked staging repository: ES5 connector is present > - quickstart-java points to 1.3.1 > - yarn session starts > - per-job YARN submission works / log files look good. > - Executed all tests listed here [1] without any issues / log files looked > good afterwards > - The source doesn't contain any binaries > - checked (some) md5sums for correctness > > > [1] https://github.com/aljoscha/FliRTT/blob/master/test-flink.sh#L36 > > > > > On Wed, Jun 21, 2017 at 5:06 PM, Robert Metzger <rmetz...@apache.org> > wrote: > > > I see that this is an issue we should address, but on the other hand, > > there's a large list of issues we need to address with 1.3.1 already. > > If we keep delaying minor releases for every issue we find, we'll never > > release it :) > > > > > > > > On Wed, Jun 21, 2017 at 3:51 PM, Stefan Richter < > > s.rich...@data-artisans.com> wrote: > > > >> Hi, > >> > >> I suggest to include https://issues.apache.org/jira/browse/FLINK-6964 < > >> https://issues.apache.org/jira/browse/FLINK-6964> to the release. > >> > >> Best, > >> Stefan > >> > >> > Am 21.06.2017 um 09:46 schrieb Robert Metzger <rmetz...@apache.org>: > >> > > >> > Dear Flink community, > >> > > >> > Please vote on releasing the following candidate as Apache Flink > version > >> > 1.3.1. > >> > > >> > The commit to be voted on: > >> > *http://git-wip-us.apache.org/repos/asf/flink/commit/1ca6e5b6 > >> > <http://git-wip-us.apache.org/repos/asf/flink/commit/1ca6e5b6>* > >> > > >> > Branch: > >> > release-1.3.1-rc2 > >> > > >> > The release artifacts to be voted on can be found at: > >> > *http://people.apache.org/~rmetzger/flink-1.3.1-rc2/ > >> > <http://people.apache.org/~rmetzger/flink-1.3.1-rc2/>* > >> > > >> > The release artifacts are signed with the key with fingerprint > D9839159: > >> > http://www.apache.org/dist/flink/KEYS > >> > > >> > The staging repository for this release can be found at: > >> > *https://repository.apache.org/content/repositories/ > orgapacheflink-1125 > >> > <https://repository.apache.org/content/repositories/ > orgapacheflink-1125 > >> >* > >> > > >> > > >> > ------------------------------------------------------------- > >> > > >> > > >> > The vote ends on Thursday (5pm CEST), June 22, 2016. > >> > IMPORTANT: I've reduced the voting time to only one day because the > >> number > >> > of changes between RC1 and RC2 are mostly in the table API (mostly > >> > documentation) and the serializer changes Till and Gordon were working > >> on. > >> > The list of changes is the following > >> > - Reworked Table API documentation (this is a set of commits) > >> > - [FLINK-6817] [table] Add OverWindowWithPreceding class to guide > users > >> > - [FLINK-6859] [table] Do not delete timers in > StateCleaningCountTrigger > >> > - [FLINK-6930] [table] Forbid selecting window start/end on row-based > T… > >> > - [FLINK-6886] [table] Fix conversion of Row Table to POJO > >> > - [FLINK-6602] [table] Prevent TableSources with empty time attribute > n… > >> > - [FLINK-6941] [table] Validate that start and end window properties > ar… > >> > - [FLINK-6881] [FLINK-6896] [table] Creating a table from a POJO and > de… > >> > - [FLINK-6921] [serializer] Allow EnumValueSerializer to deal with > appe… > >> > - [FLINK-6948] [serializer] Harden EnumValueSerializer to detect > change… > >> > - [FLINK-6922] [serializer] Remove Java serialization from > Enum(Value)S… > >> > - [FLINK-6652] [core] Fix handling of delimiters split by buffers in > De… > >> > > >> > > >> > > >> > [ ] +1 Release this package as Apache Flink 1.3.1 > >> > [ ] -1 Do not release this package, because ... > >> > >> > > >