Hi Ivan! Thank you for bringing this thread up. I agree, we need to do something about how some modules are currently handled.
The CEP library definitely needs more active committers. Adding new committers will be necessary, I think, but as you mentioned, it needs at least one (better more) experienced committers that can help the new committers to get into the process and the technical matter. Otherwise we cannot keep up a good quality. How important the involvement of experienced committers is even for something that seems more or less self-contained (like the CEP library), has already been visible in some previous pull requests to the CEP library - those were not compatible with the overall design or with the strategy for making streaming applications rescalable. It is hard for new committers to be aware of all that, hence the need for some experienced committers to help. Currently, the community is pushing hard on the 1.2 release: testing, docs, fixes, usability. I expect that to take not too much longer. After that, we will kick off some threads discussing about community and project structure. That should involve how to deal with projects like the CEP library, and also with the sheer size of the project and code base in general. Greetings, Stephan On Sun, Jan 15, 2017 at 11:28 PM, Ivan Mushketyk <ivan.mushke...@gmail.com> wrote: > Hi Alexey, > > I agree with you. Most contributors are overloaded, but PRs for other > sub-projects are reviewed much faster. In my experience, in most cases, you > can get a first review for a PR in less than a week and it's usually merged > within a month or less. > Flink CEP is a notable exception. I believe the main reason for that is > that there is only one core committer who currently can review Flink CEP > PRs (Till) and he is very busy with other work. > > Best regards, > Ivan. > > On Sun, 15 Jan 2017 at 19:22 Alexey Demin <diomi...@gmail.com> wrote: > > > Hi Ivan, > > > > I think problem not only with CEP project. > > Main contributors overloaded and simple fixes frequently are staying as > PR > > without merge. > > > > You can see how amount of open PR increasing over time. > > > > Thanks, > > Alexey Diomin > > > > > > 2017-01-15 17:18 GMT+04:00 Ivan Mushketyk <ivan.mushke...@gmail.com>: > > > > > Hi Dmitry, > > > > > > Your contributions are welcomed, but right now the most critical issue > is > > > that CEP project does not have an experienced Flink contributor who can > > > review and approve new pull requests. > > > > > > I hope that Flink community will promptly resolve the issue, so feel > free > > > to take select a JIRA issue and work on it. > > > > > > Best regards, > > > Ivan. > > > > > > On Sat, 14 Jan 2017 at 12:29 Dmitry Vorobiov <2belikespr...@gmail.com> > > > wrote: > > > > > > I would be interested to contribute to CEP. I am following Flink > project, > > > but haven't contributed yet. Next 2 weeks I am a bit busy with my work, > > but > > > then I llbe happy to dig into it. I used to work in IoT so event > > processing > > > is a close topic for me. > > > > > > Dmitry. > > > On Fri, 13 Jan 2017 at 14:58, Ivan Mushketyk <ivan.mushke...@gmail.com > > > > > wrote: > > > > > > > Hi Till, > > > > > > > > Thank you for your reply. > > > > > > > > I wonder if the following will work. > > > > What if you can find a Flink committer/committers that will review > and > > > > iterate on CEP PRs before you review them. They don't need to know > all > > > CEP > > > > internals, but they will help to eradicate most of the issues. > > > > Then you will have to review PRs only when most of the issues are > fixed > > > and > > > > to make a final decision about whether to merge a PR or not. In this > > > case, > > > > you probably won't need to spend much time on reviewing CEP PRs. As > an > > > > additional bonus, after some time these new CEP reviewers will learn > > > enough > > > > about CEP to review them by themselves without your input. > > > > > > > > What do you think about this? > > > > > > > > Best regards, > > > > Ivan. > > > > > > > > On Fri, 13 Jan 2017 at 11:28 Till Rohrmann <trohrm...@apache.org> > > wrote: > > > > > > > > Hi Ivan, > > > > > > > > first of all let me apologise for the bad experience you've had with > > > > opening CEP PRs in the past. > > > > > > > > The general problem as you've said is that there is nobody who > reviews > > > the > > > > open PRs. I used to do this in the but at the moment I hardly find > time > > > due > > > > to other commitments. > > > > > > > > I think the way to mitigate the problem is to attract more > contributors > > > and > > > > committers who are willing to spend time on PR reviews and finally > > (this > > > > applies only to committers) to commit the PRs. I can try to reach out > > to > > > > other committers to make them aware of the CEP library. > > > > > > > > Cheers, > > > > Till > > > > > > > > On Thu, Jan 12, 2017 at 9:15 AM, <ruben.casado.teje...@accenture.com > > > > > > wrote: > > > > > > > > > +1 > > > > > > > > > > I have some clientes interested in CEP features > > > > > > > > > > El 11/1/17 16:23, "Ivan Mushketyk" <ivan.mushke...@gmail.com> > > > escribió: > > > > > > > > > > Hi Flink devs, > > > > > > > > > > Roughly half a year ago I implemented several PRs for > > > > > Flink-CEP[1][2][3] > > > > > but since then there were no progress with the reviews. What is > > > > > frustrating > > > > > about this situation is that Flink customers are asking for > > > features > > > > in > > > > > these PRs. For example customers commented on [1] and [2] > asking > > > for > > > > > these > > > > > features. During a presentation about CEP during Flink Forward > > 2016 > > > > > somebody asked[4] for a feature that is implemented in [1]. > > Another > > > > CEP > > > > > feature that was requested in this Stack Overflow post[5] was > > > > > implemented > > > > > by PR [2]. > > > > > > > > > > I also started conversations regarding following JIRA issues: > > > > > https://urldefense.proofpoint.com/v2/url?u=https-3A__issues. > > > > > apache.org_jira_browse_FLINK-2D4641&d=DgIBaQ&c=eIGjsITfXP_y- > > > > > DLLX0uEHXJvU8nOHrUK8IrwNKOtkVU&r=brkRAgrW3LbdVDOiRLzI7SFUIWBL5a > > > > > a2MIfENljA8xoe0lFg2u3-S6GnFTH7Pbmc&m= > OvPHe08A8IQPc6PIPmNkgZWKDWmAMA > > > > > Ikfcqrek_iJbQ&s=ml7ZfW_GN8zahdrUAEQrRD3KTBbvr6RbPpqTg71Fhao&e= > > > > > https://urldefense.proofpoint.com/v2/url?u=https-3A__issues. > > > > > apache.org_jira_browse_FLINK-2D3414&d=DgIBaQ&c=eIGjsITfXP_y- > > > > > DLLX0uEHXJvU8nOHrUK8IrwNKOtkVU&r=brkRAgrW3LbdVDOiRLzI7SFUIWBL5a > > > > > a2MIfENljA8xoe0lFg2u3-S6GnFTH7Pbmc&m= > OvPHe08A8IQPc6PIPmNkgZWKDWmAMA > > > > > Ikfcqrek_iJbQ&s=uBNY1zlRRLXhvJQlguoBh4qXZVPRtHxmlavRCLD2UGE&e= > > > > > https://urldefense.proofpoint.com/v2/url?u=https-3A__issues. > > > > > apache.org_jira_browse_FLINK-2D3320&d=DgIBaQ&c=eIGjsITfXP_y- > > > > > DLLX0uEHXJvU8nOHrUK8IrwNKOtkVU&r=brkRAgrW3LbdVDOiRLzI7SFUIWBL5a > > > > > a2MIfENljA8xoe0lFg2u3-S6GnFTH7Pbmc&m= > OvPHe08A8IQPc6PIPmNkgZWKDWmAMA > > > > > Ikfcqrek_iJbQ&s=7lPpQ1mPiTRr7qz8mX6GK0Qq9CWWeXcg8Bf3h43uJ08&e= > > (wrote > > > to > > > > > Till about this > > > > > one) > > > > > > > > > > and I would like to work on them, but it seems pointless if > > nobody > > > is > > > > > going > > > > > to review new PRs. > > > > > > > > > > I wrote to Till(who is the only Flink CEP reviewer at the > moment) > > > but > > > > > it > > > > > seems that he is very busy and cannot help with these PRs. On > the > > > > other > > > > > hand Flink CEP has got some attention and customers are asking > > for > > > > new > > > > > features. > > > > > > > > > > Is there any way for community to make progress with Flink CEP? > > > > > Are there other core committers that can review Flink CEP PRs? > > > > > > > > > > Best regards, > > > > > Ivan. > > > > > > > > > > > > > > > > > > > > [1] - > > https://urldefense.proofpoint.com/v2/url?u=https-3A__github. > > > > > com_apache_flink_pull_2361&d=DgIBaQ&c=eIGjsITfXP_y- > > > > > DLLX0uEHXJvU8nOHrUK8IrwNKOtkVU&r=brkRAgrW3LbdVDOiRLzI7SFUIWBL5a > > > > > a2MIfENljA8xoe0lFg2u3-S6GnFTH7Pbmc&m= > OvPHe08A8IQPc6PIPmNkgZWKDWmAMA > > > > > Ikfcqrek_iJbQ&s=dNLjBUb6wz8125hkAlm3tEzxLnZNfzeRrkFPEFJR2qM&e= > > > > > [2] - > > https://urldefense.proofpoint.com/v2/url?u=https-3A__github. > > > > > com_apache_flink_pull_2367&d=DgIBaQ&c=eIGjsITfXP_y- > > > > > DLLX0uEHXJvU8nOHrUK8IrwNKOtkVU&r=brkRAgrW3LbdVDOiRLzI7SFUIWBL5a > > > > > a2MIfENljA8xoe0lFg2u3-S6GnFTH7Pbmc&m= > OvPHe08A8IQPc6PIPmNkgZWKDWmAMA > > > > > Ikfcqrek_iJbQ&s=tpKgiz_VFKYGXCn26GJolxFfSvRwqaMSpOPYFqG3ZYI&e= > > > > > [3] - > > https://urldefense.proofpoint.com/v2/url?u=https-3A__github. > > > > > com_apache_flink_pull_2396&d=DgIBaQ&c=eIGjsITfXP_y- > > > > > DLLX0uEHXJvU8nOHrUK8IrwNKOtkVU&r=brkRAgrW3LbdVDOiRLzI7SFUIWBL5a > > > > > a2MIfENljA8xoe0lFg2u3-S6GnFTH7Pbmc&m= > OvPHe08A8IQPc6PIPmNkgZWKDWmAMA > > > > > Ikfcqrek_iJbQ&s=28ZX8-B728xOrkxZ1DxhnOZfaZOB30fQQxWzJV5lrXY&e= > > > > > [4] - https://urldefense.proofpoint. > com/v2/url?u=https-3A__youtu > > . > > > > > be_vws5bv3XdD8-3Ft-3D35m26s&d=DgIBaQ&c=eIGjsITfXP_y- > > > > > DLLX0uEHXJvU8nOHrUK8IrwNKOtkVU&r=brkRAgrW3LbdVDOiRLzI7SFUIWBL5a > > > > > a2MIfENljA8xoe0lFg2u3-S6GnFTH7Pbmc&m= > OvPHe08A8IQPc6PIPmNkgZWKDWmAMA > > > > > Ikfcqrek_iJbQ&s=NQ0d1W3QqhUU5tMKy7vqbLWPtYbFQ-pOLdsEEsN6ugc&e= > > > > > [5] - > > > > > https://urldefense.proofpoint.com/v2/url?u=http-3A__ > > > > > stackoverflow.com_questions_38225286_ho-2Dcan-2Di-2Ddo- > > > > > 2Da-2Dlazy-2Dmatch-2Dwith-2Dflink-2Dcep&d=DgIBaQ&c=eIGjsITfXP_y- > > > > > DLLX0uEHXJvU8nOHrUK8IrwNKOtkVU&r=brkRAgrW3LbdVDOiRLzI7SFUIWBL5a > > > > > a2MIfENljA8xoe0lFg2u3-S6GnFTH7Pbmc&m= > OvPHe08A8IQPc6PIPmNkgZWKDWmAMA > > > > > Ikfcqrek_iJbQ&s=Q4FXZ_t5rW5UZt-geVcKjq7QNf4TgEluZlGAXxtzXN0&e= > > > > > > > > > > > > > > > > > > > > ________________________________ > > > > > > > > > > This message is for the designated recipient only and may contain > > > > > privileged, proprietary, or otherwise confidential information. If > > you > > > > have > > > > > received it in error, please notify the sender immediately and > delete > > > the > > > > > original. Any other use of the e-mail by you is prohibited. Where > > > allowed > > > > > by local law, electronic communications with Accenture and its > > > > affiliates, > > > > > including e-mail and instant messaging (including content), may be > > > > scanned > > > > > by our systems for the purposes of information security and > > assessment > > > of > > > > > internal compliance with Accenture policy. > > > > > ____________________________________________________________ > > > > > __________________________ > > > > > > > > > > www.accenture.com > > > > > > > > > > > > > > >
