Thanks for the input Fabian! I also think this is a valuable and lightweight addition. I will add specific comments on the PR :)
-Vasia. On 25 April 2016 at 14:30, Fabian Hueske <fhue...@gmail.com> wrote: > Hi Greg, > > sorry for the late reply. > I am not super familiar with Gelly, but the use cases you describe sound > quite common to me. > I had a (very) brief look at the PR and the changes seem to be rather > lightweight. > So, in my opinion this looks like a valuable addition. > > Thanks, Fabian > > > 2016-04-21 18:06 GMT+02:00 Greg Hogan <c...@greghogan.com>: > > > Vasia and I are looking for additional feedback on FLINK-3771. This > ticket > > [0] and PR [1] provides methods for translating the type or value of > graph > > labels, vertex values, and edge values. My use cases are provided in > JIRA, > > but I think users will find many more. > > > > Translators compose well with graph generators and graph algorithms, > which > > are restricted to emitting a wide type. Translators can also be used for > > processing and merging input data. > > > > The equivalent facility on DataSet is simply a MapFunction. Graphs have > > additional structure in having two DataSets, vertices and edges, as well > as > > the label type binding the two. > > > > The PR provides three basic implementations of the Translator interface > as > > well as Translate methods which operate on graphs, vertices, and edges. > > > > Greg > > > > [0] https://issues.apache.org/jira/browse/FLINK-3771 > > [1] https://github.com/apache/flink/pull/1900/files > > >
