+1, the releases are very lightweight if we only add few commits On Thu, 21 Apr 2016 at 10:48 Gyula Fóra <gyula.f...@gmail.com> wrote:
> +1 from me as well :) > > Till Rohrmann <trohrm...@apache.org> ezt írta (időpont: 2016. ápr. 21., > Cs, > 10:34): > > > +1 for Robert's proposal. > > > > On Thu, Apr 21, 2016 at 9:30 AM, Robert Metzger <rmetz...@apache.org> > > wrote: > > > > > Hi, > > > > > > I'm in favor of bringing this RC out as Flink 1.0.2 for the following > > > reasons: > > > - The vote is over today and we have 3 +1 votes > > > - At least one production user (Konstantin) urgently needs a fix > > contained > > > in the RC (It contains more critical fixes from other prod users as > well) > > > - Gyula has a work-around for his issue (Guyla's issue has been around > > > since 1.0.0 I guess, so the 1.0.2 release is not making things worse) > > > > > > Once Gyula's PR is merged, we can immediately create a RC for Flink > 1.0.3 > > > (We can start voting it even before finalizing this one) > > > > > > > > > > > > On Wed, Apr 20, 2016 at 11:14 PM, Ufuk Celebi <u...@apache.org> wrote: > > > > > > > Yeah, sorry, I meant release, not RC. > > > > > > > > On Wed, Apr 20, 2016 at 10:26 PM, Fabian Hueske <fhue...@gmail.com> > > > wrote: > > > > > Ah, OK. Thanks Gyula for clarifying. > > > > > > > > > > Just had a look at the PR. The fix seems to be quite > straightforward. > > > > > If you can validate the fix tomorrow and we include it, we could > > > release > > > > > 1.0.2 early next week. > > > > > > > > > > 2016-04-20 22:11 GMT+02:00 Gyula Fóra <gyula.f...@gmail.com>: > > > > > > > > > >> Fabian, I think Ufuk meant about 2 weeks for the next bugfix > release > > > not > > > > >> RC. > > > > >> > > > > >> I have actually prepared a PR that should fix this problem: > > > > >> https://github.com/apache/flink/pull/1919 regardless of how we > > > decide. > > > > >> I can only test this tomorrow though in the production > environment. > > > > >> > > > > >> I can work around this issue for our use-case by copying the fixed > > > sink > > > > >> code in the application, so for me it could wait 1-2 weeks I am > not > > > > sure if > > > > >> others will run into this until then. > > > > >> > > > > >> Gyula > > > > >> > > > > >> Fabian Hueske <fhue...@gmail.com> ezt írta (időpont: 2016. ápr. > > 20., > > > > Sze, > > > > >> 21:57): > > > > >> > > > > >> > Would it take two weeks to fix FLINK-3790 or is there another > > reason > > > > why > > > > >> > the next RC would be available in 2 weeks? > > > > >> > > > > > >> > We released Flink 1.0.1 14 days ago. > > > > >> > So we might ship another release in 2 weeks no? > > > > >> > > > > > >> > 2016-04-20 21:51 GMT+02:00 Konstantin Knauf < > > > > >> konstantin.kn...@tngtech.com > > > > >> > >: > > > > >> > > > > > >> > > Hi Ufuk, > > > > >> > > > > > > >> > > for our production use-case FLINK-3688 is very important, so > we > > > > would > > > > >> > > appreciate a quick 1.0.2 release. If you guys can take this > into > > > > >> > > consideration, this would be great. > > > > >> > > > > > > >> > > Cheers, > > > > >> > > > > > > >> > > Konstantin > > > > >> > > > > > > >> > > > > > > >> > > On 20.04.2016 20:54, Ufuk Celebi wrote: > > > > >> > > > No problem, Trevor! Thanks for reporting this anyways. And > > > thanks > > > > to > > > > >> > > > Chiwan and Aljoscha for looking into it as well. > > > > >> > > > > > > > >> > > > I had an offline chat with Gyula about the rolling file sink > > > > problem > > > > >> > > > (FLINK-3790) and it looks like this a big issue for their > use > > > case > > > > >> > > > against the production HDFS cluster (HA, default replication > > > > factor, > > > > >> > > > etc.). He also raised a valid point about this being not > easy > > to > > > > >> > > > debug. > > > > >> > > > > > > > >> > > > Realistically, if we postpone this it will take ~ 2 weeks > for > > > > another > > > > >> > > > RC to be published. I'm undecided at the moment... What do > you > > > > think? > > > > >> > > > > > > > >> > > > – Ufuk > > > > >> > > > > > > > >> > > > > > > > >> > > > On Wed, Apr 20, 2016 at 3:48 PM, Trevor Grant < > > > > >> > trevor.d.gr...@gmail.com> > > > > >> > > wrote: > > > > >> > > >> I also confirmed. My bad. > > > > >> > > >> > > > > >> > > >> > > > > >> > > >> Trevor Grant > > > > >> > > >> Data Scientist > > > > >> > > >> https://github.com/rawkintrevo > > > > >> > > >> http://stackexchange.com/users/3002022/rawkintrevo > > > > >> > > >> http://trevorgrant.org > > > > >> > > >> > > > > >> > > >> *"Fortunate is he, who is able to know the causes of > things." > > > > >> > -Virgil* > > > > >> > > >> > > > > >> > > >> > > > > >> > > >> On Wed, Apr 20, 2016 at 8:30 AM, Aljoscha Krettek < > > > > >> > aljos...@apache.org> > > > > >> > > >> wrote: > > > > >> > > >> > > > > >> > > >>> Chiwan is right. I just downloaded the release binary > again > > > and > > > > >> > > verified > > > > >> > > >>> that the problem mentioned in the issue does not occur: > > > > >> > > >>> > > > > >> > > >>> https://issues.apache.org/jira/browse/FLINK-3701 > > > > >> > > >>> > > > > >> > > >>> On Wed, 20 Apr 2016 at 14:51 Chiwan Park < > > > chiwanp...@apache.org > > > > > > > > > >> > > wrote: > > > > >> > > >>> > > > > >> > > >>>> AFAIK, FLINK-3701 is about Flink 1.1-SNAPSHOT, not Flink > > 1.0. > > > > We > > > > >> can > > > > >> > > go > > > > >> > > >>>> forward. > > > > >> > > >>>> > > > > >> > > >>>> Regards, > > > > >> > > >>>> Chiwan Park > > > > >> > > >>>> > > > > >> > > >>>>> On Apr 20, 2016, at 9:33 PM, Trevor Grant < > > > > >> > trevor.d.gr...@gmail.com> > > > > >> > > >>>> wrote: > > > > >> > > >>>>> > > > > >> > > >>>>> -1 > > > > >> > > >>>>> > > > > >> > > >>>>> Not a PMC so my down vote doesn't mean anything but... > > > > >> > > >>>>> > > > > >> > > >>>>> https://github.com/apache/flink/pull/1913 > > > > >> > > >>>>> > > > > >> > > >>>>> https://issues.apache.org/jira/browse/FLINK-3701 > > > > >> > > >>>>> > > > > >> > > >>>>> A busted scala shell is a blocker imho. > > > > >> > > >>>>> > > > > >> > > >>>>> > > > > >> > > >>>>> Trevor Grant > > > > >> > > >>>>> Data Scientist > > > > >> > > >>>>> https://github.com/rawkintrevo > > > > >> > > >>>>> http://stackexchange.com/users/3002022/rawkintrevo > > > > >> > > >>>>> http://trevorgrant.org > > > > >> > > >>>>> > > > > >> > > >>>>> *"Fortunate is he, who is able to know the causes of > > > things." > > > > >> > > -Virgil* > > > > >> > > >>>>> > > > > >> > > >>>>> > > > > >> > > >>>>> On Wed, Apr 20, 2016 at 6:51 AM, Aljoscha Krettek < > > > > >> > > aljos...@apache.org > > > > >> > > >>>> > > > > >> > > >>>>> wrote: > > > > >> > > >>>>> > > > > >> > > >>>>>> +1 > > > > >> > > >>>>>> > > > > >> > > >>>>>> I eyeballed the changes and nothing looks suspicious. > > > > >> > > >>>>>> > > > > >> > > >>>>>> On Wed, 20 Apr 2016 at 13:21 Fabian Hueske < > > > > fhue...@gmail.com> > > > > >> > > wrote: > > > > >> > > >>>>>> > > > > >> > > >>>>>>> Thanks Ufuk for preparing the RC. > > > > >> > > >>>>>>> > > > > >> > > >>>>>>> - Checked the diff against release 1.0.1. No > > dependencies > > > > were > > > > >> > > added > > > > >> > > >>> or > > > > >> > > >>>>>>> modified. > > > > >> > > >>>>>>> - Checked signatures and hashes of all release > > artifacts. > > > > >> > > >>>>>>> > > > > >> > > >>>>>>> +1 to release this RC. > > > > >> > > >>>>>>> > > > > >> > > >>>>>>> Thanks, Fabian > > > > >> > > >>>>>>> > > > > >> > > >>>>>>> 2016-04-19 21:34 GMT+02:00 Robert Metzger < > > > > rmetz...@apache.org > > > > >> >: > > > > >> > > >>>>>>> > > > > >> > > >>>>>>>> Thank you for creating another bugfix release of the > > 1.0 > > > > >> release > > > > >> > > >>> Ufuk! > > > > >> > > >>>>>>>> > > > > >> > > >>>>>>>> +1 for releasing this proposed RC. > > > > >> > > >>>>>>>> > > > > >> > > >>>>>>>> > > > > >> > > >>>>>>>> - Checked some flink-dist jars for correctly shaded > > guava > > > > >> > classes > > > > >> > > >>>>>>>> - Started Flink in local mode and ran some examples > > > > >> > > >>>>>>>> - Checked the staging repository > > > > >> > > >>>>>>>> - Checked the quickstarts for the scala 2.10 and the > > > right > > > > >> > hadoop > > > > >> > > >>>>>>>> profiles. > > > > >> > > >>>>>>>> > > > > >> > > >>>>>>>> > > > > >> > > >>>>>>>> > > > > >> > > >>>>>>>> On Mon, Apr 18, 2016 at 5:29 PM, Ufuk Celebi < > > > > u...@apache.org> > > > > >> > > >>> wrote: > > > > >> > > >>>>>>>> > > > > >> > > >>>>>>>>> Dear Flink community, > > > > >> > > >>>>>>>>> > > > > >> > > >>>>>>>>> Please vote on releasing the following candidate as > > > Apache > > > > >> > Flink > > > > >> > > >>>>>>> version > > > > >> > > >>>>>>>>> 1.0.2. > > > > >> > > >>>>>>>>> > > > > >> > > >>>>>>>>> The commit to be voted on: > > > > >> > > >>>>>>>>> d39af152a166ddafaa2466cdae82695880893f3e > > > > >> > > >>>>>>>>> > > > > >> > > >>>>>>>>> Branch: > > > > >> > > >>>>>>>>> release-1.0.2-rc3 (see > > > > >> > > >>>>>>>>> > > > > >> > > >>>>>>>>> > > > > >> > > >>>>>>>> > > > > >> > > >>>>>>> > > > > >> > > >>>>>> > > > > >> > > >>>> > > > > >> > > >>> > > > > >> > > > > > > >> > > > > > >> > > > > > > > > > > https://git1-us-west.apache.org/repos/asf/flink/?p=flink.git;a=shortlog;h=refs/heads/release-1.0.2-rc3 > > > > >> > > >>>>>>>>> ) > > > > >> > > >>>>>>>>> > > > > >> > > >>>>>>>>> The release artifacts to be voted on can be found > at: > > > > >> > > >>>>>>>>> http://home.apache.org/~uce/flink-1.0.2-rc3/ > > > > >> > > >>>>>>>>> > > > > >> > > >>>>>>>>> The release artifacts are signed with the key with > > > > >> fingerprint > > > > >> > > >>>>>>> 9D403309: > > > > >> > > >>>>>>>>> http://www.apache.org/dist/flink/KEYS > > > > >> > > >>>>>>>>> > > > > >> > > >>>>>>>>> The staging repository for this release can be found > > at: > > > > >> > > >>>>>>>>> > > > > >> > > >>>>>> > > > > >> > > >>> > > > > >> > > > > > > https://repository.apache.org/content/repositories/orgapacheflink-1092 > > > > >> > > >>>>>>>>> > > > > >> > > >>>>>>>>> > > > > ------------------------------------------------------------- > > > > >> > > >>>>>>>>> > > > > >> > > >>>>>>>>> The vote is open for the next 72 hours and passes > if a > > > > >> majority > > > > >> > > of > > > > >> > > >>> at > > > > >> > > >>>>>>>> least > > > > >> > > >>>>>>>>> three +1 PMC votes are cast. > > > > >> > > >>>>>>>>> > > > > >> > > >>>>>>>>> The vote ends on Thursday April 21, 2016. > > > > >> > > >>>>>>>>> > > > > >> > > >>>>>>>>> [ ] +1 Release this package as Apache Flink 1.0.2 > > > > >> > > >>>>>>>>> [ ] -1 Do not release this package because ... > > > > >> > > >>>>>>>>> > > > > >> > > >>>>>>>>> =================================== > > > > >> > > >>>>>>>>> > > > > >> > > >>>>>>>>> The following commits have been added since the > 1.0.1 > > > > release > > > > >> > > >>>>>>> (excluding > > > > >> > > >>>>>>>>> docs), > > > > >> > > >>>>>>>>> most notably a performance optimization for the > > RocksDB > > > > state > > > > >> > > >>> backend > > > > >> > > >>>>>>> and > > > > >> > > >>>>>>>>> a fix > > > > >> > > >>>>>>>>> for proper passing of dynamic YARN properties to the > > > > Client. > > > > >> > > >>>>>>>>> > > > > >> > > >>>>>>>>> * 5987eb6 - [FLINK-3657] [dataSet] Change access of > > > > >> > > >>>>>>>>> DataSetUtils.countElements() to 'public' (5 hours > ago) > > > > >> > <smarthi> > > > > >> > > >>>>>>>>> * b4b08ca - [FLINK-3762] [core] Enable Kryo > reference > > > > >> tracking > > > > >> > (3 > > > > >> > > >>>>>> days > > > > >> > > >>>>>>>>> ago) <Andrew Palumbo> > > > > >> > > >>>>>>>>> * 5b69dd8 - [FLINK-3732] [core] Fix potential null > > > > deference > > > > >> in > > > > >> > > >>>>>>>>> ExecutionConfig#equals() (3 days ago) <Tianji Li> > > > > >> > > >>>>>>>>> * aadc5fa - [FLINK-3760] Fix > > StateDescriptor.readObject > > > > (19 > > > > >> > hours > > > > >> > > >>>>>> ago) > > > > >> > > >>>>>>>>> <Aljoscha Krettek> > > > > >> > > >>>>>>>>> * ea50ed3 - [FLINK-3716] [kafka consumer] Decreasing > > > > socket > > > > >> > > timeout > > > > >> > > >>>>>> so > > > > >> > > >>>>>>>>> testFailOnNoBroker() will pass before JUnit timeout > > (29 > > > > hours > > > > >> > > ago) > > > > >> > > >>>>>>>>> <Todd Lisonbee> > > > > >> > > >>>>>>>>> * ff38202 - [FLINK-3730] Fix RocksDB Local Directory > > > > >> > > Initialization > > > > >> > > >>>>>>>>> (29 hours ago) <Aljoscha Krettek> > > > > >> > > >>>>>>>>> * 4f9c198 - [FLINK-3712] Make all dynamic properties > > > > >> available > > > > >> > to > > > > >> > > >>> the > > > > >> > > >>>>>>>>> CLI frontend (3 days ago) <Robert Metzger> > > > > >> > > >>>>>>>>> * 1554c9b - [FLINK-3688] WindowOperator.trigger() > does > > > not > > > > >> emit > > > > >> > > >>>>>>>>> Watermark anymore (6 days ago) <Konstantin Knauf> > > > > >> > > >>>>>>>>> * 43093e3 - [FLINK-3697] Properly access type > > > information > > > > for > > > > >> > > >>> nested > > > > >> > > >>>>>>>>> POJO key selection (6 days ago) <Robert Metzger> > > > > >> > > >>>>>>>>> * 17909aa - [FLINK-3654] Disable Write-Ahead-Log in > > > > RocksDB > > > > >> > State > > > > >> > > >>> (7 > > > > >> > > >>>>>>>>> days ago) <Aljoscha Krettek> > > > > >> > > >>>>>>>>> * e0dc5c1 - [FLINK-3595] [runtime] Eagerly destroy > > > buffer > > > > >> pools > > > > >> > > on > > > > >> > > >>>>>>>>> cancelling (10 days ago) <Ufuk Celebi> > > > > >> > > >>>>>>>>> > > > > >> > > >>>>>>>> > > > > >> > > >>>>>>> > > > > >> > > >>>>>> > > > > >> > > >>>> > > > > >> > > >>>> > > > > >> > > >>> > > > > >> > > > > > > > >> > > > > > > >> > > -- > > > > >> > > Konstantin Knauf * konstantin.kn...@tngtech.com * > > +49-174-3413182 > > > > >> > > TNG Technology Consulting GmbH, Betastr. 13a, 85774 > Unterföhring > > > > >> > > Geschäftsführer: Henrik Klagges, Christoph Stock, Dr. Robert > > > Dahlke > > > > >> > > Sitz: Unterföhring * Amtsgericht München * HRB 135082 > > > > >> > > > > > > >> > > > > > >> > > > > > > > > > >
