This vote is cancelled in favor of a new RC. On Fri, Oct 30, 2015 at 9:03 AM, Maximilian Michels <m...@apache.org> wrote:
> Thanks for reporting and providing a fix, Till! We have also fixed two > issues with the new job manager web frontend and pushed them to the > release-0.10 branch. Please review these changes in the new release > candidate. > > On Wed, Oct 28, 2015 at 6:55 PM, Till Rohrmann <trohrm...@apache.org> > wrote: > >> -1 from my side. I just found a serious issue with the KryoSerializer >> (FLINK-2800) which in some cases produced duplicated elements or corrupted >> data. I opened a PR to fix the issue ( >> https://github.com/apache/flink/pull/1308). >> >> Cheers, >> Till >> >> >> On Wed, Oct 28, 2015 at 5:38 PM, Maximilian Michels <m...@apache.org> >> wrote: >> >> > Not sure. I think I'd rather leave it as it is because it renders the >> > normal view (when your screen is wide enough unreadable). I'd rather >> > wait for a proper fix. >> > >> > Now >> > >> > >> https://drive.google.com/file/d/0BziY9U_qva1sYzdxR3RJakltM0E/view?usp=sharing >> > Afterwards >> > >> > >> https://drive.google.com/file/d/0BziY9U_qva1sSmg1ZVJ6NmlVSGs/view?usp=sharing >> > >> > On Wed, Oct 28, 2015 at 5:28 PM, Sachin Goel <sachingoel0...@gmail.com> >> > wrote: >> > > Yes. I just made it work in firefox. It was already working in Chrome >> > this >> > > way. >> > > Maybe Piotr will have a better fix later on. >> > > >> > > -- Sachin Goel >> > > Computer Science, IIT Delhi >> > > m. +91-9871457685 >> > > >> > > On Wed, Oct 28, 2015 at 9:42 PM, Maximilian Michels <m...@apache.org> >> > wrote: >> > > >> > >> @Sachin: I've tried it out. It has the tendency to make things a bit >> > >> harder to read (because it breaks words at arbitrary positions). >> > >> However, we don't have a better fix. >> > >> >> > >> On Wed, Oct 28, 2015 at 4:46 PM, Sachin Goel < >> sachingoel0...@gmail.com> >> > >> wrote: >> > >> > Sorry. Wrong commit. In case you've pulled already. >> > >> > >> > >> > -- Sachin Goel >> > >> > Computer Science, IIT Delhi >> > >> > m. +91-9871457685 >> > >> > >> > >> > On Wed, Oct 28, 2015 at 9:09 PM, Sachin Goel < >> > sachingoel0...@gmail.com> >> > >> > wrote: >> > >> > >> > >> >> @Max: Here's a fix for the wrapping issue: >> > >> >> https://github.com/sachingoel0101/flink/tree/long-vertex-name. >> It's >> > >> just >> > >> >> two lines, so I don't think opening a PR makes sense. Lemme know >> if I >> > >> >> should. >> > >> >> >> > >> >> @Vasia: Can you test it out on your job? I've checked on firefox, >> > chrome >> > >> >> and IE and it seems to work. [You might wanna rebuild >> > flink-runtime-web >> > >> >> followed by flink-dist first. :)] >> > >> >> >> > >> >> >> > >> >> >> > >> >> -- Sachin Goel >> > >> >> Computer Science, IIT Delhi >> > >> >> m. +91-9871457685 >> > >> >> >> > >> >> On Wed, Oct 28, 2015 at 8:22 PM, Vasiliki Kalavri < >> > >> >> vasilikikala...@gmail.com> wrote: >> > >> >> >> > >> >>> Ah I see. Thanks Sachin, Max. I think a label would be nice >> there, >> > yes. >> > >> >>> >> > >> >>> On 28 October 2015 at 15:45, Maximilian Michels <m...@apache.org> >> > >> wrote: >> > >> >>> >> > >> >>> > Yes, that's correct. One is running operators (top of the job >> > view) >> > >> >>> > while the other lists all the parallel tasks (overview page, >> and >> > >> >>> > detail view in job view). I think it makes sense where they are >> > >> >>> > displayed at the moment. It's just confusing how they are >> > displayed. >> > >> >>> > Could we add a label at the top of the job view to denote that >> > these >> > >> >>> > are operator-level numbers? >> > >> >>> > >> > >> >>> > On Wed, Oct 28, 2015 at 3:24 PM, Sachin Goel < >> > >> sachingoel0...@gmail.com> >> > >> >>> > wrote: >> > >> >>> > > I think the squares on top of the job page are showing the >> > status >> > >> of >> > >> >>> > > vertices, not tasks. The squares on overview pages however >> show >> > the >> > >> >>> > number >> > >> >>> > > of tasks. Should we make it vertices or tasks everywhere, for >> > >> >>> > consistency? >> > >> >>> > > >> > >> >>> > > -- Sachin Goel >> > >> >>> > > Computer Science, IIT Delhi >> > >> >>> > > m. +91-9871457685 >> > >> >>> > > >> > >> >>> > > On Wed, Oct 28, 2015 at 7:39 PM, Sachin Goel < >> > >> >>> sachingoel0...@gmail.com> >> > >> >>> > > wrote: >> > >> >>> > > >> > >> >>> > >> @Max, I will try to get the wrap working [rather >> ellipsifying >> > the >> > >> >>> text >> > >> >>> > in >> > >> >>> > >> this case.]. Not very good with CSS unfortunately. >> > >> >>> > >> >> > >> >>> > >> @Vasia, there seems to be different things which are being >> > used to >> > >> >>> > render >> > >> >>> > >> those two. For the running jobs page, job.tasks is rendered, >> > while >> > >> >>> for >> > >> >>> > the >> > >> >>> > >> job page, job.status-counts is being used. Looking into it >> now. >> > >> >>> > >> >> > >> >>> > >> -- Sachin Goel >> > >> >>> > >> Computer Science, IIT Delhi >> > >> >>> > >> m. +91-9871457685 >> > >> >>> > >> >> > >> >>> > >> On Wed, Oct 28, 2015 at 7:26 PM, Vasiliki Kalavri < >> > >> >>> > >> vasilikikala...@gmail.com> wrote: >> > >> >>> > >> >> > >> >>> > >>> The numbers I see in the overview are different. >> > >> >>> > >>> >> > >> >>> > >>> See >> > >> >>> > >>> >> > >> >>> > >>> >> > >> >>> > >> > >> >>> >> > >> >> > >> https://drive.google.com/file/d/0BzQJrI2eGlyYMHZZUGs2ZFJzaXc/view?usp=sharing >> > >> >>> > >>> vs. >> > >> >>> > >>> >> > >> >>> > >>> >> > >> >>> > >> > >> >>> >> > >> >> > >> https://drive.google.com/file/d/0BzQJrI2eGlyYc3kzMlQ4OXN6a3c/view?usp=sharing >> > >> >>> > >>> >> > >> >>> > >>> -Vasia. >> > >> >>> > >>> >> > >> >>> > >>> On 28 October 2015 at 14:51, Maximilian Michels < >> > m...@apache.org> >> > >> >>> > wrote: >> > >> >>> > >>> >> > >> >>> > >>> > @Vasia: This is a CSS problem which manifests because of >> a >> > long >> > >> >>> class >> > >> >>> > >>> > name. The colored boxes show the status of tasks from >> your >> > job >> > >> >>> which >> > >> >>> > >>> > you are viewing. Are the number not correct? >> > >> >>> > >>> > >> > >> >>> > >>> > @Sachin: Could you fix the wrapping of the column? >> > >> >>> > >>> > >> > >> >>> > >>> > On Wed, Oct 28, 2015 at 2:44 PM, Sachin Goel < >> > >> >>> > sachingoel0...@gmail.com> >> > >> >>> > >>> > wrote: >> > >> >>> > >>> > > The name of the vertex is very long and isn't getting >> > wrapped >> > >> >>> > around >> > >> >>> > >>> to >> > >> >>> > >>> > > accommodate all the columns. There's a TODO at the >> > relevant >> > >> >>> place >> > >> >>> > in >> > >> >>> > >>> > > app/scripts/common/filters.coffee which was probably >> > meant to >> > >> >>> > handle >> > >> >>> > >>> > this. >> > >> >>> > >>> > > >> > >> >>> > >>> > > >> > >> >>> > >>> > > -- Sachin Goel >> > >> >>> > >>> > > Computer Science, IIT Delhi >> > >> >>> > >>> > > m. +91-9871457685 >> > >> >>> > >>> > > >> > >> >>> > >>> > > On Wed, Oct 28, 2015 at 7:04 PM, Vasiliki Kalavri < >> > >> >>> > >>> > vasilikikala...@gmail.com >> > >> >>> > >>> > >> wrote: >> > >> >>> > >>> > > >> > >> >>> > >>> > >> It's Firefox 41.0.2. Resizing doesn't work :/ >> > >> >>> > >>> > >> See this screenshot for the colored boxes I'm >> referring >> > to: >> > >> >>> > >>> > >> >> > >> >>> > >>> > >> >> > >> >>> > >>> > >> > >> >>> > >>> >> > >> >>> > >> > >> >>> >> > >> >> > >> https://drive.google.com/file/d/0BzQJrI2eGlyYX1VYQTlrQWNfUkE/view?usp=sharing >> > >> >>> > >>> > >> . >> > >> >>> > >>> > >> Shouldn't these numbers show tasks? >> > >> >>> > >>> > >> >> > >> >>> > >>> > >> On 28 October 2015 at 14:26, Maximilian Michels < >> > >> >>> m...@apache.org> >> > >> >>> > >>> wrote: >> > >> >>> > >>> > >> >> > >> >>> > >>> > >> > @Vasia: >> > >> >>> > >>> > >> > >> > >> >>> > >>> > >> > - There are two types of shapes which are colored :) >> > The >> > >> >>> circles >> > >> >>> > >>> mark >> > >> >>> > >>> > >> > the running/finished/cancelled/failed jobs while the >> > >> squares >> > >> >>> > mark >> > >> >>> > >>> the >> > >> >>> > >>> > >> > status of a task within a job >> > >> >>> > >>> > >> > >> > (cancelled/running/failed/restart/pending/finished/total). >> > >> >>> > >>> > >> > >> > >> >>> > >>> > >> > - I can see all four columns in the "Plan" tab on >> > Firefox. >> > >> >>> Which >> > >> >>> > >>> > >> > version are you using? Does resizing the window make >> > any >> > >> >>> > >>> difference? >> > >> >>> > >>> > >> > >> > >> >>> > >>> > >> > @Sachin: Thanks for your pull requests. Will pull >> them >> > in >> > >> for >> > >> >>> > the >> > >> >>> > >>> next >> > >> >>> > >>> > >> RC. >> > >> >>> > >>> > >> > >> > >> >>> > >>> > >> > On Wed, Oct 28, 2015 at 2:03 PM, Vasiliki Kalavri >> > >> >>> > >>> > >> > <vasilikikala...@gmail.com> wrote: >> > >> >>> > >>> > >> > > I think I found 2 more issues with the web >> interface. >> > >> >>> > >>> > >> > > >> > >> >>> > >>> > >> > > When inside a running job's view: >> > >> >>> > >>> > >> > > - I think the colorful boxes with the number of >> > tasks in >> > >> >>> each >> > >> >>> > >>> status >> > >> >>> > >>> > >> show >> > >> >>> > >>> > >> > > wrong values (or show something else?). I get >> > different >> > >> >>> values >> > >> >>> > >>> than >> > >> >>> > >>> > the >> > >> >>> > >>> > >> > > ones I see in "Overview" and "Running Jobs" tabs. >> > >> >>> > >>> > >> > > - In the "Plan" tab, it seems that some >> information >> > is >> > >> >>> hidden >> > >> >>> > >>> and I >> > >> >>> > >>> > >> > cannot >> > >> >>> > >>> > >> > > scroll right to see it. I can only see 3 columns >> for >> > >> each >> > >> >>> > >>> operator: >> > >> >>> > >>> > >> bytes >> > >> >>> > >>> > >> > > read, records read and bytes written. I'm using >> > Firefox. >> > >> >>> > >>> > >> > > >> > >> >>> > >>> > >> > > -Vasia. >> > >> >>> > >>> > >> > > >> > >> >>> > >>> > >> > > On 28 October 2015 at 13:13, Sachin Goel < >> > >> >>> > >>> sachingoel0...@gmail.com> >> > >> >>> > >>> > >> > wrote: >> > >> >>> > >>> > >> > > >> > >> >>> > >>> > >> > >> While we're at it, we should also remove the >> dummy >> > log >> > >> and >> > >> >>> > >>> stdout >> > >> >>> > >>> > tabs >> > >> >>> > >>> > >> > for >> > >> >>> > >>> > >> > >> task managers. The work on that hasn't been >> finished >> > >> yet. >> > >> >>> > >>> > >> > >> I'll file a jira for both. >> > >> >>> > >>> > >> > >> On Oct 28, 2015 5:39 PM, "Vasiliki Kalavri" < >> > >> >>> > >>> > >> vasilikikala...@gmail.com> >> > >> >>> > >>> > >> > >> wrote: >> > >> >>> > >>> > >> > >> >> > >> >>> > >>> > >> > >> > I see, thank you! +1 for removing before the >> > release >> > >> :) >> > >> >>> > >>> > >> > >> > >> > >> >>> > >>> > >> > >> > On 28 October 2015 at 13:06, Sachin Goel < >> > >> >>> > >>> > sachingoel0...@gmail.com> >> > >> >>> > >>> > >> > >> wrote: >> > >> >>> > >>> > >> > >> > >> > >> >>> > >>> > >> > >> > > Those are hard coded values. >> > >> >>> > >>> > >> > >> > > What exactly should be there, I'm not sure >> > either. >> > >> >>> > >>> > >> > >> > > On Oct 28, 2015 5:25 PM, "Vasiliki Kalavri" < >> > >> >>> > >>> > >> > vasilikikala...@gmail.com >> > >> >>> > >>> > >> > >> > >> > >> >>> > >>> > >> > >> > > wrote: >> > >> >>> > >>> > >> > >> > > >> > >> >>> > >>> > >> > >> > > > I have a question regarding the web >> interface >> > :) >> > >> >>> > >>> > >> > >> > > > What is the "Job Accumulator/Statistics" >> tab >> > >> >>> supposed >> > >> >>> > to >> > >> >>> > >>> > show? >> > >> >>> > >>> > >> No >> > >> >>> > >>> > >> > >> > matter >> > >> >>> > >>> > >> > >> > > > what job I run, the values are the same >> > >> (operator=1, >> > >> >>> > >>> > >> > parallelism=2, >> > >> >>> > >>> > >> > >> > > > subtasks=3). Are these hard-coded defaults? >> > >> >>> > >>> > >> > >> > > > >> > >> >>> > >>> > >> > >> > > > Thanks! >> > >> >>> > >>> > >> > >> > > > -Vasia. >> > >> >>> > >>> > >> > >> > > > >> > >> >>> > >>> > >> > >> > > > On 28 October 2015 at 10:50, Maximilian >> > Michels < >> > >> >>> > >>> > m...@apache.org >> > >> >>> > >>> > >> > >> > >> >>> > >>> > >> > >> > wrote: >> > >> >>> > >>> > >> > >> > > > >> > >> >>> > >>> > >> > >> > > > > Thanks for testing, Vasia :) >> > >> >>> > >>> > >> > >> > > > > >> > >> >>> > >>> > >> > >> > > > > Here is the new document: >> > >> >>> > >>> > >> > >> > > > > >> > >> >>> > >>> > >> > >> > > > > >> > >> >>> > >>> > >> > >> > > > >> > >> >>> > >>> > >> > >> > > >> > >> >>> > >>> > >> > >> > >> > >> >>> > >>> > >> > >> >> > >> >>> > >>> > >> > >> > >> >>> > >>> > >> >> > >> >>> > >>> > >> > >> >>> > >>> >> > >> >>> > >> > >> >>> >> > >> >> > >> https://docs.google.com/document/d/1CR3DH4tUJvukxGFQ1ySxfnzO00LjPhSTwkeE7Mf98CY/edit >> > >> >>> > >>> > >> > >> > > > > >> > >> >>> > >>> > >> > >> > > > > I've transferred results which are >> > unaffected >> > >> by >> > >> >>> the >> > >> >>> > >>> > changes >> > >> >>> > >>> > >> of >> > >> >>> > >>> > >> > the >> > >> >>> > >>> > >> > >> > new >> > >> >>> > >>> > >> > >> > > > RC. >> > >> >>> > >>> > >> > >> > > > > >> > >> >>> > >>> > >> > >> > > > > On Wed, Oct 28, 2015 at 10:33 AM, >> Vasiliki >> > >> >>> Kalavri < >> > >> >>> > >>> > >> > >> > > > > vasilikikala...@gmail.com> wrote: >> > >> >>> > >>> > >> > >> > > > > >> > >> >>> > >>> > >> > >> > > > > > Is there a new testing doc for rc2 or >> are >> > we >> > >> >>> using >> > >> >>> > the >> > >> >>> > >>> > >> > previous >> > >> >>> > >>> > >> > >> > one? >> > >> >>> > >>> > >> > >> > > > > > Thanks! >> > >> >>> > >>> > >> > >> > > > > > >> > >> >>> > >>> > >> > >> > > > > > On 27 October 2015 at 22:17, Maximilian >> > >> Michels >> > >> >>> < >> > >> >>> > >>> > >> > m...@apache.org> >> > >> >>> > >>> > >> > >> > > > wrote: >> > >> >>> > >>> > >> > >> > > > > > >> > >> >>> > >>> > >> > >> > > > > > > Please vote on releasing the >> following >> > >> >>> candidate >> > >> >>> > as >> > >> >>> > >>> > Apache >> > >> >>> > >>> > >> > >> Flink >> > >> >>> > >>> > >> > >> > > > > version >> > >> >>> > >>> > >> > >> > > > > > > 0.10.0: >> > >> >>> > >>> > >> > >> > > > > > > >> > >> >>> > >>> > >> > >> > > > > > > The commit to be voted on: >> > >> >>> > >>> > >> > >> > > > > > > >> ed75049dfc9748eae81ace9d4d686907dcd7835c >> > >> >>> > >>> > >> > >> > > > > > > >> > >> >>> > >>> > >> > >> > > > > > > Branch: >> > >> >>> > >>> > >> > >> > > > > > > release-0.10.0-rc2 (see >> > >> >>> > >>> > >> > >> > > > > > > >> > >> >>> > >>> > >> > >> > >> https://git1-us-west.apache.org/repos/asf/flink/?p=flink.git >> > >> >>> ) >> > >> >>> > >>> > >> > >> > > > > > > >> > >> >>> > >>> > >> > >> > > > > > > The release artifacts to be voted on >> > can be >> > >> >>> found >> > >> >>> > >>> at: >> > >> >>> > >>> > >> > >> > > > > > > >> > >> >>> http://people.apache.org/~mxm/flink-0.10.0-rc2/ >> > >> >>> > >>> > >> > >> > > > > > > >> > >> >>> > >>> > >> > >> > > > > > > The release artifacts are signed with >> > the >> > >> key >> > >> >>> > with >> > >> >>> > >>> > >> > fingerprint >> > >> >>> > >>> > >> > >> > > > > C2909CBF: >> > >> >>> > >>> > >> > >> > > > > > > >> http://www.apache.org/dist/flink/KEYS >> > >> >>> > >>> > >> > >> > > > > > > >> > >> >>> > >>> > >> > >> > > > > > > The staging repository for this >> release >> > >> can be >> > >> >>> > found >> > >> >>> > >>> > at: >> > >> >>> > >>> > >> > >> > > > > > > >> > >> >>> > >>> > >> > >> > > > >> > >> >>> > >>> > >> > >> >> > >> >>> > >>> > >> >> > >> >>> > >>> >> > >> >>> >> > https://repository.apache.org/content/repositories/orgapacheflink-1049 >> > >> >>> > >>> > >> > >> > > > > > > >> > >> >>> > >>> > >> > >> > > > > > > >> > >> >>> > >>> > >> > >> > >> ------------------------------------------------------------- >> > >> >>> > >>> > >> > >> > > > > > > >> > >> >>> > >>> > >> > >> > > > > > > The vote is open for the next 72 >> hours >> > and >> > >> >>> passes >> > >> >>> > >>> if a >> > >> >>> > >>> > >> > majority >> > >> >>> > >>> > >> > >> > of >> > >> >>> > >>> > >> > >> > > at >> > >> >>> > >>> > >> > >> > > > > > least >> > >> >>> > >>> > >> > >> > > > > > > three +1 PMC votes are cast. >> > >> >>> > >>> > >> > >> > > > > > > >> > >> >>> > >>> > >> > >> > > > > > > The vote ends on Thursday Friday 30, >> > 2015. >> > >> >>> > >>> > >> > >> > > > > > > >> > >> >>> > >>> > >> > >> > > > > > > [ ] +1 Release this package as Apache >> > Flink >> > >> >>> > 0.10.0 >> > >> >>> > >>> > >> > >> > > > > > > [ ] -1 Do not release this package >> > because >> > >> ... >> > >> >>> > >>> > >> > >> > > > > > > >> > >> >>> > >>> > >> > >> > > > > > > =================================== >> > >> >>> > >>> > >> > >> > > > > > > >> > >> >>> > >>> > >> > >> > > > > > > The following commits have been >> added on >> > >> top >> > >> >>> of >> > >> >>> > >>> > >> > >> > release-0.10.0-rc1: >> > >> >>> > >>> > >> > >> > > > > > > >> > >> >>> > >>> > >> > >> > > > > > > ae19d2b [FLINK-2927] [runtime] >> Provide >> > >> default >> > >> >>> > >>> required >> > >> >>> > >>> > >> > >> > > configuration >> > >> >>> > >>> > >> > >> > > > > > keys >> > >> >>> > >>> > >> > >> > > > > > > in flink-conf of binary distribution >> > >> >>> > >>> > >> > >> > > > > > > 874c500 Add >> > >> >>> org.apache.httpcomponents:(httpcore, >> > >> >>> > >>> > >> > httpclient) to >> > >> >>> > >>> > >> > >> > > > > > dependency >> > >> >>> > >>> > >> > >> > > > > > > management >> > >> >>> > >>> > >> > >> > > > > > > 04e25e1 [docs] remove hard-coded >> version >> > >> >>> > artifacts >> > >> >>> > >>> > >> > >> > > > > > > b240a80 [FLINK-2878] [webmonitor] Fix >> > >> >>> unexpected >> > >> >>> > >>> leader >> > >> >>> > >>> > >> > address >> > >> >>> > >>> > >> > >> > > > pattern >> > >> >>> > >>> > >> > >> > > > > > > 16a9edc [hotfix] Fix issue with >> spaces >> > in >> > >> >>> Path in >> > >> >>> > >>> > >> > >> > > > start-*-streaming.sh >> > >> >>> > >>> > >> > >> > > > > > > >> > >> >>> > >>> > >> > >> > > > > > >> > >> >>> > >>> > >> > >> > > > > >> > >> >>> > >>> > >> > >> > > > >> > >> >>> > >>> > >> > >> > > >> > >> >>> > >>> > >> > >> > >> > >> >>> > >>> > >> > >> >> > >> >>> > >>> > >> > >> > >> >>> > >>> > >> >> > >> >>> > >>> > >> > >> >>> > >>> >> > >> >>> > >> >> > >> >>> > >> >> > >> >>> > >> > >> >>> >> > >> >> >> > >> >> >> > >> >> > >> > >
