Do we need a Jira for the WebClient fix? Or can I just commit it?

If anybody whats to review, please find it here:
https://github.com/mjsax/flink/tree/hotfixWebClient

I can also open a PR if required.


-Matthias


On 09/25/2015 11:15 AM, Fabian Hueske wrote:
> RC1 has a few issues that need to be resolved before we can continue with
> the release.
> 
> - .git folder contained in source release
> - start/stop script fail in paths with spaces (FLINK-2756)
> - several test fail when building on Windows (FLINK-2757, FLINK-2758,
> FLINK-2759)
> - webclient upload bug (Fix is already available, thx Matthias!)
> 
> Ufuk proposed to fork of the next RC from the current master which has
> evolved quite a bit from the current release branch. If nobody objects,
> I'll do that.
> Would be good to have a few helping hands to fix the above issues.
> 
> Cheers, Fabian
> 
> 2015-09-25 11:08 GMT+02:00 Fabian Hueske <fhue...@gmail.com>:
> 
>> We need a new RC anyways.
>>
>> I am OK with building the next RC on the current master.
>> What do others think?
>>
>> I'll cancel the VOTE thread in the meantime.
>>
>> 2015-09-25 10:47 GMT+02:00 Ufuk Celebi <u...@apache.org>:
>>
>>> Hey Fabian,
>>>
>>> nice to see you taking care of this.
>>>
>>> I was wondering whether it makes sense to let the milestone branch catch
>>> up with the current master as it contains many small fixes by now.
>>>
>>> You will have a better understanding of this. But as far as I can tell
>>> the only big recent change we wanted to keep out of the milestone was the
>>> leader  election code. The standalone (essentially deactivated) case is
>>> stable and it should be OK to include that as well.
>>>
>>> What’s your opinion on this?
>>>
>>> – Ufuk
>>>
>>>> On 24 Sep 2015, at 12:39, Fabian Hueske <fhue...@gmail.com> wrote:
>>>>
>>>> I found more issues with the release:
>>>>
>>>> - start/stop scripts do not work if the path contains spaces
>>> (FLINK-2756)
>>>> - several tests fail when building Flink in Cygwin on Windows
>>> (FLINK-2757,
>>>> FLINK-2758, FLINK-2759)
>>>>
>>>> The following checks passed:
>>>> - Building Flink without tests in Cygwin on Windows
>>>> - Starting and stopping a local Flink instance from Windows CMD with
>>>> ./bin/start-local.bat
>>>> - Executing all example programs with their build-in data from Windows
>>> CMD
>>>> using ./bin/flink.bat
>>>>
>>>> 2015-09-23 17:32 GMT+02:00 Robert Metzger <rmetz...@apache.org>:
>>>>
>>>>> I found another issue: The source release contains the ".git"
>>> directory.
>>>>>
>>>>> On Wed, Sep 23, 2015 at 5:27 PM, Fabian Hueske <fhue...@gmail.com>
>>> wrote:
>>>>>
>>>>>> I agree with continued testing before creating a new RC.
>>>>>>
>>>>>> I build Flink from the source distribution:
>>>>>>
>>>>>> - mvn clean install : works!
>>>>>> - mvn clean install -Dscala-2.11 : works!
>>>>>> - mvn clean install -Dhadoop.version=2.7.0 : fails (FLINK-2651)
>>>>>> - mvn clean install -Dhadoop.version=2.6.0 : fails (FLINK-2750)
>>>>>> - mvn clean install -Dhadoop.version=2.6.0 (on Google Compute Cloud
>>>>>> machine) : fails (FLINK-2749)
>>>>>>
>>>>>> 2015-09-23 16:29 GMT+02:00 Robert Metzger <rmetz...@apache.org>:
>>>>>>
>>>>>>> Thank you for immediately providing a fix.
>>>>>>>
>>>>>>> I would suggest to do some more testing to reduce the number of RCs
>>> we
>>>>>> need
>>>>>>> to create
>>>>>>>
>>>>>>> On Wed, Sep 23, 2015 at 4:26 PM, Matthias J. Sax <mj...@apache.org>
>>>>>> wrote:
>>>>>>>
>>>>>>>> I had a closer look, found the bug, and have a fix ready.
>>>>>>>>
>>>>>>>> https://github.com/mjsax/flink/tree/hotfixWebClient
>>>>>>>>
>>>>>>>> The bug was introduced by FLINK-2175. It seems, something went wrong
>>>>>>>> when I tested this back than. :/
>>>>>>>>
>>>>>>>> -Matthias
>>>>>>>>
>>>>>>>>
>>>>>>>> On 09/23/2015 02:27 PM, Matthias J. Sax wrote:
>>>>>>>>> Hi,
>>>>>>>>>
>>>>>>>>> I just encountered a problem in the WebClient. If I upload multiple
>>>>>>>>> jars, only the first jar that is uploaded is shown. Can anybody
>>>>>> verify
>>>>>>>>> my observation?
>>>>>>>>>
>>>>>>>>> -Matthias
>>>>>>>>>
>>>>>>>>> On 09/23/2015 10:54 AM, Fabian Hueske wrote:
>>>>>>>>>> Dear community,
>>>>>>>>>>
>>>>>>>>>> Please vote on releasing the following candidate as Apache Flink
>>>>>>> version
>>>>>>>>>> 0.10.0-milestone-1. This is a milestone release that contains
>>>>>> several
>>>>>>>>>> features of Flink's next major release version 0.10.0.
>>>>>>>>>>
>>>>>>>>>> This is the first RC for this release.
>>>>>>>>>>
>>>>>>>>>> -------------------------------------------------------------
>>>>>>>>>> The commit to be voted on:
>>>>>>>>>> ffdd484ce5596149bb4ea234561c7fcf83bc3167
>>>>>>>>>>
>>>>>>>>>> Branch:
>>>>>>>>>> release-0.10.0-milestone-1-rc1 (
>>>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>
>>>>>
>>> https://git-wip-us.apache.org/repos/asf?p=flink.git;a=shortlog;h=refs/heads/release-0.10.0-milestone-1-rc1
>>>>>>>>>> )
>>>>>>>>>>
>>>>>>>>>> The release artifacts to be voted on can be found at:
>>>>>>>>>> http://people.apache.org/~fhueske/flink-0.10.0-milestone-1-rc1/
>>>>>>>>>>
>>>>>>>>>> Release artifacts are signed with the key with fingerprint
>>>>> 34911D5A:
>>>>>>>>>> http://www.apache.org/dist/flink/KEYS
>>>>>>>>>>
>>>>>>>>>> The staging repository for this release can be found at:
>>>>>>>>>>
>>>>>>>
>>> https://repository.apache.org/content/repositories/orgapacheflink-1046
>>>>>>>>>> -------------------------------------------------------------
>>>>>>>>>>
>>>>>>>>>> Please vote on releasing this package as Apache Flink
>>>>>>>> 0.10.0-milestone-1.
>>>>>>>>>>
>>>>>>>>>> The vote is open for the next 72 hours and passes if a majority of
>>>>>> at
>>>>>>>> least
>>>>>>>>>> three +1 PMC votes are cast.
>>>>>>>>>>
>>>>>>>>>> The vote ends on Saturday (September 26, 2015).
>>>>>>>>>>
>>>>>>>>>> [ ] +1 Release this package as Apache Flink 0.10.0-milestone-1
>>>>>>>>>> [ ] -1 Do not release this package, because...
>>>>>>>>>>
>>>>>>>>>> – Fabian
>>>>>>>>>>
>>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>
>>>>>
>>>
>>>
>>
> 

Attachment: signature.asc
Description: OpenPGP digital signature

Reply via email to