Hi Andra, is there a JIRA for the new runtime operator?
Adding a new operator is a lot of work and touches many core parts of the system. It would be good to start a discussion about that early in the process to make sure that the design is aligned with the system. Otherwise, duplicated work might be necessary before it can be added to the system. Cheers, Fabian 2015-04-26 13:05 GMT+02:00 Andra Lungu <lungu.an...@gmail.com>: > Yes Markus, > > ds.reduce() -> AllReduceDriver > ds.groupBy().reduce() -> ReduceDriver > > It's very intuitive ;) > > On Sun, Apr 26, 2015 at 12:34 PM, Markus Holzemer < > holzemer.mar...@googlemail.com> wrote: > > > Hey Andrea, > > perhaps you are looking at the wrong ReduceDriver? > > As you can see in the DriverStrategy enum there is several different > > ReduceDrivers depending on the strategy the optimizer chooses. > > > > best, > > Markus > > > > 2015-04-26 12:26 GMT+02:00 Andra Lungu <lungu.an...@gmail.com>: > > > > > Hey guys, > > > > > > I am trying to add a new runtime operator; > > > To this end, I am following the guide here: > > > > > > > > > http://ci.apache.org/projects/flink/flink-docs-master/internals/add_operator.html > > > and the code itself. > > > > > > > > > From what I understood, the run() in ReduceDriver, for instance, should > > be > > > called every time a reduce() is called. However, I added a breakpoint > in > > > ReduceDriver's run method on the first if and called reduce() on a > > DataSet. > > > When debugging, it seems that the method is not called; I also tried > > adding > > > a log.info() there. That doesn't get printed either... Obviously, the > > same > > > goes for System.out.println. > > > > > > Could someone explain the workflow a bit better? When exactly does > run() > > > get called and what is ReduceDriver's role? > > > > > > Thanks! > > > Andra > > > > > >
