Hi Piotr,
I don't think that is the right solution. Hopefully Nick will notice this
thread and offer his thoughts.
AIUI, this code is intended to route HTTPS calls through the custom code.
IIRC, that fixed some issue that was causing Installer failures in other
situations. I think your proposed change works because you changed the test so
that HTTPS calls no longer go through the custom code, but I think that will
just lead to the original failures. You could try some code that figures out
the custom code failed and reverts to trying super.load() as a backup plan, but
I am more curious as to why that custom code is now failing.
Of course, I could be wrong...
-Alex
On 5/27/18, 2:29 AM, "Piotr Zarzycki" <piotrzarzyck...@gmail.com> wrote:
Hi Alex,
Moved thread to dev.
I just take a look into the installer and found some problem, but not sure
if my fix is appropriate. I'm not sure why it looks like that right now.
[1] Why we have such condition here. Whenever comes url which has been
started from "https" it will be always false, because indexOf returns 0.
I have changed it to indexOf("https://";) != -1 and installer is working,
but not sure if I should commit that.
[1]
https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbit.ly%2F2xeQhzC&data=02%7C01%7Caharui%40adobe.com%7Cc24bf18f2aa5421913c808d5c3b44570%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636630101416589405&sdata=lOXAB3omHonChJR%2BpY41vcsB%2F3V45waAxAwadEge1qA%3D&reserved=0
Thanks,
Piotr
2018-05-27 11:24 GMT+02:00 Alex Harui <aha...@adobe.com.invalid>:
> That list looked reasonable. I just downloaded the tar.gz and extracted
> the files and before running any scripts there were SWCs in
> frameworks/libs. If you haven't run any scripts yet, see what is in your
> frameworks/libs.
>
> I think you should run either "ant thirdparty-downloads" or "ant -f
> installer.xml" but maybe not both.
>
> HTH,
> -Alex
>
> On 5/26/18, 10:46 PM, "1600...@gmail.com on behalf of Douglas McCarroll"
> <1600...@gmail.com on behalf of list.apache-flex....@brightworks.com>
> wrote:
>
> Alex wrote:
>
> > extract the binary package and before running any scripts post the
> list
> of files at the top level.
>
> Here's the list:
>
> Douglass-MacBook-Pro:apache-flex-sdk-4.16.1-bin douglasmccarroll$ ls
>
> CONTRIBUTING asdoc installer.properties
>
> CONTRIBUTORS bin installer.xml
>
> LICENSE build.properties lib
>
> NOTICE build.xml licenseParts
>
> README env-template.properties samples
>
> RELEASE_NOTES flex-sdk-description.xml templates
>
> ant frameworks
>
> apache-flex-sdk-installer-config.xml ide
>
>
>
>
> On Sun, May 27, 2018 at 12:03 AM, Alex Harui <aha...@adobe.com.invalid
> >
> wrote:
>
> > Delete the folder of extracted files. Then extract the binary
> package and
> > before running any scripts post the list of files at the top level.
> >
> > Get Outlook for
Android<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fna01.safelinks.protection.outlook&data=02%7C01%7Caharui%40adobe.com%7Cc24bf18f2aa5421913c808d5c3b44570%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636630101416589405&sdata=0%2B57f2GC8UKO6P%2BLhEtneSqVWgw2kd2nh64%2Bl7lGRv4%3D&reserved=0.
> com/?url=https%3A%2F%2Faka.ms%2Fghei36&data=02%7C01%7Caharui%40adobe.com%
> 7C154c5fcea4314892211a08d5c3953c03%7Cfa7b1b5a7b34438794aed2c178de
> cee1%7C0%7C0%7C636629968110222550&sdata=2684lfrALyuyzpePuVZiVyWi%
> 2Fz98e4MTBg19Xx9b0vk%3D&reserved=0>
> >
> > ________________________________
> > From: 1600...@gmail.com <1600...@gmail.com> on behalf of Douglas
> > McCarroll <list.apache-flex....@brightworks.com>
> > Sent: Thursday, May 24, 2018 7:39:49 AM
> > To: Flex-Users (Apache)
> > Subject: Re: Flex SDK Installer - is it broken?
> >
> > Hi Piotr & All,
> >
> > I've downloaded and extracted the apache-flex-sdk-4.16.1-bin.tar.gz
> file
> > from the page you specified.
> >
> > As the page suggests, I've run "ant thirdparty-downloads" in the
> frameworks
> > subfolder to install optional dependencies. This runs successfully.
> >
> > When I run "ant -f installer.xml -Dair.sdk.version=29.0
> > -Dflash.sdk.version=29.0" in the main folder, I get a message that
> says
> > that the folder "is not an Flex binary package".
> >
> > When I look in installer.xml I find this in the 'install' target:
> >
> > <target name="check-binary" description="Make sure this is a
> binary
> > package">
> > <fail message="${basedir} is not an Flex binary package">
> > <condition>
> > <not>
> > <available
> > file="${basedir}/frameworks/libs/framework.swc" />
> > </not>
> > </condition>
> > </fail>
> >
> > Obviously, it is looking for /frameworks/libs/framework.swc and not
> finding
> > it.
> >
> > When I look in the libs folder the only file I see there is
osmf.swc.
> >
> > Can you tell me what I am doing wrong?
> >
> > Thanks,
> >
> > Douglas
> >
> >
> > On Wed, May 23, 2018 at 2:01 AM, Piotr Zarzycki <
> piotrzarzyck...@gmail.com
> > >
> > wrote:
> >
> > > Hi Guys,
> > >
> > > I have my hands full with other tasks, so not sure when I will
> find the
> > > time to look into that. If you would like to download SDK you have
> also
> > > other option by using ant.
> > >
> > > 1) Download SDK binaries from here [1]
> > > 2) Run in downloaded folder:
> > >
> > > "ant -f installer.xml -Dair.sdk.version=29.0
> -Dflash.sdk.version=29.0"
> > >
> > > [1] https://na01.safelinks.protection.outlook.com/?url=
> > https%3A%2F%2Fflex.apache.org%2Fdownload-binaries.html&data=
> > 02%7C01%7Caharui%40adobe.com%7Ca816db683efd473420ed08d5c2e83dd6%
> > 7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%
> 7C636629225118231214&sdata=
> > CZ2vfsQrAtwj5AaG3VT9cEArODajyAAIElVANnCRbMA%3D&reserved=0
> > >
> > > Thanks,
> > >
> > > 2018-05-23 1:21 GMT+02:00 lixusnet <jamal.rom...@gmail.com>:
> > >
> > > > I am having the same problem. I used install Flex SDK using the
> > installer
> > > > without any problems. But now it fails. Sometimes I get
> connection
> > > timeout.
> > > > Please helo
> > > >
> > > >
> > > >
> > > > --
> > > > Sent from: https://na01.safelinks.protection.outlook.com/?url=
> > http%3A%2F%2Fapache-flex-users.2333346.n4.nabble.com%
> > 2F&data=02%7C01%7Caharui%40adobe.com%7Ca816db683efd473420ed08d5c2e8
> 3dd6%
> > 7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%
> 7C636629225118231214&sdata=
> > e6LPD05%2B9vNyNBYr4A%2FvII99Kbpq97Bx1E9C2Vyydns%3D&reserved=0
> > > >
> > >
> > >
> > >
> > > --
> > >
> > > Piotr Zarzycki
> > >
> > > Patreon: *https://na01.safelinks.protection.outlook.com/?url=
> > https%3A%2F%2Fwww.patreon.com%2Fpiotrzarzycki&data=02%7C01%
> > 7Caharui%40adobe.com%7Ca816db683efd473420ed08d5c2e83dd6%
> > 7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%
> 7C636629225118231214&sdata=
> > 1nVP0JK2G3sl2QIUBH%2FqYQPYY4syZYRsGi1hRSnzyW0%3D&reserved=0
> > > <https://na01.safelinks.protection.outlook.com/?url=
> > https%3A%2F%2Fwww.patreon.com%2Fpiotrzarzycki&data=02%7C01%
> > 7Caharui%40adobe.com%7Ca816db683efd473420ed08d5c2e83dd6%
> > 7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%
> 7C636629225118231214&sdata=
> > 1nVP0JK2G3sl2QIUBH%2FqYQPYY4syZYRsGi1hRSnzyW0%3D&reserved=0>*
> > >
> >
>
>
>
--
Piotr Zarzycki
Patreon:
*https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patreon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7Cc24bf18f2aa5421913c808d5c3b44570%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636630101416599415&sdata=oDqnIskXY1i3%2FTeH1JYmMTetNL8eSF6vOXJxFe8E2dE%3D&reserved=0
<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patreon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7Cc24bf18f2aa5421913c808d5c3b44570%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636630101416599415&sdata=oDqnIskXY1i3%2FTeH1JYmMTetNL8eSF6vOXJxFe8E2dE%3D&reserved=0>*
