Phil, Thanks for looking into that. You can try to fix it on your own and make pull request!
Thanks, Piotr On Tue, Apr 24, 2018, 3:31 AM Phil Haeusler <philhaeus...@gmail.com> wrote: > Hi Piotr > > FLEX-35384 Raised [1] > > I don't appear to have the permission to assign issues, so it's currently > left unassigned. > > I am using High Sierra. > > I grabbed the installer code and had a quick look, and it appears that the > method InstallApacheFlex.unzipAdobeAIRSDKMac() is always calling untar() on > the downloaded file without taking into account that AIR v24 and later is > now delivered as a .dmg > > [1] https://issues.apache.org/jira/browse/FLEX-35384 > > Thanks > Phil > > > On 23 April 2018 at 18:20, Piotr Zarzycki <piotrzarzyck...@gmail.com> > wrote: > > > Hi Phil, > > > > Many Thanks for all of those tests. Can you raise JIRA and assign to me > [1] > > with all your findings. I will try to find some time this month and play > a > > bit with that stuff on my Mac. Are you running High Sierra ? > > > > [1] https://issues.apache.org/jira/projects/FLEX/summary > > > > Thanks, > > Piotr > > > > 2018-04-23 5:08 GMT+02:00 Phil Haeusler <philhaeus...@gmail.com>: > > > > > Hi > > > > > > I have done some further investigation into this issue and have found > > that > > > I am unable to successfully build a v4.13 SDK with any AIR version > after > > > v23 using a Mac. > > > > > > From AIR 24 or later, it appears that the AIR SDK is not overlaid > > > successfully resulting in a SDK that the installer says is packaged > > > successfully, but it cannot be used with an IDE. > > > > > > While i initially discovered this testing the 3.3.1 RC, I have since > > > switched back to the v3.3 installer and experienced the same behaviour. > > > > > > In my testing I am successfully able to build the 4.13 SDK with AIR 20, > > 21 > > > and 23. > > > > > > I've run 2 tests packaging with AIR 22 but both times the installer > > errors > > > out and leaves a 1.5gig directory. This errors attempting to retrieve > > > playerglobal_22.swc and leaves the in/ folder on disk. I'm not > concerned > > > about this failure as part of my current issue. > > > > > > Then for AIR 24 through 29, the installer reports a successfully > created > > > SDK, however in all cases the AIR SDK hasn't been overlaid - resulting > > in a > > > SDK directory that cannot be used for development. > > > > > > Here's a snapshot of the folder sizes of each of the SDK packages i've > > > tried creating. > > > > > > 556M flex413air20 > > > > > > 569M flex413air21 > > > > > > 1.5G flex413air22 > > > > > > 534M flex413air23 > > > > > > 125M flex413air24 > > > > > > 125M flex413air25 > > > > > > 125M flex413air26 > > > > > > 125M flex413air27 > > > > > > 125M flex413air28 > > > > > > 125M flex413air29 > > > > > > Reading through the installer.log for the AIR 23 vs AIR 24 builds, the > > only > > > difference i can see is that from v24 onwards, the AIR SDK is > downloaded > > as > > > a .dmg file rather than a .tbz2 file > > > > > > i.e. > > > AIR 23 - Downloading Adobe AIR Runtime Kit for Mac from: > > > http://airdownload.adobe.com/air/mac/download/23.0//AdobeAIRSDK.tbz2 > > > > > > AIR 24 - Downloading Adobe AIR Runtime Kit for Mac from: > > > http://airdownload.adobe.com/air/mac/download/24.0//AdobeAIRSDK.dmg > > > > > > This matches up with the switch in file extensions as configured in > > > http://flex.apache.org/installer/sdk-installer-config-4.0.xml > > > > > > For both cases however the installer then tries to untar the downloaded > > AIR > > > SDK file, but this doesn't make sense for a .dmg file > > > > > > i.e. > > > > > > AIR23 > > > > > > air-setup-mac: > > > [mkdir] Created directory /Users/phil/flex413air23-2/in/airsdk > > > [move] Moving 1 file to > > > /Users/phil/flex413air23-2/in/airsdk/AdobeAIRSDK.tbz2 > > > Finished untaring: /Users/phil/flex413air23-2/in/airsdk/AdobeAIRSDK.tar > > > [delete] Deleting file /Users/phil/flex413air23-2/airtar.properties > > > > > > AIR24 > > > > > > air-setup-mac: > > > [mkdir] Created directory /Users/phil/flex413air24-2/in/airsdk > > > [move] Moving 1 file to > > > /Users/phil/flex413air24-2/in/airsdk/AdobeAIRSDK.dmg > > > Finished untaring: /Users/phil/flex413air24-2/in/airsdk/AdobeAIRSDK.dmg > > > [delete] Deleting file /Users/phil/flex413air24-2/airtar.properties > > > > > > it appears that the installer is attempting untar the v24 > AdobeAIRSDK.dmg > > > file rather then mounting it to extract its contents. This doesn't > > produce > > > an error, and the installer proceeds to attempt to copy files that > > haven't > > > been extracted, also without error. > > > > > > This then results in the installer completing successfully, but without > > > having actually overlaid the AIR SDK. > > > > > > Phil > > > > > > > > > > > > On 18 April 2018 at 11:42, Phil Haeusler <philhaeus...@gmail.com> > wrote: > > > > > > > Piotr > > > > > > > > I have reinstalled the 3.3.1 RC2 install on both Mac and Windows for > > Flex > > > > 4.13 and AIR29. Both now package the SDK and complete successfully. > > > > > > > > With my tests yesterday I was using the download cache while today I > > > > forced the installer to re-download everything. I'm not sure if this > > > was a > > > > contributing factor to my success today or not on Windows. > > > > > > > > However, I have noticed a significant size difference between the Mac > > and > > > > Windows builds of the SDK. > > > > > > > > The Mac folder is 119.2MB in size while the Windows is 1.15GB. > > > > > > > > It appears that the Mac installer didn't overlay the AIR sdk by > looking > > > at > > > > the generated folder. I've tried this a couple of times now and it > > > happens > > > > consistently. > > > > > > > > The folder contents of the Mac and Windows sdks created with the > > > installer > > > > are below. > > > > > > > > Thanks > > > > Phil > > > > > > > > > > > > phil:flex_sdk_413_air29-mac du -sh * > > > > > > > > 4.0K CONTRIBUTING > > > > > > > > 40K LICENSE > > > > > > > > 4.0K NOTICE > > > > > > > > 28K README > > > > > > > > 64K RELEASE_NOTES > > > > > > > > 284K ant > > > > > > > > 32K apache-flex-sdk-installer-config.xml > > > > > > > > 1.2M asdoc > > > > > > > > 120K bin > > > > > > > > 4.0K build.properties > > > > > > > > 8.0K en_AU.properties > > > > > > > > 8.0K env-template.properties > > > > > > > > 4.0K flex-sdk-description.xml > > > > > > > > 86M frameworks > > > > > > > > 136K ide > > > > > > > > 16K installer.log > > > > > > > > 80K installer.properties > > > > > > > > 48K installer.xml > > > > > > > > 30M lib > > > > > > > > 6.3M samples > > > > > > > > 84K sdk-installer-config-4.0.xml > > > > > > > > 72K templates > > > > > > > > phil:flex_sdk_413_air29-win du -sh * > > > > > > > > 16K AIR SDK Readme.txt > > > > > > > > 1.5M AIR SDK license.pdf > > > > > > > > 4.0K CONTRIBUTING > > > > > > > > 40K LICENSE > > > > > > > > 4.0K NOTICE > > > > > > > > 28K README > > > > > > > > 64K RELEASE_NOTES > > > > > > > > 12K airsdk.xml > > > > > > > > 396K ant > > > > > > > > 32K apache-flex-sdk-installer-config.xml > > > > > > > > 1.2M asdoc > > > > > > > > 496K bin > > > > > > > > 4.0K build.properties > > > > > > > > 12K en_US.properties > > > > > > > > 8.0K env-template.properties > > > > > > > > 4.0K flex-sdk-description.xml > > > > > > > > 103M frameworks > > > > > > > > 184K ide > > > > > > > > 36K include > > > > > > > > 8.7M install > > > > > > > > 12K installer.log > > > > > > > > 96K installer.properties > > > > > > > > 48K installer.xml > > > > > > > > 936M lib > > > > > > > > 152M runtimes > > > > > > > > 7.1M samples > > > > > > > > 84K sdk-installer-config-4.0.xml > > > > > > > > 752K templates > > > > > > > > > > > > > > > > > > > > On 17 April 2018 at 17:13, piotrz <piotrzarzyck...@gmail.com> wrote: > > > > > > > >> Phil, > > > >> > > > >> I just tried again that RC and I didn't experience this issue. In > the > > > >> previous one I was able to reproduce it. > > > >> > > > >> <http://apache-flex-development.2333347.n4.nabble.com/file/ > > > >> t740/flex_4.png> > > > >> > > > >> Any chance try on another Machine ? > > > >> > > > >> Thanks, > > > >> Piotr > > > >> > > > >> > > > >> > > > >> ----- > > > >> Patreon: https://www.patreon.com/piotrzarzycki > > > >> -- > > > >> Sent from: http://apache-flex-development.2333347.n4.nabble.com/ > > > >> > > > > > > > > > > > > > > > > > > > -- > > > > Piotr Zarzycki > > > > Patreon: *https://www.patreon.com/piotrzarzycki > > <https://www.patreon.com/piotrzarzycki>* > > >
