Sent from my iPhone
> On Jul 6, 2017, at 5:22 PM, Justin Mclean <jus...@classsoftware.com> wrote: > > Hi, > >> If you make a change to fix technical debt then you should also assure that >> both existing tests pass and if no tests exist then tests are added and >> proper. > > I’m all for more tests. However should this apply to any changes anyone makes > for any reason OR only changes I make? It applies to making other than the most minimal changes due to a sonar report. Obviously trivial changes like the ; but not the === require discussion. Think of it like this if someone makes a commit you would not revert without giving them an opportunity to do it first. So the suggestion from me is get approval for anything complex. It is the social thing to do. > > I asking because taken literally this could possible end up being a situation > were any changes I make are vetoed due to low test coverage but other people > can make changes and ignore test coverage. I see you asked directly about a standard else thread. Regards, Dave > > Thanks, > Justin
