Ok … so I setup a build that doesn’t accidentally pull in SNAPSHOTS from the
Apache repo:
mvn clean install -Drat.skip=true -s ~/.m2/settings-test.xml
(My settings-test.xml simply excludes the Apache snapshot repo)
One thing I found (no this is not going to be a legal thing … I am reporting
this as technical issue):
When building the compiler, this fails as inside the flex-typedefs directory
there are 3 files without correct license headers (yes exactly those ones). If
the typedefs repo is required to be nested inside the compiler, then the maven
rat configuration needs to be made aware of that. Verifying a release candidate
with switched off RAT doesn’t feel right … (Not enough for a -1 though)
Another thing I noticed, is that the build is producing SNAPSHOT versions and
is referencing SNAPSHOT versions. We will not be able to publish these
artifacts to Maven Central. Well we will also not be able to publish them to
the Apache Repo for release.
I could build the typedefs however with:
mvn clean install -s ~/.m2/settings-test.xml
So, I guess the problems others are having are related to them having different
git executalbes (I remember having problems with older git versions)
bash-3.2$ git --version
git version 2.12.0
So, this works for me, but I still think relying on command-line tools in the
build is bad and should be replaced by a java based patch solution.
But not being able to release stuff to Maven-Central is reason enough for a -1
… sorry for that … next RC should also handle the version numbers of the maven
pom as I described them in my last post to this thread.
Chris
Am 12.06.17, 10:33 schrieb "carlos.rov...@gmail.com im Auftrag von Carlos
Rovira" <carlos.rov...@gmail.com im Auftrag von carlos.rov...@codeoscopic.com>:
Hi Piotrz,
sorry, but I almost sure we decided to put maven as main way of building. I
know how to build with ant with the approve xml, and did it other times for
other releases, but I think is totally wrong with what we agreed in this
list.
Maybe I'm wrong but if not, It's almost strange to me not find any maven
mention, and again ANT all over the place...
I think one of the things we did (and very good from my point of view) is
put maven in good shape and many of us are working with that build system.
As other things where enhanced, this is another want to take into account
and is very rare that for this 0.8.0 is like we don't get any progress in
maven build.
I prefer not to vote this release, but don't want to bother with my way of
thinking about maven-ant.
Thanks for your help Piotr!
Carlos
2017-06-10 21:14 GMT+02:00 piotrz <piotrzarzyck...@gmail.com>:
> Hi Carlos,
>
> Unfortunately Maven is not the main way of building of FlexJS.
>
> - Flex installer still serves Ant build of FlexJS for the user.
> - Maven distribution package of FlexJS has some missing thing and it is
not
> usable by IDE - jira has been raised.
>
> As for the tests:
> I did all tests as you mention, additionally I run ApproveFalcon.xml
script
> which help you check everything and Ant build.
> Copy ApproveFalcon.xml to empty folder and run:
>
> ant -f ApproveFalcon.xml -Drelease.version=0.8.0
>
> Piotr
>
>
>
>
> -----
> Apache Flex PMC
> piotrzarzyck...@gmail.com
> --
> View this message in context: http://apache-flex-
> development.2333347.n4.nabble.com/DISCUSS-Discuss-Release-
> Apache-FlexJS-0-8-0-RC1-tp62274p62299.html
> Sent from the Apache Flex Development mailing list archive at Nabble.com.
>
--
<http://www.codeoscopic.com>
Carlos Rovira
Director General
M: +34 607 22 60 05
http://www.codeoscopic.com
http://www.avant2.es
Este mensaje se dirige exclusivamente a su destinatario y puede contener
información privilegiada o confidencial. Si ha recibido este mensaje por
error, le rogamos que nos lo comunique inmediatamente por esta misma vía y
proceda a su destrucción.
De la vigente Ley Orgánica de Protección de Datos (15/1999), le comunicamos
que sus datos forman parte de un fichero cuyo responsable es CODEOSCOPIC
S.A. La finalidad de dicho tratamiento es facilitar la prestación del
servicio o información solicitados, teniendo usted derecho de acceso,
rectificación, cancelación y oposición de sus datos dirigiéndose a nuestras
oficinas c/ Paseo de la Habana 9-11, 28036, Madrid con la documentación
necesaria.
