Agreed. Justin is good at catching licensing issues, and he seems willing to fix them himself, so let's not hold him back if he wants to do that. As long as his proposed changes seem correct at a glance, I feel like this should not require any discussion except to say "go for it!"
- Josh On Tue, May 23, 2017 at 1:03 PM, Christofer Dutz <christofer.d...@c-ware.de> wrote: > Hi Alex, > > I disagree … if things like this are found, why do them later instead of > just fixing things and not have to deal with them again? > > I would like to resolve things like this as quietly and as swiftly as > possible. It’s not keeping you from your work, is it? > > And it’s not going to conflict any operational code, is it? > > So, if Justin found something, just let him fix it and not start yet > another license discussion about it. But that’s just my opinion. > > Chris > > > > Am 23.05.17, 17:04 schrieb "Alex Harui" <aha...@adobe.com.INVALID>: > > Did RAT catch this? If not, why bother doing anything here? Might > want > to check with the RAT folks to see why they permit it and deal with it > after the release. Let's spend our energy on making sure there aren't > any > big bugs out there. > > Thanks, > -Alex > > On 5/23/17, 7:39 AM, "Josh Tynjala" <joshtynj...@gmail.com> wrote: > > >+1 > > > >I'm sure it's just a copy/paste mistake. Let's go ahead and make them > >consistent. > > > >- Josh > > > >On Tue, May 23, 2017 at 5:44 AM, Christofer Dutz > ><christofer.d...@c-ware.de> > >wrote: > > > >> So how about just updating all places where the license is not > correct? > >> I guess this should be as easy as 1,2,3 … or are there any problems > with > >> this. Then copy & pasting the wrong version should become quite > >>difficult > >> ;-) > >> > >> Chris > >> > >> > >> Am 23.05.17, 13:45 schrieb "Harbs" <harbs.li...@gmail.com>: > >> > >> That file is one I created. I copy-pasted the header from a > >>different > >> file (I don’t remember which one). > >> > >> I did not notice there are two different headers being used, so > no > >> clues here… > >> > >> Harbs > >> > >> > On May 23, 2017, at 5:11 AM, Justin Mclean > >><jus...@classsoftware.com> > >> wrote: > >> > > >> > HI, > >> > > >> >> that problem is a simple copy-paste > >> > > >> > I’m thinking that what it probably is but may be a reason I’m > >> unaware of. > >> > > >> > Thanks, > >> > Justin > >> > >> > >> > >> > > > >
