Hi Alex, I think I miss-read the ant thing ... Sorry for that. But I got the implementing Maven from the ability to process poms as this would require that unless you add a direct dependency to Maven libraries, which I think is also a bad idea ... That's what Maven plugins are used for.
Cleaning up the config and adding the possibility to pass that into the compiler ist the only true option in my opinion. Chris Von meinem Samsung Galaxy Smartphone gesendet. -------- Ursprüngliche Nachricht -------- Von: Alex Harui <aha...@adobe.com.INVALID> Datum: 12.05.17 11:01 (GMT-05:00) An: dev@flex.apache.org Betreff: Re: [LAST CALL] Release FlexJS/FalconJX 0.8.0 Hmm. How does "teach Falcon to read the pom.xml files and do away with the -config.xml files" translate into "Requiring ant to build Maven" or "implementing Maven in falcon"? I believe this fork of this thread is merely about moving some of the code from BaseMojo into Falcon. I'm pretty sure I know how to do this. At some point, I will make a branch and show what I mean. I don't know what you mean by "inject a clean configuration model from the outside" but feel free to make a branch and show us what you mean. IMO, we support not only Maven and Ant for building the framework, but we also support building the SWCs with IDEs. Right now, folks don't have to run a build to get the -config.xml they need to use an IDE to build the SWCs. My proposal is simply one way I can think of and know how to implement that I think addresses all three workflows. It was not intended to be what you are claiming. Thanks, -Alex On 5/12/17, 7:08 AM, "Christofer Dutz" <christofer.d...@c-ware.de> wrote: >Maven is a lot more than pom files ... I would strongly object almost all >options in this email. > >Requiring ant to build Maven is a complete no-go for me.I didn't put that >much effort in the project just to let this dependency in again. > >Re implementing Maven in falcon is also a no-go as it would require re >implementing Maven in falcon, which is also out of the question. > >An option would be to finally clean up the config code of falcon and to >inject a clean configuration model from the outside. That could then be >done from the Maven plugin. I didn't want to use the config files, but >the config code is such a mess with statics and strange code, that it was >the only option. My suggestions to clean up were reduced to simple itches >only I was having. > >Generally I would rather opt for finally going down the Maven-first path >and to maintain the ant build as a convenience package. Then we wouldn't >have to re-sync all the time. The current way (some writing on Ant, some >on Maven) produces far too many pains. > >Chris > > > >Von meinem Samsung Galaxy Smartphone gesendet. > > >-------- Ursprüngliche Nachricht -------- >Von: Alex Harui <aha...@adobe.com.INVALID> >Datum: 11.05.17 20:04 (GMT-05:00) >An: dev@flex.apache.org >Betreff: Re: [LAST CALL] Release FlexJS/FalconJX 0.8.0 > >Hmm. How far off are they? I'm not sure I have the cycles to try to >reconcile this if we want to have a release by the Summit. > >AIUI, the maven -config files are generated by the Maven Mojos. If we >generate the -config files as part of the Ant build, then you can't just >clone the repo, unpack the release and open the FB projects for the SWCs >and have them work without running a build to generate them. That's a >different workflow, so we should make sure folks want that before we go >and do something like that, and that seems too risky this late in the >release cycle. > >One idea I had in the future is to teach Falcon to read the pom.xml files >and do away with the -config.xml files. I've already taught Falcon to >read Flash Builder project files so there is precedence for doing >something like this. Volunteers are welcome to take this on, but again, >seems too risky for this release. > >Thoughts? >-Alex > >On 5/11/17, 2:09 PM, "Josh Tynjala" <joshtynj...@gmail.com> wrote: > >>It seems that the Maven -config.xml files are not a simple copy/paste. >>They've been modified a bit. In a Maven distribution, the manifest XML >>files are copied to a different location. The Maven distribution does not >>include the original ActionScript source code and things from >>frameworks/projects, so I guess the manifests were moved to >>frameworks/manifests instead. The Maven build should probably copy all >>the >>ActionScript source code, though, and then it can use the same >>-config.xml >>files as the Ant build. >> >>- Josh >> >>On Thu, May 11, 2017 at 1:58 PM, Josh Tynjala <joshtynj...@gmail.com> >>wrote: >> >>> For some reason, the Maven build duplicates a number of files from >>> flex-asjs/frameworks in >>>flex-asjs/distribution/src/main/resources/frameworks. >>> It seems that these duplicates have gotten out of sync after the "dual" >>> changes. >>> >>> It would probably be better if there were one canonical source for >>>these >>> files that is used by both Ant and Maven builds because it seems easy >>>to >>> forget to update both locations. A while back, when I was testing the >>> VSCode extension, I discovered that the Maven SDK contained some >>> *-config.xml files had some differences that caused issues too. I fixed >>> them at the time, but it's probably not good if this is becoming a >>>repeated >>> problem. >>> >>> - Josh >>> >>> On Fri, Apr 21, 2017 at 9:54 PM, Alex Harui <aha...@adobe.com> wrote: >>> >>>> Hi, >>>> >>>> It's been six months or so since 0.7.0 and it would be nice to get a >>>>new >>>> release out before/at ApacheCon. >>>> >>>> I have just seen the dual branch build successfully for both Ant and >>>>Maven >>>> when merged with the develop branch as of yesterday. >>>>DataBindingExample >>>> works ok, there are some sizing issues, and I will be going through >>>>the >>>> other examples and tuning them up. In the mean time, it would be >>>>great >>>> for folks to poke at the dual branch before I merge it into develop. >>>> >>>> Once dual is merged with develop, I'll create the release branch and >>>> release builds. >>>> >>>> The only other "must do" I know of is to make sure we've removed the >>>> dependency on org.json. >>>> >>>> What else do we need to get done before we release 0.8.0? >>>> >>>> Thanks, >>>> -Alex >>>> >>>> >>> >
