They're not too different. I think it's just the paths to the manifest.xml files that are changed in the Maven distribution. I will try to copy the new versions over and make the required tweaks today. I can easily test the Maven distribution in my testing environment for vscode-nextgenas to be sure it's working after my changes.
I'll also file a new issue for the missing contents of the frameworks/projects directory in the Maven distribution. Once the project source files are included in the distribution (including manifest.xml files in their original locations), we can at least copy the -config.xml files into the Maven distribution location without requiring modification. That will be better overall, I think. Esepcially since the manifest.xml files in their original locations are actually following the correct Maven directory structure already! - Josh On Thu, May 11, 2017 at 5:04 PM, Alex Harui <aha...@adobe.com.invalid> wrote: > Hmm. How far off are they? I'm not sure I have the cycles to try to > reconcile this if we want to have a release by the Summit. > > AIUI, the maven -config files are generated by the Maven Mojos. If we > generate the -config files as part of the Ant build, then you can't just > clone the repo, unpack the release and open the FB projects for the SWCs > and have them work without running a build to generate them. That's a > different workflow, so we should make sure folks want that before we go > and do something like that, and that seems too risky this late in the > release cycle. > > One idea I had in the future is to teach Falcon to read the pom.xml files > and do away with the -config.xml files. I've already taught Falcon to > read Flash Builder project files so there is precedence for doing > something like this. Volunteers are welcome to take this on, but again, > seems too risky for this release. > > Thoughts? > -Alex > > On 5/11/17, 2:09 PM, "Josh Tynjala" <joshtynj...@gmail.com> wrote: > > >It seems that the Maven -config.xml files are not a simple copy/paste. > >They've been modified a bit. In a Maven distribution, the manifest XML > >files are copied to a different location. The Maven distribution does not > >include the original ActionScript source code and things from > >frameworks/projects, so I guess the manifests were moved to > >frameworks/manifests instead. The Maven build should probably copy all the > >ActionScript source code, though, and then it can use the same -config.xml > >files as the Ant build. > > > >- Josh > > > >On Thu, May 11, 2017 at 1:58 PM, Josh Tynjala <joshtynj...@gmail.com> > >wrote: > > > >> For some reason, the Maven build duplicates a number of files from > >> flex-asjs/frameworks in > >>flex-asjs/distribution/src/main/resources/frameworks. > >> It seems that these duplicates have gotten out of sync after the "dual" > >> changes. > >> > >> It would probably be better if there were one canonical source for these > >> files that is used by both Ant and Maven builds because it seems easy to > >> forget to update both locations. A while back, when I was testing the > >> VSCode extension, I discovered that the Maven SDK contained some > >> *-config.xml files had some differences that caused issues too. I fixed > >> them at the time, but it's probably not good if this is becoming a > >>repeated > >> problem. > >> > >> - Josh > >> > >> On Fri, Apr 21, 2017 at 9:54 PM, Alex Harui <aha...@adobe.com> wrote: > >> > >>> Hi, > >>> > >>> It's been six months or so since 0.7.0 and it would be nice to get a > >>>new > >>> release out before/at ApacheCon. > >>> > >>> I have just seen the dual branch build successfully for both Ant and > >>>Maven > >>> when merged with the develop branch as of yesterday. > >>>DataBindingExample > >>> works ok, there are some sizing issues, and I will be going through the > >>> other examples and tuning them up. In the mean time, it would be great > >>> for folks to poke at the dual branch before I merge it into develop. > >>> > >>> Once dual is merged with develop, I'll create the release branch and > >>> release builds. > >>> > >>> The only other "must do" I know of is to make sure we've removed the > >>> dependency on org.json. > >>> > >>> What else do we need to get done before we release 0.8.0? > >>> > >>> Thanks, > >>> -Alex > >>> > >>> > >> > >
