On 2/15/17, 5:57 PM, "Justin Mclean" <jus...@classsoftware.com> wrote:
>Hi, > >> I'm not saying the ApprovalScript is a requirement, I'm saying that that >> is what I use, so you can know up front what tests I am going to run so >> you can potentially save all of us time by making sure it passes those >> tests before offering another RC. > >The ApprovalScript generally fails to me as it timeouts on downloading >the artifacts or takes hours to do so. It also doesn’t test the actual RC >just what’s built on the CI machine which in theory should be the same >but that has bitten me a few times due to differences what’s in >.git_ignore and similar. If it could test a RC I just made on my machine >without downloading anything I would probably use it. It also picks up >environment variables so I was never sure exactly what it was testing >it's all a bit too black box for me. It runs rat with exclusions which >from my experience in the incubator where most issues show up. It >probably works better in the US (where the server is located?) or for >people who have better bandwidth connections. If you run it with -Drc=2 it would grab RC2 from dist.apache.org. Also you can manually download the artifacts and run the main-no-download target. If we improve it, instead of complaining about it, it will save everyone in the community time and maybe encourage more folks to be RMs. -Alex
