Maven only cleans up it’s own stuff. So if you do something with Maven, this is
automatically guaranteed to be cleaned up, but if you do stuff with Ant for
examople (or use the „sonar-runner.bat“ to do a sonarqube check) then this
might leave files which maven doesn’t know about. Therefore rat complains. I
think it’s a good thing as when enabling the plugin I had to update a huge
amount of files manually. This way the contributor is immediatley made aware of
the problem that otherwise someone else will have to do for him.
In general I think we should all just know to look at the rat.txt in case of a
failure and that is guaranteed to contain all information you need. But if the
others agree, I could just make it run in the release profile ... but that
would bring up licensing issues at release preparation time.
Chris
Am 21.12.16, 19:12 schrieb "omup...@gmail.com im Auftrag von OmPrakash
Muppirala" <omup...@gmail.com im Auftrag von bigosma...@gmail.com>:
On Dec 21, 2016 9:52 AM, "Alex Harui" <aha...@adobe.com> wrote:
On 12/21/16, 9:10 AM, "omup...@gmail.com on behalf of OmPrakash Muppirala"
<omup...@gmail.com on behalf of bigosma...@gmail.com> wrote:
>Chris, any chance we can disable the rat check by default? I got hit by
>that as well. Seems like a common place that could trip people up.
The Rat check is useful. It helps make sure things are cleaned up
properly. I have a two separate working copy of the repos. I build Ant
in one and Maven in the other.
I see. So if the mvn clean goes well, the rat check should always pass?
HTH,
-Alex
