On 12/5/16, 3:39 AM, "carlos.rov...@gmail.com on behalf of Carlos Rovira" <carlos.rov...@gmail.com on behalf of carlosrov...@apache.org> wrote:
>Hi Alex, > >to introduce the problem: > >I took a look and saw that your ListItemRenderer is in the application >> project, not a library project, but it contains conditional compile >>code. >> I'm not sure we've ironed out that workflow. The main idea was that >> application developers wouldn't need conditional compilation. All APIs >> they would need would be cross-platform and all the platform-specific >> stuff would be encapsulated into the library SWCs. >> >> >mmm...I was thinking on that decision and I think it should be hard to >make >devs understand that they >can't do that in their projects. > >I think use case like custom item renderers are very common. We should >expect FlexJS users writing >custom IR a lot in their apps. If they are writing a complex app...should >be normal to has one or more swc libs >created by them, but we all now that one of the powers of flex is make a >fast app in one single project and even >in few files (classes). So I think, although I understand the decision and >intention, I think that is not practical. As Yishay says, custom item renderers should be possible without platform-specific code. If you had a base class in the framework that wrapped LI then you probably wouldn't have any conditional compile in your renderer. Still, we should allow for it at some point. > >btw, you pointed me to change COMPILE::JS to true, but how I can do this? >I see that in some build.xml but no in pom.xml. So although I search, I >don't know how to do this right now. >Some clue or where to dig? Well for Ant and FB integration, it is as simple as adding the compiler flags. I think for Maven this sort of thing is buried in the Mojo, but I would think you could use the additional compiler options to set it for now. -Alex
