That sounds even better to me.
- Josh
On Mon, Nov 7, 2016 at 8:43 AM, Alex Harui <aha...@adobe.com> wrote:
> Thinking about this some more: What really would be the harm if the
> compiler didn't clean out the output folder? I'm not sure we even need a
> flag. Most compilers don't clean the output folder.
>
> Thoughts?
> -Alex
>
> On 11/7/16, 6:41 AM, "Josh Tynjala" <joshtynj...@gmail.com> wrote:
>
> >A flag that tells the compiler not to delete the contents of the output
> >directory might be useful for other things too. I've sometimes wanted to
> >copy files there and just leave them instead of recopying every time (or
> >having to write a script to recopy).
> >
> >- Josh
> >
> >On Nov 7, 2016 12:12 AM, "Christofer Dutz" <christofer.d...@c-ware.de>
> >wrote:
> >
> >> Hi Alex,
> >>
> >> It could, but only by configuring the resources plugin to run in a phase
> >> after the compiler which is not the default and looks more like a hack
> >>to
> >> me.
> >> I would like to keep things default as everything else complicates
> >>things
> >> and could confuse users.
> >>
> >> Another option would be to set a flag and disable this functionality so
> >>if
> >> for example „mavenBuild=true“ in the compiler the clean and
> >>resource-copy
> >> are skipped.
> >>
> >> Chris
> >>
> >> Am 07.11.16, 08:17 schrieb "Alex Harui" <aha...@adobe.com>:
> >>
> >> Can the resources plugin run after the compiler?
> >>
> >> -Alex
> >>
> >> On 11/6/16, 11:04 PM, "Christofer Dutz" <christofer.d...@c-ware.de>
> >> wrote:
> >>
> >> >Hi Carlos,
> >> >
> >> >I found the cause for the problem.
> >> >
> >> >The thing is that the resources plugin correctly copies stuff to
> >>the
> >> >target directory. Unfortunately the first thing the flexjs compiler
> >> does
> >> >is clean the output directory.
> >> >In order to solve this, I would like to have the clean code
> >>separated
> >> >from the compile code. Ideally we would also separate the copying
> >>of
> >> >resources. An option would be to set some sort of „isAntBuild“ flag
> >> and
> >> >to skip these code parts for non ant builds.
> >> >In Maven there is a dedicated clean lifecycle for cleaning up
> >>things
> >> and
> >> >a copy-resources phase for copying resources and I would like to
> >> utilize
> >> >these.
> >> >
> >> >I did some minor changes to the poms of your example ... please
> >>have a
> >> >look. I added the resources plugin to the example root pom and
> >>removed
> >> >some duplicate dependencies in your MDLExample. Additionally I
> >> re-defined
> >> >the resources directory.
> >> >If you do a „mvn clean process-resoureces“ (which is one step
> >>before
> >> the
> >> >compile) you can see that the resources are correctly copied.
> >> >Unfortunately the first thing the compiler does, is delete things.
> >> >
> >> >Chris
> >> >
> >> >Am 06.11.16, 21:13 schrieb "carlos.rov...@gmail.com im Auftrag von
> >> Carlos
> >> >Rovira" <carlos.rov...@gmail.com im Auftrag von
> >> >carlos.rov...@codeoscopic.com>:
> >> >
> >> > @Alex, thanks for looking into this
> >> >
> >> > @Chris, I tried to copy from commit
> >> >a07e0a2e34c8b749f9cb3009860a9a3e34942621
> >> >
> >> > <properties>
> >> >
> >> >
> >> ><compiler.output-dir>${basedir}/target/javascript/
> >> bin/js-debug</compiler.o
> >> >utput-dir>
> >> > </properties>
> >> >
> >> > and
> >> >
> >> > <!-- Copy the resources to the compiler output
> >>directory
> >> -->
> >> > <plugin>
> >> > <groupId>org.apache.maven.plugins</groupId>
> >> > <artifactId>maven-resources-plugin</artifactId>
> >> > <version>3.0.1</version>
> >> > <configuration>
> >> > <outputDirectory>${compiler.
> >> output-dir}</outputDirectory>
> >> > </configuration>
> >> > </plugin>
> >> >
> >> > But after rebuild my MDLExample nothing changed. I miss
> >>something?
> >> >
> >> > Thanks
> >> >
> >> > Carlos
> >> >
> >> >
> >> >
> >> >
> >> >
> >> > 2016-11-06 16:24 GMT+01:00 Christofer Dutz
> >> ><christofer.d...@c-ware.de>:
> >> >
> >> > > Hi Carlos,
> >> > >
> >> > > have a look at my feature branch where I cleaned up the
> >> directory
> >> > > structure of the examples. I also separated the resources and
> >> >configured
> >> > > the maven-resource-plugin to copy the resources.
> >>Unfortunately
> >> I am
> >> > > currently not able to build that branch due to some really
> >> strange
> >> > > compilation problem . I only changed the structure oft he
> >> examples,
> >> >so I
> >> > > can’t understand, why Core doesn’t build anymore ... will
> >> >investigate this
> >> > > as soon as I find a little time.
> >> > >
> >> > > Chris
> >> > >
> >> > > Am 06.11.16, 13:50 schrieb "carlos.rov...@gmail.com im
> >>Auftrag
> >> von
> >> >Carlos
> >> > > Rovira" <carlos.rov...@gmail.com im Auftrag von
> >> >carlosrov...@apache.org>:
> >> > >
> >> > > Hi,
> >> > >
> >> > > I'm was expending several hours to get FlexJS MDLExample
> >>to
> >> get
> >> >images
> >> > > vía
> >> > > CSS with no luck.
> >> > >
> >> > > I think we need to give some love to CSS image management
> >> since
> >> >this is
> >> > > basic. Not always people should use an Image component to
> >> show
> >> >an
> >> > > image.
> >> > > Some times a Container needs a background image and right
> >> now
> >> >FlexJS
> >> > > can't
> >> > > deal with this.
> >> > >
> >> > > I'm interested in fix this myself, but right now I can't
> >> find
> >> >info in
> >> > > the
> >> > > wiki. I was thinking about change SimpleCSSValuesImpl.as,
> >> but
> >> >when I
> >> > > try
> >> > > this, I should get an BUILD FAILURE when building with
> >> >maven...maybe
> >> > > there's some connection of this code with some falcon CSS
> >> >internals
> >> > > management?. I need to know some explanation about this.
> >> > >
> >> > > I check as well Flex Store JQuery HomeView since there
> >>is a
> >> >container
> >> > > with
> >> > > a bg img, but this is done with an Image componente and
> >> lots of
> >> > > cumbersome
> >> > > code that are not recommended at all. Things here should
> >>be
> >> far
> >> >more
> >> > > easy,
> >> > > just setting the image vía CSS and let the html do its
> >>duty.
> >> > >
> >> > > I see two main problems:
> >> > >
> >> > > 1.- FlexJS remove the CSS rule when is something like ->
> >> >background:
> >> > > url('../../../../src/main/resources/Unknown.jpeg')
> >>center /
> >> >cover;
> >> > > I need FlexJS to output that rule, both in inline style
> >> >properties and
> >> > > inside css files
> >> > > 2.- Second is the problem with paths, that if not
> >>directly
> >> >related is
> >> > > responsible to get things done right. As I talked with
> >> Chris, he
> >> > > proposed
> >> > > to make the build manage additional resource paths. I
> >>could
> >> in
> >> >the mean
> >> > > time put an "assets" folder where resides my App.mxml and
> >> store
> >> >inside
> >> > > images, and then move it to src/main/resources when
> >>things
> >> >settles in
> >> > > the
> >> > > right way.
> >> > >
> >> > > If we get this done and get divs, spans, and others to
> >>show
> >> >images, we
> >> > > can
> >> > > gain many things in terms of look and feel of Flex Apps.
> >>For
> >> >example I
> >> > > would like to implement with FlexJS this example page:
> >> > > https://getmdl.io/templates/blog/index.html
> >> > > I need this image css support to get this.
> >> > >
> >> > > Thanks!
> >> > >
> >> > > --
> >> > > Carlos Rovira
> >> > > http://about.me/carlosrovira
> >> > >
> >> > >
> >> > >
> >> >
> >> >
> >> > --
> >> >
> >> > Carlos Rovira
> >> > Director General
> >> > M: +34 607 22 60 05
> >> > http://www.codeoscopic.com
> >> > http://www.avant2.es
> >> >
> >> >
> >> > Este mensaje se dirige exclusivamente a su destinatario y puede
> >> >contener
> >> > información privilegiada o confidencial. Si ha recibido este
> >> mensaje
> >> >por
> >> > error, le rogamos que nos lo comunique inmediatamente por esta
> >> misma
> >> >vía y
> >> > proceda a su destrucción.
> >> >
> >> > De la vigente Ley Orgánica de Protección de Datos (15/1999), le
> >> >comunicamos
> >> > que sus datos forman parte de un fichero cuyo responsable es
> >> >CODEOSCOPIC
> >> > S.A. La finalidad de dicho tratamiento es facilitar la
> >>prestación
> >> del
> >> > servicio o información solicitados, teniendo usted derecho de
> >> acceso,
> >> > rectificación, cancelación y oposición de sus datos
> >>dirigiéndose a
> >> >nuestras
> >> > oficinas c/ Paseo de la Habana 9-11, 28036, Madrid con la
> >> >documentación
> >> > necesaria.
> >> >
> >> >
> >>
> >>
> >>
> >>
>
>
