I implemented an EffectBead. For now I used a String, but I think I'll be changing to use flags as Josh proposed.
2016-10-25 0:17 GMT+02:00 Alex Harui <aha...@adobe.com>: > > > On 10/24/16, 2:49 PM, "carlos.rov...@gmail.com on behalf of Carlos Rovira" > <carlos.rov...@gmail.com on behalf of carlos.rov...@codeoscopic.com> > wrote: > > >Hi Om, > > > >the last sample seems good to me and I agree with avoid having the > >"effect" > >attribute in the class and promote composition. So to start, I would > >remove > >the "mdlEffect" attribute from mdl components and instead create a bead > >with it, ok? > > It really is up to you (and customer feedback). Another advantage of > beads is that it makes the MXML full declarative. The compile will catch > you if you mistype <mdl:FAB> but will not catch you nor provide code > assist as you try to type "mdl-button--fab" and somehow remember to add > two hyphens in the right place. It is a trade-off of verbosity vs > catching compile time issues. I don't think there is a right answer, and > you can always provide more than one approach. > > Also realize that if you have more than one way to set className, folks > will may have to learn the order in which things are added to className. > If they want to inject some custom class selector and thus do: > > <mdl:Button class="myCustomClass"> > <mdl:Beads> > <mdl:effect1> > <mdl:effect2> > <mdl:effect3> > </mdl:Beads> > </mdl:Button> > > > How will they control where myCustomClass goes in the className list? > > Anyway, just pick something for now. Best plan is to get something that > folks can use, then you can get more opinions of how to make it easier. > > -Alex > > -- Carlos Rovira Director General M: +34 607 22 60 05 http://www.codeoscopic.com http://www.avant2.es Este mensaje se dirige exclusivamente a su destinatario y puede contener información privilegiada o confidencial. Si ha recibido este mensaje por error, le rogamos que nos lo comunique inmediatamente por esta misma vía y proceda a su destrucción. De la vigente Ley Orgánica de Protección de Datos (15/1999), le comunicamos que sus datos forman parte de un fichero cuyo responsable es CODEOSCOPIC S.A. La finalidad de dicho tratamiento es facilitar la prestación del servicio o información solicitados, teniendo usted derecho de acceso, rectificación, cancelación y oposición de sus datos dirigiéndose a nuestras oficinas c/ Paseo de la Habana 9-11, 28036, Madrid con la documentación necesaria.
