Took me a little while to get to this... Actually, I am really confused here. I don't have a real 'fix', but I understand what is causing it after chasing a few wild geese for a while. It seems the remove-circulars setting is the primary cause of this problem - removing that setting restores all the goog.requires stuff (which I *thought* I had already supported in the output), and after this js release mode seems fine. Is there any known bug here with remove-circulars? Or do I need to do something extra in the output to make it compatible with remove-circulars ?
On Fri, Sep 2, 2016 at 2:25 PM, Greg Dove <greg.d...@gmail.com> wrote: > ah. I was just about to circle back to this stuff. Thanks for picking that > up... yes I will fix that, my mistake! > > > On Fri, Sep 2, 2016 at 2:23 PM, Alex Harui <aha...@adobe.com> wrote: > >> >> >> On 9/1/16, 8:15 AM, "Alex Harui" <aha...@adobe.com> wrote: >> >> >I will take a look. >> > >> >Thanks for trying it. >> >> OK, I figured out why the release version is not working. The output for >> InstanceTimer (for example) which got re-based to inherit from >> EventDispatcher, is missing the goog.require for EventDispatcher. This >> fools the Google Closure Compiler and it does not emit EventDispatcher >> before InstanceTimer so the prototype never gets set properly and thus >> dispatchEvent is missing. It works in js-debug because other code happens >> to load EventDispatcher first. >> >> Do you want to make the fix to the compiler? >> >> Thanks, >> -Alex >> >> >
