GitHub user greg-dove opened a pull request:
https://github.com/apache/flex-asjs/pull/13
Binding improvements
These framework updates correspond to various compiler updates in
https://github.com/apache/flex-falcon/pull/8
The org.apache.flex.events.EventDispatcher change is a little hacky for JS
when the constructor target is defined but it was the only way to avoid runtime
errors quickly (this is when implementing IEventDispatcher in js). A better
solution would be desirable here.
Also, I did not add 'StaticPropertyWatcher' or any other separate
static-only binding classes. The rationale here was that the changes to support
it in the existing classes were minimal without the extra classes being loaded
each time (I am thinking more of js here). But this is easily changed if it is
not acceptable.
Also, I think the compiler now respects the settings in falcon for
<arg
value="-compiler.binding-event-handler-interface=org.apache.flex.events.IEventDispatcher"
/>
<arg
value="-compiler.binding-event-handler-class=org.apache.flex.events.EventDispatcher"
/>
<arg
value="-compiler.binding-event-handler-event=org.apache.flex.events.Event" />
so these are added to all the args in build_example.xml
I did not figure out the maven side of this
The JS configuration for the above is hard coded in BindableEmitter. I
don't think it should be configuratble? I assume it is locked to the framework
classes. But if it needed to be it would be easy to configure those
single-source settings in BindableEmitter for falcon-jx also.
If any of this is unclear or you want further discussion, please ask!
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/greg-dove/flex-asjs Binding_Improvements
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flex-asjs/pull/13.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #13
----
commit 275e13ea6f3d444f17dbf37d240cc45c874fd346
Author: greg-dove <greg.d...@gmail.com>
Date: 2016-08-19T22:09:29Z
[IMPROVEMENT] Added support for static bindings (SWF only, JS works after a
separate jx compiler update)
commit 2c21ebc419cd4e911c74f6247229ca6b375b46a9
Author: greg-dove <greg.d...@gmail.com>
Date: 2016-08-27T03:57:48Z
[BUGFIX] [PLEASE REVIEW] This seems necessary for IEventDispatcher
implementations (not extending EventDispatcher). Otherwise TypeError occurs.
Not ideal...
commit 95af7f023d7dc5130d9d7bb50041ca50fbcf3865
Author: greg-dove <greg.d...@gmail.com>
Date: 2016-08-29T00:13:14Z
[IMPROVEMENTS] Cumulative improvements across binding framework classes:
- Support in some classes added for static bindings
- removed n-2 check in _bindings loop because the extra null appended to
the _bindings array by falcon-jx has now gone
- when a child watcher is not found (e.g. last part of binding chain is not
bindable, update the value. This might need more attention
commit 674d97faf2bd5d4dc6803ae33d00539ddb111c50
Author: greg-dove <greg.d...@gmail.com>
Date: 2016-08-29T00:15:04Z
Added compiler directives for explicitly defining the framework bindable
dispatcher event-related classes
commit d24d195ccc6277b3bd3d3dd045ce70a07c57e262
Author: greg-dove <greg.d...@gmail.com>
Date: 2016-08-29T00:17:06Z
Merge branch 'develop' into static_binding_fix
commit c62b3ab270198c5163e4975e6605f175f9937f5b
Author: greg-dove <greg.d...@gmail.com>
Date: 2016-08-29T01:53:53Z
[EXAMPLE] Added new example for databinding tests
commit 2c3ac891661e218aaf1337dcc92d10218dc8f123
Author: greg-dove <greg.d...@gmail.com>
Date: 2016-08-29T02:55:31Z
Backported to support review and extra info about variants against current
develop branch
All commented out labels in MyIntialView represent errors or
non-functioning bindings.
commit 12a19762e46f34f60625c33da8292e10ae6fe0fc
Author: greg-dove <greg.d...@gmail.com>
Date: 2016-08-29T03:16:10Z
Merge branch 'Bindable_test_example' into Binding_improvements
commit a1b5d318a504b9832bdb059ab723e761bfa6f95d
Author: greg-dove <greg.d...@gmail.com>
Date: 2016-08-29T03:31:46Z
[EXAMPLE] updated the test examples with the latest status on the binding
variants
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
