IMO, if the Maven build pulls GCL from a public repo (no GCL code is bundled in any of our artifacts) there is no need for Chris to do anything here. We are subsetting for licensing reasons mostly although we do get some advantage at cross-compile time as well. Maven users may want all of GCL pulled down since that is its public packaging in the repo.
-Alex On 7/15/16, 7:04 AM, "Christofer Dutz" <christofer.d...@c-ware.de> wrote: >Oh gee ... It excludes something from deletion and hereby adds something >;-) >I'll re-check my build > >Chris > > > >Von meinem Samsung Galaxy Smartphone gesendet. > > >-------- Ursprüngliche Nachricht -------- >Von: Josh Tynjala <joshtynj...@gmail.com> >Datum: 15.07.16 15:58 (GMT+01:00) >An: dev@flex.apache.org >Betreff: Re: AW: git commit: [flex-asjs] [refs/heads/develop] - >downloads.xml: goog/bootstrap/nodejs.js is required for node.js support > >That's exactly what I was referring to. The downloads script downloads >"Google Closure Library". It deletes most of the library, but it didn't in >the past. That file should be excluded from deletion. > >- Josh >On Jul 15, 2016 12:37 AM, "Christofer Dutz" <christofer.d...@c-ware.de> >wrote: > >I just had a look at the recent commits and all I could find was that you >excluded the nodejs.js in the ASJS downloads script. Couldn't find >anything >in the GCL module though. > > >Chris > >________________________________ >Von: Josh Tynjala <joshtynj...@gmail.com> >Gesendet: Donnerstag, 14. Juli 2016 23:35:26 >An: dev@flex.apache.org >Betreff: Re: git commit: [flex-asjs] [refs/heads/develop] - downloads.xml: >goog/bootstrap/nodejs.js is required for node.js support > >FYI: I added goog/bootstrap/nodejs.js to the subset of GCL that we keep. >It >is required to continue supporting Node.js as a target. > >Chris, I assume that the Maven build also needs to be updated. > >- Josh > >On Thu, Jul 14, 2016 at 2:28 PM, <joshtynj...@apache.org> wrote: > >> Repository: flex-asjs >> Updated Branches: >> refs/heads/develop bf65776b6 -> 84e8ce50b >> >> >> downloads.xml: goog/bootstrap/nodejs.js is required for node.js support >> >> >> Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo >> Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/84e8ce50 >> Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/84e8ce50 >> Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/84e8ce50 >> >> Branch: refs/heads/develop >> Commit: 84e8ce50b2c424c9f53776bad6799272fc762c2a >> Parents: bf65776 >> Author: Josh Tynjala <joshtynj...@apache.org> >> Authored: Thu Jul 14 14:28:22 2016 -0700 >> Committer: Josh Tynjala <joshtynj...@apache.org> >> Committed: Thu Jul 14 14:28:22 2016 -0700 >> >> ---------------------------------------------------------------------- >> frameworks/downloads.xml | 2 ++ >> 1 file changed, 2 insertions(+) >> ---------------------------------------------------------------------- >> >> >> >> >http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/84e8ce50/frameworks/ >downloads.xml >> ---------------------------------------------------------------------- >> diff --git a/frameworks/downloads.xml b/frameworks/downloads.xml >> index e4f2cf7..6238641 100644 >> --- a/frameworks/downloads.xml >> +++ b/frameworks/downloads.xml >> @@ -207,6 +207,8 @@ >> <exclude name="closure/goog/reflect/reflect.js"/> >> <exclude name="closure/goog/string/string.js"/> >> <exclude name="closure/goog/useragent/useragent.js"/> >> + <!-- needed for node.js support --> >> + <exclude name="closure/goog/bootstrap/nodejs.js"/> >> </fileset> >> </delete> >> </target> >> >>
