I just fixed the bug that caused the assertion to fail when the include keyword was used as an identifier. However, there's another assertion failure in CSSArrayPropertyValueTests, so we still can't enable assertions by default on the compiler tests yet.
I tried enabling assertions on all of the compiler-jx tests too. In that case, everything passed, so I enabled them in the Ant script. - Josh On Tue, Jun 14, 2016 at 1:17 AM, Christofer Dutz <christofer.d...@c-ware.de> wrote: > Ok so I had another look, > > > I had to disable assertions for the integration tests too ... till then I > only disabled them in the unit-tests. > > > With assertions off I was able to run the tests. > > > Chris > > ________________________________ > Von: Christofer Dutz <christofer.d...@c-ware.de> > Gesendet: Montag, 13. Juni 2016 23:06:29 > An: dev@flex.apache.org > Betreff: AW: AW: AW: [Falcon] Declaring defines in config xml doesn't seem > to work > > Are assertions turned on in the ant build? > > Chris > > > > Von meinem Samsung Galaxy Smartphone gesendet. > > > -------- Ursprüngliche Nachricht -------- > Von: Josh Tynjala <joshtynj...@gmail.com> > Datum: 13.06.16 17:04 (GMT+01:00) > An: dev@flex.apache.org > Betreff: Re: AW: AW: [Falcon] Declaring defines in config xml doesn't seem > to work > > I made a change to the compiler recently to allow "include" to be a member > variable name, similar to other reserved words we recently allowed to match > JS behavior. I added this test for it, and it passed before I pushed. It's > strange that it's not working for you too. > > - Josh > On Jun 13, 2016 4:45 AM, "Christofer Dutz" <christofer.d...@c-ware.de> > wrote: > > > Well I did have to change this ... unfortunately one of the tests is > > failing continuously: > > > > > > Failed tests: > > > > > ASKeywordTests.ASKeyword_include_as_variable_name:333->ASFeatureTestsBase.compileAndRun:160->ASFeatureTestsBase.compileAndRun:126 > > Unxpected compilation problems: > > Internal error in ASParser subsystem, when generating code for: > > > /Users/christoferdutz/Projects/Apache/Flex/flex-falcon/compiler/target/surefire-temp/ASKeywordTests7800828148075033642.as: > > java.lang.AssertionError: only transfer reserved words > > at > > > org.apache.flex.compiler.internal.parsing.as.StreamingASTokenizer.treatKeywordAsIdentifier(StreamingASTokenizer.java:1326) > > at > > > org.apache.flex.compiler.internal.parsing.as.StreamingASTokenizer.next(StreamingASTokenizer.java:834) > > at > > > org.apache.flex.compiler.internal.parsing.as.StreamingTokenBuffer.fill(StreamingTokenBuffer.java:79) > > at > > > org.apache.flex.compiler.internal.parsing.as.StreamingTokenBuffer.lookAheadSkipInsertedSemicolon(StreamingTokenBuffer.java:136) > > at > > org.apache.flex.compiler.internal.parsing.as.BaseRepairingTokenBuffer.LT > > (BaseRepairingTokenBuffer.java:88) > > at > > org.apache.flex.compiler.internal.parsing.as.BaseRepairingTokenBuffer.LA > > (BaseRepairingTokenBuffer.java:108) > > at org.apache.flex.compiler.internal.parsing.as.BaseASParser.LA > > (BaseASParser.java:1999) > > at > > > org.apache.flex.compiler.internal.parsing.as.ASParser.directive(ASParser.java:157) > > at > > > org.apache.flex.compiler.internal.parsing.as.ASParser.classOrInterfaceBlock(ASParser.java:2822) > > at > > > org.apache.flex.compiler.internal.parsing.as.ASParser.classDefinition(ASParser.java:1451) > > at > > > org.apache.flex.compiler.internal.parsing.as.ASParser.definition(ASParser.java:808) > > at > > > org.apache.flex.compiler.internal.parsing.as.ASParser.attributedDefinition(ASParser.java:473) > > at > > > org.apache.flex.compiler.internal.parsing.as.ASParser.directive(ASParser.java:236) > > at > > > org.apache.flex.compiler.internal.parsing.as.ASParser.packageContents(ASParser.java:2696) > > at > > > org.apache.flex.compiler.internal.parsing.as.ASParser.packageDirective(ASParser.java:658) > > at > > > org.apache.flex.compiler.internal.parsing.as.ASParser.directive(ASParser.java:180) > > at > > > org.apache.flex.compiler.internal.parsing.as.ASParser.fileLevelDirectives(ASParser.java:126) > > at > > > org.apache.flex.compiler.internal.parsing.as.BaseASParser.file(BaseASParser.java:3027) > > at > > > org.apache.flex.compiler.internal.parsing.as.BaseASParser.parseFile(BaseASParser.java:1107) > > at > > > org.apache.flex.compiler.internal.parsing.as.ASParser.parseFile(ASParser.java:67) > > at > > > org.apache.flex.compiler.internal.parsing.as.BaseASParser.parseFile(BaseASParser.java:278) > > at > > > org.apache.flex.compiler.internal.units.ASCompilationUnit.createFileNode(ASCompilationUnit.java:313) > > at > > > org.apache.flex.compiler.internal.units.ASCompilationUnit.handleSyntaxTreeRequest(ASCompilationUnit.java:338) > > at > > > org.apache.flex.compiler.internal.units.CompilationUnitBase.processSyntaxTreeRequest(CompilationUnitBase.java:829) > > at > > > org.apache.flex.compiler.internal.units.CompilationUnitBase.access$100(CompilationUnitBase.java:107) > > at > > > org.apache.flex.compiler.internal.units.CompilationUnitBase$2$1.call(CompilationUnitBase.java:259) > > at > > > org.apache.flex.compiler.internal.units.CompilationUnitBase$2$1.call(CompilationUnitBase.java:255) > > at > > > org.apache.flex.compiler.internal.units.requests.RequestMaker$1.call(RequestMaker.java:228) > > at > > > org.apache.flex.compiler.internal.units.requests.RequestMaker$1.call(RequestMaker.java:222) > > at java.util.concurrent.FutureTask.run(FutureTask.java:262) > > at > > > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) > > at > > > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) > > at java.lang.Thread.run(Thread.java:745) > > > > Internal error in ABC generator subsystem, when generating code for: > > > /Users/christoferdutz/Projects/Apache/Flex/flex-falcon/compiler/target/surefire-temp/ASKeywordTests7800828148075033642.as: > > java.lang.AssertionError: Souce path not set. > > at > > > org.apache.flex.compiler.internal.tree.as.FunctionNode.parseFunctionBody(FunctionNode.java:782) > > at > > > org.apache.flex.compiler.internal.as.codegen.ClassDirectiveProcessor.declareFunction(ClassDirectiveProcessor.java:716) > > at > > > org.apache.flex.compiler.internal.as.codegen.DirectiveProcessor.processNode(DirectiveProcessor.java:214) > > at > > > org.apache.flex.compiler.internal.as.codegen.DirectiveProcessor.traverse(DirectiveProcessor.java:188) > > at > > > org.apache.flex.compiler.internal.as.codegen.GlobalDirectiveProcessor.declareClass(GlobalDirectiveProcessor.java:423) > > at > > > org.apache.flex.compiler.internal.as.codegen.DirectiveProcessor.processNode(DirectiveProcessor.java:206) > > at > > > org.apache.flex.compiler.internal.as.codegen.DirectiveProcessor.traverse(DirectiveProcessor.java:188) > > at > > > org.apache.flex.compiler.internal.as.codegen.GlobalDirectiveProcessor.declarePackage(GlobalDirectiveProcessor.java:449) > > at > > > org.apache.flex.compiler.internal.as.codegen.DirectiveProcessor.processNode(DirectiveProcessor.java:223) > > at > > > org.apache.flex.compiler.internal.as.codegen.DirectiveProcessor.traverse(DirectiveProcessor.java:188) > > at > > > org.apache.flex.compiler.internal.as.codegen.ABCGenerator.generate(ABCGenerator.java:122) > > at > > > org.apache.flex.compiler.internal.units.ASCompilationUnit.handleABCBytesRequest(ASCompilationUnit.java:487) > > at > > > org.apache.flex.compiler.internal.units.CompilationUnitBase.processABCBytesRequest(CompilationUnitBase.java:866) > > at > > > org.apache.flex.compiler.internal.units.CompilationUnitBase.access$300(CompilationUnitBase.java:107) > > at > > > org.apache.flex.compiler.internal.units.CompilationUnitBase$4$1.call(CompilationUnitBase.java:309) > > at > > > org.apache.flex.compiler.internal.units.CompilationUnitBase$4$1.call(CompilationUnitBase.java:305) > > at > > > org.apache.flex.compiler.internal.units.requests.RequestMaker$1.call(RequestMaker.java:228) > > at > > > org.apache.flex.compiler.internal.units.requests.RequestMaker$1.call(RequestMaker.java:222) > > at java.util.concurrent.FutureTask.run(FutureTask.java:262) > > at > > > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) > > at > > > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) > > at java.lang.Thread.run(Thread.java:745) > > > > > > Expected: is <0> > > got: <2> > > > > Any Ideas why this could be? Anything changed here? > > > > Chris > > > > > > > > ________________________________ > > Von: Alex Harui <aha...@adobe.com> > > Gesendet: Sonntag, 12. Juni 2016 07:35:39 > > An: dev@flex.apache.org > > Betreff: Re: AW: [Falcon] Declaring defines in config xml doesn't seem to > > work > > > > > > > > On 6/11/16, 10:57 AM, "Christofer Dutz" <christofer.d...@c-ware.de> > wrote: > > > > >Hi Alex, > > > > > > > > >I guess the chances that there aren't any breakages are slim, as I guess > > >they will break things for the maven build till I adjust the plugin [?] > > > > > > > Oh, sorry, didn't realize that. I ran sed and saw a pom.xml file changed > > and hoped everything Maven needed was in there. > > > > -Alex > > > > >
