And we definitely should look at the blocker issues ... I am for example using some little breaks to handle a few of them ...
Stuff like this shouldn't be in anything else than a POC: if (newLoc != null) b.addLocation(newLoc); else newLoc.getFile(); // force NullPointerException if newLoc == null Chris ________________________________ Von: Christofer Dutz <christofer.d...@c-ware.de> Gesendet: Freitag, 17. Juni 2016 09:39:58 An: dev@flex.apache.org Betreff: AW: AW: Coding conventions? Hi Alex, the SonarQube results aren't directly important for a release, but it would be good to start reducing the amounts of technical debt we are gathering. Currently it seems that we are producing technical debt faster than we are producing technical functionality. I made it a habit to have a look at such reports and to adjust the way I code to produce less technical debt. I would suggest others to do this too. Especially cause SonarQube usually provides an explanation why things are bad. Chris ________________________________ Von: Alex Harui <aha...@adobe.com> Gesendet: Donnerstag, 16. Juni 2016 16:02:04 An: dev@flex.apache.org Betreff: Re: AW: Coding conventions? Fred checked in an Eclipse formatter file (which, unfortunately, I never got in the habit of using). I noticed it is not in the repo right now. You can use git show 3ef34c70aaf5ca9c71f5fb55c1917eb055c98d66 to see it. How important is the SonarQube stuff to getting a release out? Could SonarQube wait for the next release? Thanks, -Alex On 6/16/16, 4:34 AM, "Christofer Dutz" <christofer.d...@c-ware.de> wrote: >I have seen some project use something like this [1] ... at least >IntelliJ understands it out of the box. > >It's an IDE independent format for defining settings like indentation, >end of line settings and so on. > > >Chris > > >[1]: http://editorconfig.org/ > >EditorConfig<http://editorconfig.org/> >editorconfig.org >EditorConfig is a file format and collection of text editor plugins for >maintaining consistent coding styles between different editors and IDEs. > > >________________________________ >Von: Christofer Dutz <christofer.d...@c-ware.de> >Gesendet: Donnerstag, 16. Juni 2016 13:06:47 >An: 'dev@flex.apache.org' >Betreff: Coding conventions? > >Hi, > > >I am currently having a look at the SonarQube findings, since activating >the Xml analysis the number of problems did jump up by about 1,1k most of >them being related to my Xml indention of 4 spaces instead of 2. Now it >would be one option to disable checks like this, but sometimes they are >good to have since some times it reveals problems you just don't seem to >be able to see. The other option would be to have code style checked. > > >Now I started thinking that it might be good to setup my IntelliJ to >format everything correctly and to make sure code I write follows the >rules. But I was unable to find a document like this. Do we have one? If >not, how about creating one and voting on it and make it official. > > >Chris
