Hi Chris,
I am not that familiar with how asserts work in Java, but it has seemed to
me that asserts are often or always disabled in Falcon code. The
debugger seems to stop on an assert, but it doesn't always fire. For
example, I think you are seeing the test fail on this assert:
assert getExpressionNode() instanceof IExpressionNode :
"getValue() shouldn't be getting called on a non-expression
MXMLFunctionNode";
And for me getExpressionNode() returns null, which IMO, is the correct
thing to return. So I think null isn't an instance of IExpressionNode,
but for me, the test continues to the next step in the debugger which is
why I think asserts are disabled. And should be for tests doing
degenerate case testing like how null values behave.
Does that make sense?
-Alex
On 2/23/16, 9:26 AM, "Christofer Dutz" <christofer.d...@c-ware.de> wrote:
>Hi Alex,
>
>Well I think that's something completely different. I never knew you
>could setup Eclipse to run every test each time you save, but that sort
>of doesn't seem to make much sense to me. Isn't Eclipse already slow
>enough? ;-)
>
>Usually you put the unit-tests together in the same project as the code
>they test. If you have cross-cutting integration test's it's ok to put
>them in a separate package, but unit- and component-tests I think belong
>to the code they test. I haven't come across a single project, except
>Flex, where this hasn't been that way, but I am pretty sure you can
>configure Eclipse to continue to run the tests. For maven there is a
>"lifecycle-mapping" feature in the M2Eclipse plugin, that might help.
>
>Coming back to the unit tests ... I have 8 failing tests that sort of
>don't look as if this is related to the maven migration:
>
>
>CSSNamespaceDefinitionTests.CSSNamespaceDefinitionTests_namespace1:64->get
>CSSNamespaceDefinition:40->CSSBaseTests.getCSSNodeBase:69 Do not strip
>namespace quotes in parser.
>
>CSSNamespaceDefinitionTests.CSSNamespaceDefinitionTests_namespace2:80->get
>CSSNamespaceDefinition:40->CSSBaseTests.getCSSNodeBase:69 Do not strip
>namespace quotes in parser.
> MXMLClassNodeTests.MXMLClassNode_empty2:68 getValue() shouldn't be
>getting called on a non-expression MXMLClassNode
> MXMLClassNodeTests.MXMLClassNode_empty3:80 getValue() shouldn't be
>getting called on a non-expression MXMLClassNode
> MXMLClassNodeTests.MXMLClassNode_empty1:56 getValue() shouldn't be
>getting called on a non-expression MXMLClassNode
> MXMLFunctionNodeTests.MXMLFunctionNode_empty2:69 getValue() shouldn't
>be getting called on a non-expression MXMLFunctionNode
> MXMLFunctionNodeTests.MXMLFunctionNode_empty3:81 getValue() shouldn't
>be getting called on a non-expression MXMLFunctionNode
> MXMLFunctionNodeTests.MXMLFunctionNode_empty1:57 getValue() shouldn't
>be getting called on a non-expression MXMLFunctionNode
>
>Do you have an idea, why they are red?
>
>Chris
>
>
>
>________________________________________
>Von: Alex Harui <aha...@adobe.com>
>Gesendet: Dienstag, 23. Februar 2016 17:53
>An: dev@flex.apache.org
>Betreff: Re: AW: AW: [FALCONJX]Compiling Falcon with externs problems
>
>On 2/23/16, 7:56 AM, "Christofer Dutz" <christofer.d...@c-ware.de> wrote:
>
>>Looking better and better each day :-)
>>
>>With my adjusted base-class I get this:
>>
>>Tests run: 375, Failures: 8, Errors: 0, Skipped: 26
>
>Good progress.
>
>I have a question about the Eclipse projects. Will we have to get rid of
>them and make Eclipse Maven projects? In the current set of projects, the
>unit tests are in their own Eclipse project, but I saw that you moved the
>tests under the source project. If the tests and source end up in a
>single Eclipse project, I assume the tests won't run after each save in
>the editor, right?
>
>Thanks,
>-Alex
>
