On 2/19/16, 12:50 PM, "Christofer Dutz" <christofer.d...@c-ware.de> wrote:
>Ok ... so what do you think of this? ;-) > >[INFO] >------------------------------------------------------------------------ >[INFO] BUILD SUCCESS >[INFO] >------------------------------------------------------------------------ >[INFO] Total time: 14.472 s >[INFO] Finished at: 2016-02-19T21:35:49+01:00 >[INFO] Final Memory: 29M/387M >[INFO] >------------------------------------------------------------------------ > >And the cool thing ... without a single environment variable ;-) Good progress! > >I finally managed to build the falcon.jar completely with maven. >Besides moving stuff around, I did need to create two additional >artifacts: >1. A maven plugin (falcon-unknown-tree-handler-generator-maven-plugin) >that generates some strange class from an xml file for that I moved the >org.apache.flex.compiler.internal.as.codegen.UnknownTreePatternInputOutput > class to that plugin (A code generation helper shouldn't be part of the >falcon jar anyway) I'm not that familiar with Maven plugins or the UnknownTreePattern code, but why did it have to become a Maven plugin? Won't that make it hard to have an Ant equivalent? I think it would be ok to remove that class from the Falcon jars, but why can't a Java file just be compiled and run as part of the Maven build? That's what it looks like the Ant build does. >2. I needed to move the interface >org.apache.flex.compiler.internal.as.codegen.IASNodeAdapter into a >dedicated jar as this class needs to be compiled in order for JBurg to be >able to run. Is that because Maven doesn't like dealing with .class files? > >One thing that's really ugly though, is that Antlr seems to look for the >vocabulary files "ImportMetadataTokenTypes.txt" in the directory where >the VM is started. Which is the root of the maven project ... have to >figure out something how I can avoid that. Will dig in to the sources of >the Antlr plugin and hopefully sort that out soon. Hmm. That file is not at the root of the current Falcon projects but Antlr2 seems to find it. > >But one thing that could be good, would be to streamline the used >generators a little ... we are using Antlr2, Antlr3, JFlex, JBurg and our >own custom one ... think that's not really nice for useablity. But for >now I'll focus on the maven migration. I'm not opposed to someone trying to consolidate this. I am pretty sure it won't be me. Thanks, -Alex
