UNSUBSCRIBE On Tue, Jan 5, 2016 at 12:50 PM, adufilie <g...@git.apache.org> wrote:
> Github user adufilie commented on the pull request: > > https://github.com/apache/flex-falcon/pull/5#issuecomment-169110068 > > Object.prototype.toString() is included in the es3.js extern file, but > it has a different signature than Number.prototype.toString(opt_radix), so > you cannot have it defined in Object.as and override in Number.as or any > other file. The original code had it working for Number/int/uint, but "new > Date().toString()" was giving an error because it was not including the > toString() function in the Date class. "new Object().toString()" does not > giving an error because Object uses the 'dynamic' keyword on the class > definition. > > One of the problems in createjs was that Filter.js documented > toString() with @return {string} but ColorFilter (extends Filter) did not > include a return type, so it became a void function and an incompatible > override. The other issue was that there was a hard-coded thing in > MethodReference.java to output an "AS3" namespace for a toString() override. > > > --- > If your project is set up for it, you can reply to this email and have your > reply appear on GitHub as well. If your project does not have this feature > enabled and wishes so, or if the feature is enabled but not working, please > contact infrastructure at infrastruct...@apache.org or file a JIRA ticket > with INFRA. > --- >
