Yes, please. Thank you for sticking to this!
Regards, Om On Mon, Dec 14, 2015 at 3:45 PM, Alex Harui <aha...@adobe.com> wrote: > Yay! So should I push the revert of that change? > > -Alex > > On 12/14/15, 3:26 PM, "omup...@gmail.com on behalf of OmPrakash Muppirala" > <omup...@gmail.com on behalf of bigosma...@gmail.com> wrote: > > >Good news. This approach seems to fix the fonts issue in charts. > >Before: http://snag.gy/UPl8h.jpg > >After: http://snag.gy/ewApw.jpg > > > >Tested it on my iOS app as well, seems to be working fine. > > > >It fixed font issues with Tooltips, LegendItems, etc. as well :-) > > > >No more double font embedding for mx charts! > > > >One thing that nags me is that I have to add a full path to the css file > >in > >my FB project like this: > >-theme+="C:\Program Files\Adobe\Adobe Flash Builder 4.7 (64 > >Bit)\sdks\4.14.1_with_AIR_20Beta\frameworks\projects\spark\MXFTEText.css" > > > >This could cause issues with team environments. One to fix this is to > >create a 'Linked Resource' variable pointing to the frameworks projects > >and > >using it. > > > >Thanks, > >Om > > > >On Mon, Dec 14, 2015 at 8:45 AM, OmPrakash Muppirala > ><bigosma...@gmail.com> > >wrote: > > > >> Oh, this is so cool. I will give it a try asap and report. > >> > >> Thanks, > >> Om > >> > >> On Sun, Dec 13, 2015 at 10:16 PM, Alex Harui <aha...@adobe.com> wrote: > >> > >>> So, I did some digging and found that: > >>> > >>> 1) Before the change to default to mx:Label, the Mustella chart tests > >>>were > >>> using Spark Label with embedded fonts. > >>> 2) There was already plumbing to better support Spark Label in Charts. > >>> I > >>> didn't know about it, but it appears that you are supposed to use the > >>> MXFTEText.css theme [2]. I tried it on the sample in FLEX-34909 [1] > >>>and > >>> it seemed to work there. It would be great if someone would confirm. > >>> FWIW, I found that in [2] I had to use the actual path to > >>>MXFTEText.css, I > >>> couldn't just start with "frameworks/projects..." > >>> > >>> So, I think we should revert back to defaulting to using Spark Label > >>>and > >>> then these tests should start passing again. > >>> > >>> Thoughts? > >>> -Alex > >>> > >>> > >>> [1] https://issues.apache.org/jira/browse/FLEX-34909 > >>> [2] > >>> > >>> > >>> > http://help.adobe.com/en_US/flex/using/WSda78ed3a750d6b8f-26a13bbf123c44 > >>>123 > >>> 9d-8000.html > >>> > >>>< > http://help.adobe.com/en_US/flex/using/WSda78ed3a750d6b8f-26a13bbf123c4 > >>>41239d-8000.html> > >>> > >>> > >>> On 12/11/15, 11:32 AM, "Alex Harui" <aha...@adobe.com> wrote: > >>> > >>> >I don't see any obvious degradation, but I know folks much better eyes > >>> >than I do. I think you are seeing the difference in rendering between > >>> >device and embedded fonts and maybe also TextLine vs TextField. > >>> > > >>> >There have been complaints in the past about embedded fonts looking > >>>more > >>> >fuzzy or blurry compared to device fonts. I think it has to do with > >>>the > >>> >glyph renderer getting too confident that it can render stems on > >>> >half-pixels instead of messing with kerning to try to put stems on > >>> pixels. > >>> > > >>> >-Alex > >>> > > >>> >From: Mark Kessler > >>> ><kesslerconsult...@gmail.com<mailto:kesslerconsult...@gmail.com>> > >>> >Reply-To: "dev@flex.apache.org<mailto:dev@flex.apache.org>" > >>> ><dev@flex.apache.org<mailto:dev@flex.apache.org>> > >>> >Date: Friday, December 11, 2015 at 11:21 AM > >>> >To: "dev@flex.apache.org<mailto:dev@flex.apache.org>" > >>> ><dev@flex.apache.org<mailto:dev@flex.apache.org>> > >>> >Subject: Re: mustella for charts > >>> > > >>> >Original baseline image: http://tinypic.com/r/245y5xe/9 > >>> >Current Bad image: http://tinypic.com/r/f0nnd0/9 > >>> > > >>> > > >>> > > >>> >On Fri, Dec 11, 2015 at 2:02 PM, Mark Kessler > >>> ><kesslerconsult...@gmail.com<mailto:kesslerconsult...@gmail.com>> > >>>wrote: > >>> >I'll hold off then for now. But I can tell you the current fonts > >>>being > >>> >shown in the baseline have a higher clarity than what the new > >>>baselines > >>> >would show. I'll see if this example goes through. First is current, > >>> >second is the new one. > >>> > > >>> > > >>> >[Inline image 3][Inline image 4] > >>> >-Mark > >>> > > >>> >On Fri, Dec 11, 2015 at 1:04 PM, Alex Harui > >>> ><aha...@adobe.com<mailto:aha...@adobe.com>> wrote: > >>> > > >>> > > >>> >On 12/11/15, 9:57 AM, "omup...@gmail.com<mailto:omup...@gmail.com> on > >>> >behalf of OmPrakash Muppirala" > >>> ><omup...@gmail.com<mailto:omup...@gmail.com> on behalf of > >>> >bigosma...@gmail.com<mailto:bigosma...@gmail.com>> wrote: > >>> > > >>> >>Do you know if Spark labels ever worked with Charts? I dont think > >>>so. > >>> > > >>> >I was wondering that myself. Somehow, the current chart baseline > >>>images > >>> >are showing text, so one thing I was going to do was dig into it to > >>>see > >>> >whether it was using TextLine or TextField. Maybe it is using > >>>TextLine > >>> >with device fonts. Certainly, your changes caused subtle rendering > >>> >differences and it might be useful to truly understand what the impact > >>> >will be. If someone could use right-to-left text with TextLine and > >>> device > >>> >fonts in Charts today, then replacing TextLine with TextField will > >>>break > >>> >them. > >>> > > >>> >-Alex > >>> > > >>> > > >>> > > >>> > >>> > >> > >
