Did I put the private vars in the constructor? I could swear I got that
pattern from someone else. I’m totally fine with changing it. But we
have to take care of the "shared non-scalar initializer" scenario.
On 6/2/15, 11:12 AM, "Erik de Bruin" <e...@ixsoftware.nl> wrote:
>Yeah... early days, I guess. UIBase has been around for a while.
>Progressive insight and all ;-)
>
>EdB
>
>
>
>On Tue, Jun 2, 2015 at 8:04 PM, Michael Schmalle
><teotigraphix...@gmail.com>
>wrote:
>
>> Ok, I only asked because I was looking at UIBase.js that Alex wrote and
>>he
>> doesn't declare prototypes only type declarations in the constructor.
>>
>> Mike
>>
>> On Tue, Jun 2, 2015 at 1:59 PM, Erik de Bruin <e...@ixsoftware.nl>
>>wrote:
>>
>> > >
>> > > 1. It doesn't look like you have private fields implemented to be
>> emitted
>> > > in the constructor? private fileds are going to the prototype. For
>> > > instance;
>> > >
>> > > private var explicitWidth:Number = NaN;
>> > >
>> > > to
>> > >
>> > > /**
>> > > * @private
>> > > * @type {number}
>> > > */
>> > > this.explicitWidth_ = NaN;
>> > >
>> > > Is this something that needs to happen, UIBase is what I am testing.
>> > >
>> >
>> > I think having the declaration on the prototype instead of in the
>> > constructor keep the JS closer to the AS, make the inheritance of the
>>JS
>> > class a bit more robust (?) and certainly makes the job of the Closure
>> > Compiler easier, as the coding conventions for 'goog' dictate the
>> > declaration of all fields on the prototype.
>> >
>> > EdB
>> >
>> >
>> >
>> > --
>> > Ix Multimedia Software
>> >
>> > Jan Luykenstraat 27
>> > 3521 VB Utrecht
>> >
>> > T. 06-51952295
>> > I. www.ixsoftware.nl
>> >
>>
>
>
>
>--
>Ix Multimedia Software
>
>Jan Luykenstraat 27
>3521 VB Utrecht
>
>T. 06-51952295
>I. www.ixsoftware.nl
