I took a quick look at them. Don’t see anything wrong with them, although for #4, I wondered if there was some other way to upgrade the -app.xml instead of locking down the swfversion.
It be interesting to see why we’ve had the good fortune of having Josh contribute. It would be cool if he’s using AntOnAir in his projects. Anyway, if you or anybody else has time to commit the patches and do whatever is needed to complete the pull request, that’d save me time. Thanks, -Alex On 4/24/15, 5:58 PM, "OmPrakash Muppirala" <bigosma...@gmail.com> wrote: >Alex, > >Can you take a look at these incoming patches, please? If not, I can take >a look at them when I get a chance. > >There are these 3 so far today: >https://patch-diff.githubusercontent.com/raw/apache/flex-utilities/pull/4. >patch >https://patch-diff.githubusercontent.com/raw/apache/flex-utilities/pull/5. >patch >https://patch-diff.githubusercontent.com/raw/apache/flex-utilities/pull/6. >patch > >Thanks, >Om > >On Fri, Apr 24, 2015 at 3:16 PM, joshtynjala <g...@git.apache.org> wrote: > >> GitHub user joshtynjala opened a pull request: >> >> https://github.com/apache/flex-utilities/pull/6 >> >> AntOnAIR: added support for <replacetoken> and <replacevalue> tags >> >> These tags may be added as children of the <replace> tag, similar to >> <replacefilter>. They make it possible to use CDATA and new lines in >>tokens >> and values. >> >> You can merge this pull request into a Git repository by running: >> >> $ git pull https://github.com/joshtynjala/flex-utilities >> ant-replacetoken-replacevalue >> >> Alternatively you can review and apply these changes as the patch at: >> >> https://github.com/apache/flex-utilities/pull/6.patch >> >> To close this pull request, make a commit to your master/trunk branch >> with (at least) the following in the commit message: >> >> This closes #6 >> >> ---- >> commit c45b078688dfcdc3c468af4c56983805987b24f6 >> Author: Josh Tynjala <joshtynj...@gmail.com> >> Date: 2015-04-24T22:15:22Z >> >> AntOnAIR: added support for <replacetoken> and <replacevalue> tags >> that may be added as childre of the <replace> tag, similar to >> <replacefilter>. These tags make it possible to use CDATA and new lines >>in >> tokens and values. >> >> ---- >> >> >> --- >> If your project is set up for it, you can reply to this email and have >>your >> reply appear on GitHub as well. If your project does not have this >>feature >> enabled and wishes so, or if the feature is enabled but not working, >>please >> contact infrastructure at infrastruct...@apache.org or file a JIRA >>ticket >> with INFRA. >> --- >>
