Hi Om, The patch file is made! See FLEX-34772
Dany > Op 28-feb.-2015, om 16:22 heeft Dany Dhondt <archeme...@mac.com> het volgende > geschreven: > > Hi Om, > > Update: > - I've set up Git and cloned the flex-sdk repo. > - I created a issue in Jira (34772) > - created a branch in Git for this issue > > > What to do now? Do I have to use this sdk in FB? > > thx, > > Dany > > >> Op 28-feb.-2015, om 12:16 heeft Dany Dhondt <archeme...@mac.com >> <mailto:archeme...@mac.com>> het volgende geschreven: >> >> ok Om, I'll give it a go! >> >> d >> >> >> >>> Op 27-feb.-2015, om 20:07 heeft OmPrakash Muppirala <bigosma...@gmail.com >>> <mailto:bigosma...@gmail.com>> het volgende geschreven: >>> >>> On Feb 27, 2015 12:00 AM, "Dany Dhondt" <archeme...@mac.com >>> <mailto:archeme...@mac.com>> wrote: >>>> >>>> Hi Om, >>>> >>>> I'm afraid I can't create a patch file, as much as I would like to, but >>> my knowledge of git is way too limited. >>>> What to do? >>> >>> Git is quite straightforward to get up to speed with. There is a very >>> detailed tutorial here: >>> https://cwiki.apache.org/confluence/display/FLEX/Git+for+Apache+Flex+Guide >>> <https://cwiki.apache.org/confluence/display/FLEX/Git+for+Apache+Flex+Guide> >>> >>> I hope that you will be able to contribute more and more to Apache Flex >>> once you cross this first hurdle, i.e. setting up Git :-) >>> >>> Please do feel free to ask any questions you may have regarding this. We >>> are here to help. >>> >>> Thanks, >>> Om >>> >>>> >>>> Dany >>>> >>>>> Op 26-feb.-2015, om 19:26 heeft OmPrakash Muppirala < >>> bigosma...@gmail.com> het volgende geschreven: >>>>> >>>>> Would you be interested in providing a patch file? Best would be to >>> create >>>>> a JIRA ticket and attach the patch file to it. >>>>> More details on how to create a patch file are here: >>>>> https://cwiki.apache.org/confluence/display/FLEX/7.+Patches >>>>> >>>>> Thanks, >>>>> Om >>>>> >>>>> On Thu, Feb 26, 2015 at 10:23 AM, Dany Dhondt <archeme...@mac.com> >>> wrote: >>>>> >>>>>> great! >>>>>> >>>>>> Dany Dhondt >>>>>> archeme...@mac.com | Mobile +32 496 251 455 >>>>>> >>>>>> >>>>>> >>>>>> >>>>>>> Op 26-feb.-2015, om 19:21 heeft OmPrakash Muppirala < >>>>>> bigosma...@gmail.com> het volgende geschreven: >>>>>>> >>>>>>> Good idea. I think the mx components supported something like this. >>> I >>>>>>> don't see a reason to not add this to the layout classes. >>>>>>> >>>>>>> Thanks, >>>>>>> Om >>>>>>> >>>>>>> On Thu, Feb 26, 2015 at 4:07 AM, Dany Dhondt <archeme...@mac.com> >>> wrote: >>>>>>> >>>>>>>> Hi all, >>>>>>>> >>>>>>>> I keep on typing this code: >>>>>>>> >>>>>>>> <s:layout> >>>>>>>> <s:VerticalLayout paddingTop="5" paddingRight="5" paddingBottom="5" >>>>>>>> paddingLeft="5"/> >>>>>>>> </s:layout> >>>>>>>> >>>>>>>> so I made my own layout class VerticalLayoutPadded which basically >>> does: >>>>>>>> >>>>>>>> public function set padding(value:int):void >>>>>>>> >>>>>>>> { >>>>>>>> >>>>>>>> _padding = value; >>>>>>>> >>>>>>>> this.paddingBottom = _padding; >>>>>>>> >>>>>>>> this.paddingLeft = _padding; >>>>>>>> >>>>>>>> this.paddingRight = _padding; >>>>>>>> >>>>>>>> this.paddingTop = _padding; >>>>>>>> >>>>>>>> } >>>>>>>> >>>>>>>> >>>>>>>> shouldn't we add this to the VerticalLayout and HorizontalLayout >>>>>> classes? >>>>>>>> It would be very convenient IMO. >>>>>>>> >>>>>>>> >>>>>>>> Dany >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>> >>>>>> >>>> >> > >
