If it breaks tests, at this point I suggest we (you?) revert that change on the 'release' branch. That way, it lives on to be fixed on the develop branch, but we'll be a step closer to a passing test suite.
EdB On Wed, Jan 14, 2015 at 6:41 PM, Alex Harui <aha...@adobe.com> wrote: > In my digging around, it appears that SpinnerList had a ‘bug’ where it > never applied accentColor to the renderer (more specifically, that the > renderer never was set to a selected state). > > Om made a change to set the renderer to a selected state so it started > picking up the accentColor. IMO, we need to decide whether that is a good > thing or not. > > -Alex > > On 1/14/15, 6:32 AM, "Erik de Bruin" <e...@ixsoftware.nl> wrote: > >>>>> 2 - SpinnerList (fails 2) >>>>> This was indeed a question of resetting the 'accentColor' style to >>>>> '#000000', which fixed all but 2 >>>> >>>>I took another look at these 2 and I'm now convinced the baselines are >>>>wrong. As the default 'accentColor' is black, and the tests do not >>>>override this style, the 'bad' pngs actually represent the expected >>>>outcome, as far as I can tell... >>> >>> It looks like you changed accentColor to 0 a few commits ago. The >>> baselines could still be wrong, but this needs more investigation. >> >>Yes, from a blue-ish color, and that fixed all but two tests. The >>tests that are still failing expect the custom skinned components to >>have NO accent color, and I can't find a way to make that happen with >>the current skins... Which led me to believe that those baselines may >>be off for those two tests. >> >>EdB >> >> >> >>-- >>Ix Multimedia Software >> >>Jan Luykenstraat 27 >>3521 VB Utrecht >> >>T. 06-51952295 >>I. www.ixsoftware.nl > -- Ix Multimedia Software Jan Luykenstraat 27 3521 VB Utrecht T. 06-51952295 I. www.ixsoftware.nl
