On 11/21/14, 11:35 PM, "Justin Mclean" <jus...@classsoftware.com> wrote:
>Hi, > >> We switched 4.12.1 and earlier to legacy a while back to deal with the >> SourceForge download problem. It appears that the Installer was never >> upgraded to handle the versionID attribute we added to the Ant install >> scripts that disambiguate 15 from 15-beta. > >So that could be a simple patch and release off the previous branch right >to fix? Or can we just remove 15 beta now 16 is out config file and that >sorts the issue? What exactly is required to handle the versionID >attribute? We’ll have the same issue if there is a 16 and 16 beta some day. Probably better to fix the installer. I’m not sure there is urgency. 4.13.0 works. Maybe we should just ship another Installer. Neil’s got a bunch of fixes in there. What do the analytics show for how often folks attempt to download 4.12.1 and earlier? > >I'm still not sure how it's possible it can work for 4.13 and not for >4.12 when both were released before we had that source forge issue and >both are using the same released code. The installer checks the config.xml file. If the legacy attribute is set, it runs the install logic in the Installer. If not, it runs the Ant_on_Air code that expects the installer.xml in the expanded release binary package. So, with a config.xml change, we can change whether the ant scripts run or not without modifying the release packages. Of course, that will fail someday when an ant script does something the installer code paths can’t do. -Alex
