yes, will change it tonight.
Thanks for the review !
Frédéric THOMAS

> From: li...@cranialinteractive.com
> To: dev@flex.apache.org
> Subject: RE: git commit: [flex-tlf] [refs/heads/develop] - FLEX-34592: Can't 
> use optionnal importer for TLF plainTextFormat and TextLayoutFormat
> Date: Mon, 13 Oct 2014 17:18:02 -0600
> 
> +1
>  
> 
> -----Original Message-----
> From: Justin Mclean [mailto:jus...@classsoftware.com] 
> Sent: October-13-14 4:33 PM
> To: dev@flex.apache.org
> Subject: Re: git commit: [flex-tlf] [refs/heads/develop] - FLEX-34592: Can't
> use optionnal importer for TLF plainTextFormat and TextLayoutFormat
> 
> Hi,
> 
> Wouldn't a better patch have been this?
> 
> if (textFlow) {
>       textScrap = new TextScrap(textFlow);                            
>                               
>       if (format == TextConverter.PLAIN_TEXT_FORMAT)
>               textScrap.setPlainText(true);
>       else if (format == TextConverter.TEXT_LAYOUT_FORMAT)
>               textScrap.setPlainText(false);
> }
> 
> Thanks,
> Justin
> 
                                          

Reply via email to