I have modified the chart code so that the JS side does not have borders
and scrollbars.

While looking at the HTML generated this morning, not only did I see the
extra <div>s and <svg>s, but I also saw that extra itemRenderers were
being generated. I pushed code that addresses that as well.

Now if we could get a GraphicContainer or something like it, we should be
able to have the itemRenderers just add a graphic element (e.g., Rect) as
they do now, except it would be parented by the ChartDataGroup (aka,
<svg>).

Peter Ent
Adobe Systems

On 9/11/14 6:40 PM, "OmPrakash Muppirala" <bigosma...@gmail.com> wrote:

>Peter,
>
>I just tested out the  ChartExample app.  It looks awesome!  Thanks for
>making this work end to end.  Nice to see validation that using SVG lets
>us
>do great visualizations that work exactly same in Flash and HTML5!
>
>A couple of things I noticed:
>
>1.  I see unnecessary horizontal and vertical scrollbars.  It seems that
>the the chart elements do not fit inside the div's width and height.
>2.  I am looking at the HTML for the chart, for example:Gist here:
>https://gist.github.com/bigosmallm/ae510538df51b8356d7d
>
>I see that we are creating a whole bunch of unnecessary divs and svg
>elements.  Would it be better if we created on SVG drawing canvas and drew
>all the graphics inside it?  It would make for a cleaner implementation
>and
>better runtime performance.
>
>I am thinking that we will create a GraphicsContainer class which would
>extend off of UIBase.  Inside it would be one SVG element where you can
>draw all the graphic elements in one co-ordinate space.
>
>Let me know what you think.
>
>Thanks,
>Om

Reply via email to