On Mon, Jul 28, 2014 at 2:46 AM, Christofer Dutz <christofer.d...@c-ware.de> wrote:
> Gee .. why didn't I get the original post ... > > so if the comment tracking is handled, I'm fine with that ... but still it > sounds as if the workflow is still not smooth. As far as I know you have to > have access to the account that recieves the pull request in order to apply > it. If you don't you have to manually pull the changes, apply them youself > and the initiating user hast to manually delete them ... or has Infra put > any work into this? > > Chris > > Yes, the workflow would be like this: 1. A non-committer forks the flex-sdk (or other repos) at https://github.com/apache/flex-sdk 2. They make some changes and generate a Pull Request (PR) 3. The PR notification is forwarded to dev@flex.apache.org 4. Folks can comment on/review the PR by replying to thread 5. The comments are forwarded to the Github PR page 6. An Apache Flex committer gets a patch version of the PR and integrates it into the flex-sdk repo on ASF git. 7. This gets merged into github.com/apache/flex-sdk 8. The committer then responds to the thread on dev@flex.apache.org asking the creator of the PR to close it. This process would make for better community involvement and not necessarily make committers' lives easier. Thanks, Om > ________________________________________ > Von: Christofer Dutz <christofer.d...@c-ware.de> > Gesendet: Montag, 28. Juli 2014 11:43 > An: dev@flex.apache.org > Betreff: AW: [LAZY] Enabling Github pull requests in Apache Flex > > Yeah, but if the Apache Git infrastructure doesn't support it, we can vote > as much as we like, it won't change anything at all ;-) > > I have seen some projects (Apache Camel) utilize a workflow where someone > clones the Projects Github repo and issues normal pull requests to that. > From then on some comitter in the project has to manually pull the > changes, apply them to the codebase and push them to the Apache repo after > which the changes get pushed to Github. After that the initiator has to > manaually delete the pull-request as we don't have any access to the Apache > GitHub account. So it's not really automatic. And discussions about > pull-requests tend to be held in Github and therefore are not archived by > Apache (Which they should especially as the Pull Requests have to be > deleted after they have been applied). I guess the "not having access to > the github account hosting our Flex projects" is the main problem here. So > we can't utilize the normal Github workflow. To me it looks as if there is > no real benefit in contrast to the "Add patch to Issue", but there are > drawbacks (Loosing discussion after deleting PullRequest). > > Chris > > > > > ________________________________________ > Von: João Fernandes <joaopedromartinsfernan...@gmail.com> > Gesendet: Montag, 28. Juli 2014 10:54 > An: dev@flex.apache.org > Betreff: Re: [LAZY] Enabling Github pull requests in Apache Flex > > Clearly a must have feature! > > > On 25 July 2014 01:34, OmPrakash Muppirala <bigosma...@gmail.com> wrote: > > > The INFRA team has started supporting [1] pull requests from github. If > no > > one has objections, I will open a ticket with INFRA to enable this > feature > > for Apache Flex. In particular, these are the benefits we get from > opting > > in for the tighter GitHub integration > > > > - Any Pull Request that gets opened, closed, reopened or commented on > > now gets recorded on the project's mailing list > > - If a project has a JIRA instance, any PRs or comments on PRs that > > include a JIRA ticket ID will trigger an update on that specific > ticket > > - Replying to a GitHub comment on the dev@ mailing list will trigger > a > > comment being placed on GitHub (yes, it works both ways!) > > - GitHub activity can now be relayed to IRC channels on the Freenode > > network. > > > > This means that we can actually accept pull requests from GitHub going > > forward. > > > > Thanks, > > Om > > > > [1] > > > > > https://blogs.apache.org/infra/entry/improved_integration_between_apache_and > > > > > > -- > > João Fernandes >
