Justin, This is the other commit that has been vetoed. Please revert asap. We need clean builds and Mustella to pass.
EdB On Tuesday, June 10, 2014, Alex Harui <aha...@adobe.com> wrote: > -1 for reasons stated below. > > Justin, you never responded so I'm thinking my attempts to ask you about > this have been missed in all the other noise. > > -Alex > > On 5/26/14 10:12 PM, "Alex Harui" <aha...@adobe.com> wrote: > > >This change broke Falcon, although Falcon is not reporting the failure > >correctly. And I'm sort of surprised it didn't break the SDK build > >because it introduces a dependency from spark.swc to mx.swc and mx.swc is > >not listed in the set of libraries used to build experimental.swc. > > > >It is also not a good idea to start dragging mx stuff into spark-only > >apps. Might affect mobile app sizes and might affect those with > >spark-only build setups. > > > >I'm not familiar with Callout, but in other components with drop downs, > >the drop down's owner property is set to the base component, then you > >check to see if the component "owns" the clicked item. Can similar logic > >be used here and eliminate the mx.swc dependency? > > > >Thanks, > >-Alex > > > >On 5/18/14 12:30 PM, "jmcl...@apache.org" <jmcl...@apache.org> wrote: > > > >>Repository: flex-sdk > >>Updated Branches: > >> refs/heads/develop 3a087a60e -> 080f5e64d > >> > >> > >>FLEX-34078 fix callouts closing when selecting dates in DateFields > >> > >> > >>Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo > >>Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/080f5e64 > >>Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/080f5e64 > >>Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/080f5e64 > >> > >>Branch: refs/heads/develop > >>Commit: 080f5e64d5718d76c51ecf6b07552b8bfc1b112e > >>Parents: 3a087a6 > >>Author: Justin Mclean <jmcl...@apache.org> > >>Authored: Sun May 18 12:30:41 2014 -0700 > >>Committer: Justin Mclean <jmcl...@apache.org> > >>Committed: Sun May 18 12:30:41 2014 -0700 > >> > >>---------------------------------------------------------------------- > >> .../src/spark/components/supportClasses/DropDownController.as | 3 > >>+++ > >> 1 file changed, 3 insertions(+) > >>---------------------------------------------------------------------- > >> > >> > >> > http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/080f5e64/frameworks/ > >>p > >>rojects/spark/src/spark/components/supportClasses/DropDownController.as > >>---------------------------------------------------------------------- > >>diff --git > >>a/frameworks/projects/spark/src/spark/components/supportClasses/DropDownC > >>o > >>ntroller.as > >>b/frameworks/projects/spark/src/spark/components/supportClasses/DropDownC > >>o > >>ntroller.as > >>index e1ff2fd..3641111 100644 > >>--- > >>a/frameworks/projects/spark/src/spark/components/supportClasses/DropDownC > >>o > >>ntroller.as > >>+++ > >>b/frameworks/projects/spark/src/spark/components/supportClasses/DropDownC > >>o > >>ntroller.as > >>@@ -38,6 +38,7 @@ import mx.managers.ISystemManager; > >> > >> import spark.components.DropDownList; > >> import spark.events.DropDownEvent; > >>+import mx.controls.CalendarLayout; > >> > >> use namespace mx_internal; > >> > >>@@ -613,6 +614,8 @@ public class DropDownController extends > >>EventDispatcher > >> var document:Obj -- Ix Multimedia Software Jan Luykenstraat 27 3521 VB Utrecht T. 06-51952295 I. www.ixsoftware.nl
