On 11/18/13 8:25 AM, "Maurice Amsellem" <maurice.amsel...@systar.com> wrote:
>> the code paths these tests used to verify are still there >Sorry, I send the email too quick. > >In fact, the only visual differences between old and new baselines are >because of sub-pixel diff. The rendering is the same. And the scrolling >behavior (that is the only changed behavior) is not tested. >If it was, it would have failed. > >WDYT? I haven't seen the image diffs, so I don't know what you mean by sub-pixel. There are two common cases: 1) a few pixels are different in corners and edges because the anti-aliasing chose slightly different values, and 2) everything moved by less than a pixel, in which case the diffs usually look like the outlines of entire characters in any fonts. For 1), it might be sufficient to use png.xml files, for 2) you have to worry that even a sub-pixel shift will be noticed by someone who has "pixel-perfected" their UI. Also, I may not be understanding the situation fully, but it now sounds like there are no tests for StageTextInputSkin? I was going to recommend copying a few tests (probably not all) and setting them up to use StageTextInputSkin in which case some of the old baselines would still be valid. -Alex
