On 11/14/13 12:37 PM, "OmPrakash Muppirala" <bigosma...@gmail.com> wrote:
>On Thu, Nov 14, 2013 at 12:19 PM, Peter Ent <p...@adobe.com> wrote: > >> >> >> On 11/14/13 2:55 PM, "OmPrakash Muppirala" <bigosma...@gmail.com> wrote: >> >> >On Thu, Nov 14, 2013 at 11:45 AM, Alex Harui <aha...@adobe.com> wrote: >> > >> >> >> >> >> >> On 11/14/13 10:57 AM, "OmPrakash Muppirala" <bigosma...@gmail.com> >> >>wrote: >> >> >> >> >On Wed, Nov 13, 2013 at 9:12 PM, Alex Harui <aha...@adobe.com> >>wrote: >> >> > >> >> >> >> >> >> >> >> >> On 11/13/13 8:26 PM, "OmPrakash Muppirala" <bigosma...@gmail.com> >> >> wrote: >> >> >> >> >> >> >I think I get it, but I guess I will need some pseudo code to >> >> >>understand >> >> >> >completely. What exactly does 'hang it on a strand' man in this >> >> >>context? >> >> >> > >> >> >> >Thanks, >> >> >> >Om >> >> >> I looked at the commit diffs again. I missed seeing earlier that >>you >> >> >>want >> >> >> to propagate rolloverindex to the List's API surface in order to >> >> >> communicate that information to the DataGrid. I was thinking that >> >>there >> >> >> can be some other List that represents the List that is a column >>in >> >>the >> >> >> DG. In theory it can be built out of most of the same pieces as >> >>List. >> >> >> >> >> > >> >> >I wanted to do that anyways. Right now, when there is more than a >> >>page of >> >> >data, three scrollbars (for 3 columns) show up. I wanted to create >>a >> >> >pared >> >> >down version of ListView that takes in an optional ScrollBar. And >> >>allow >> >> >the DataGridView to have a scrollbar. Any thoughts on that? >> >> Does the ScrollBar need to be optional for ListView? IMO, the custom >> >> ListView wouldn't have a scrollbar at all. >> >> >> > >> >(Option 1:) >> >I thought the ScrollBar could be a view bead that we can inject into >> >ListView as needed. >> > >> >(Option 2:) >> >Or do you mean that we create a new DataGridColumnListView with >>everything >> >in ListView except for ScrollBar and add RollOver behavior like you >> >mentioned earlier? >> > >> >Option 2 means that we are not DRY. With option 1, we can use a >>ListView >> >in mobile as well where there is no need for a visible scrollbar. >> >> I think Option 2 is best or the ListView has its Scrollbar removed and >>if >> you want a scrollable list you add that as a bead to the List strand. We >> could then package a ScrollableList which would probably be the one most >> people use. >> > >Your phrasing is a bit confusing. Are you proposing an option 3: >"ListView >has its Scrollbar removed and if >you want a scrollable list you add that as a bead to the List strand. " ? > >In that case, I like option 3. If I understand correct, it is like >option1 >except you want the scrollbar bead to be added to the List and not >ListView. In theory, if you get your beads encapsulated properly, then we'll still be DRY. The code that actually does the scrolling is not repeated. IMO, it isn't repeating yourself to have similar configurations of beads. For sure, there should be a List or ListView that has a scrollbar and one without. Whether scrolling is added to the List or ListView I don't think I have a set opinion on. We might create a ListWithScrollBars top-level component or maybe the scrolling implementation is specified in CSS so it can not be installed in mobile configs. Or maybe there is a ListView and ListViewWithScrollBars. The key point is that the ListView code doesn't have ScrollBar logic baked into it that maybe doesn't run based on some configuration. The goal is for that ScrollBar logic to be encapsulated in a bead. There's another implementation of a Scrolling UI which is the bumper bars at the top/bottom of a List or Menu. I think I get where you're coming from. Build the pieces and if we need to make separate classes that compose a few together to reduce the amount of typing, great, if not, even better. -Alex
