On Thu, Oct 24, 2013 at 3:14 PM, Maurice Amsellem < maurice.amsel...@systar.com> wrote:
> >Great catch! Thanks for investigating this. Any chance you could check > in the fix as well? ;-) > I will do. > > >Is this serious enough to warrant a new RC for the Installer? > > It's difficult to say. > > The impact are not very visible: > - an false error in the log (that is not opened by default) > - temp directory not deleted (that does not harm, and people can delete it > manually). > > Up to you... > > I think we can let this ship with the next release of the Installer. If someone has objections, please let us know. Thanks, Om > Maurice > > -----Message d'origine----- > De : omup...@gmail.com [mailto:omup...@gmail.com] De la part de OmPrakash > Muppirala > Envoyé : jeudi 24 octobre 2013 23:53 > À : dev@flex.apache.org > Objet : Re: [DISCUSS] Apache Flex SDK Installer 2.7 Release - RC2 > > On Thu, Oct 24, 2013 at 2:49 PM, Maurice Amsellem < > maurice.amsel...@systar.com> wrote: > > > >Maurice, I have seen this issue on and off and have not been able to > > reproduce this consistently on my machine. > > >It might be that there is a reference to the file held on to while > > unzipping >it or doing an MD5 checksum verification. > > > > Om, it's not on and off. It's always. > > I can save you some debugging time, as I compiled and debugged the > > installer source. > > The error is in MD5CompareUtil. > > > > Function compareSignature calls openAsync() on the SDK zip, but NEVER > > closes it when the comparison is done. > > I have checked that when returning from MD5 comparison, the file > > could not be deleted in the Explorer. > > > > > Great catch! Thanks for investigating this. Any chance you could check > in the fix as well? ;-) > > Is this serious enough to warrant a new RC for the Installer? > > Thanks, > Om > > > > Maurice > > > > -----Message d'origine----- > > De : omup...@gmail.com [mailto:omup...@gmail.com] De la part de > > OmPrakash Muppirala Envoyé : jeudi 24 octobre 2013 20:17 À : > > dev@flex.apache.org Objet : Re: [DISCUSS] Apache Flex SDK Installer > > 2.7 Release - RC2 > > > > On Wed, Oct 23, 2013 at 3:54 AM, Maurice Amsellem < > > maurice.amsel...@systar.com> wrote: > > > > > > I am still having the error "Cannot delete temp directories" > > > > although > > > the installation went well, and the temp/ directory is still there > > > at the end of the installation. > > > > (the folder was not opened in Windows Explorer, and anti-virus > > > > turned > > > off). > > > > > > I have checked the files inside the temp folder with Unlocker.exe. > > > > > > They are all unlocked except "apache-flex-sdk-4.11.0-bin.zip" > > > (locked by ApacheFlexInstaller), so maybe that's why the directory > > > cannot be > > deleted. > > > > > > Maurice > > > > > > > > Maurice, I have seen this issue on and off and have not been able to > > reproduce this consistently on my machine. It might be that there is > > a reference to the file held on to while unzipping it or doing an MD5 > > checksum verification. > > > > If you can please file a JIRA ticket for it, I can take a look at it > > when I have time. > > > > Thanks, > > Om > > > > > > > > >
