Thanks Justin,

I have made the change and pushed to develop.

Note that contrary to previous algorithm, timeString.length will be < 8 more 
often (first 1/16 of ~3 days cycle), so this fix is important.

Maurice 

-----Message d'origine-----
De : Justin Mclean [mailto:jus...@classsoftware.com] 
Envoyé : dimanche 20 octobre 2013 23:23
À : dev@flex.apache.org
Objet : Re: git commit: [flex-sdk] [refs/heads/develop] - FLEX-33829 improve 
create UID performance and use New algorithm using ByteArray around 4x faster 
than original.

Hi,

> for (i = 8; i > timeString.length; --i)

Would probably be better as:

var timeLength = timeString.length;
for (i = 8; i>timeLength; i--)

(As the condition is rarely encountered it's not a big deal)

Thanks,
Justin

Reply via email to